LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] spi: TI power management: add missing of table registration
@ 2019-04-22 19:09 Daniel Gomez
  2019-05-08 10:27 ` Lee Jones
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Gomez @ 2019-04-22 19:09 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, dagmcr, javier

MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
OF mathing mechanism and register it.

Before this patch:
modinfo drivers/mfd/tps65912-spi.ko | grep alias
alias:          spi:tps65912

After this patch:
modinfo drivers/mfd/tps65912-spi.ko | grep alias
alias:          of:N*T*Cti,tps65912C*
alias:          of:N*T*Cti,tps65912
alias:          spi:tps65912

Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
---
 drivers/mfd/tps65912-spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 3bd7506..f78be03 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -27,6 +27,7 @@ static const struct of_device_id tps65912_spi_of_match_table[] = {
 	{ .compatible = "ti,tps65912", },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, tps65912_spi_of_match_table);
 
 static int tps65912_spi_probe(struct spi_device *spi)
 {
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: TI power management: add missing of table registration
  2019-04-22 19:09 [PATCH] spi: TI power management: add missing of table registration Daniel Gomez
@ 2019-05-08 10:27 ` Lee Jones
  2019-05-11  8:28   ` Daniel G
  0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2019-05-08 10:27 UTC (permalink / raw)
  To: Daniel Gomez; +Cc: linux-kernel, javier

The subject line is not correct.  This is an MFD driver.

When submitting you should follow the convention for the subsystem you
are patching against.  The following command is helpful:

  `git log --oneline -- <SUBSYSTEM>`

I will fix it for you this time (and for the other patch I see).

On Mon, 22 Apr 2019, Daniel Gomez wrote:

> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
> 
> Before this patch:
> modinfo drivers/mfd/tps65912-spi.ko | grep alias
> alias:          spi:tps65912
> 
> After this patch:
> modinfo drivers/mfd/tps65912-spi.ko | grep alias
> alias:          of:N*T*Cti,tps65912C*
> alias:          of:N*T*Cti,tps65912
> alias:          spi:tps65912
> 
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> ---
>  drivers/mfd/tps65912-spi.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: TI power management: add missing of table registration
  2019-05-08 10:27 ` Lee Jones
@ 2019-05-11  8:28   ` Daniel G
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel G @ 2019-05-11  8:28 UTC (permalink / raw)
  To: Lee Jones; +Cc: open list, Javier Martinez Canillas

On Wed, May 8, 2019 at 12:27 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> The subject line is not correct.  This is an MFD driver.
>
> When submitting you should follow the convention for the subsystem you
> are patching against.  The following command is helpful:
>
>   `git log --oneline -- <SUBSYSTEM>`
>
> I will fix it for you this time (and for the other patch I see).
>
Sorry for that and thanks for rewriting the subject.

> On Mon, 22 Apr 2019, Daniel Gomez wrote:
>
> > MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> > OF mathing mechanism and register it.
> >
> > Before this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias:          spi:tps65912
> >
> > After this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias:          of:N*T*Cti,tps65912C*
> > alias:          of:N*T*Cti,tps65912
> > alias:          spi:tps65912
> >
> > Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> > Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> > ---
> >  drivers/mfd/tps65912-spi.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Applied, thanks.
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-11  8:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-22 19:09 [PATCH] spi: TI power management: add missing of table registration Daniel Gomez
2019-05-08 10:27 ` Lee Jones
2019-05-11  8:28   ` Daniel G

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).