LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching
@ 2019-04-18  9:14 Jan Kiszka
  2019-04-26 14:44 ` Andy Shevchenko
  2019-05-08 10:33 ` Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2019-04-18  9:14 UTC (permalink / raw)
  To: Lee Jones; +Cc: Linux Kernel Mailing List, Andy Shevchenko, Su Bao Cheng

From: Su Bao Cheng <baocheng.su@siemens.com>

Since there are more IOT2040 variants with identical hardware but
different asset tags, the asset tag matching should be adjusted to
support them.

For the board name "SIMATIC IOT2000", currently there are 2 types of
hardware, IOT2020 and IOT2040. Both are identical regarding the
intel_quark_i2c_gpio. In the future there will be no other devices with
the "SIMATIC IOT2000" DMI board name but different hardware. So remove
the asset tag matching from this driver.

Signed-off-by: Su Bao Cheng <baocheng.su@siemens.com>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
index 5bddb84cfc1f..11adbf77960d 100644
--- a/drivers/mfd/intel_quark_i2c_gpio.c
+++ b/drivers/mfd/intel_quark_i2c_gpio.c
@@ -74,16 +74,6 @@ static const struct dmi_system_id dmi_platform_info[] = {
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
-			DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
-					"6ES7647-0AA00-0YA2"),
-		},
-		.driver_data = (void *)400000,
-	},
-	{
-		.matches = {
-			DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
-			DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
-					"6ES7647-0AA00-1YA2"),
 		},
 		.driver_data = (void *)400000,
 	},
-- 
2.16.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching
  2019-04-18  9:14 [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching Jan Kiszka
@ 2019-04-26 14:44 ` Andy Shevchenko
  2019-05-08 10:33 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-04-26 14:44 UTC (permalink / raw)
  To: Jan Kiszka
  Cc: Lee Jones, Linux Kernel Mailing List, Andy Shevchenko, Su Bao Cheng

On Thu, Apr 18, 2019 at 12:15 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> From: Su Bao Cheng <baocheng.su@siemens.com>
>
> Since there are more IOT2040 variants with identical hardware but
> different asset tags, the asset tag matching should be adjusted to
> support them.
>
> For the board name "SIMATIC IOT2000", currently there are 2 types of
> hardware, IOT2020 and IOT2040. Both are identical regarding the
> intel_quark_i2c_gpio. In the future there will be no other devices with
> the "SIMATIC IOT2000" DMI board name but different hardware. So remove
> the asset tag matching from this driver.
>

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Su Bao Cheng <baocheng.su@siemens.com>
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
> index 5bddb84cfc1f..11adbf77960d 100644
> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> @@ -74,16 +74,6 @@ static const struct dmi_system_id dmi_platform_info[] = {
>         {
>                 .matches = {
>                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> -                       DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> -                                       "6ES7647-0AA00-0YA2"),
> -               },
> -               .driver_data = (void *)400000,
> -       },
> -       {
> -               .matches = {
> -                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> -                       DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> -                                       "6ES7647-0AA00-1YA2"),
>                 },
>                 .driver_data = (void *)400000,
>         },
> --
> 2.16.4



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching
  2019-04-18  9:14 [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching Jan Kiszka
  2019-04-26 14:44 ` Andy Shevchenko
@ 2019-05-08 10:33 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-05-08 10:33 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Linux Kernel Mailing List, Andy Shevchenko, Su Bao Cheng

On Thu, 18 Apr 2019, Jan Kiszka wrote:

> From: Su Bao Cheng <baocheng.su@siemens.com>
> 
> Since there are more IOT2040 variants with identical hardware but
> different asset tags, the asset tag matching should be adjusted to
> support them.
> 
> For the board name "SIMATIC IOT2000", currently there are 2 types of
> hardware, IOT2020 and IOT2040. Both are identical regarding the
> intel_quark_i2c_gpio. In the future there will be no other devices with
> the "SIMATIC IOT2000" DMI board name but different hardware. So remove
> the asset tag matching from this driver.
> 
> Signed-off-by: Su Bao Cheng <baocheng.su@siemens.com>
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
>  1 file changed, 10 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-08 10:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18  9:14 [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching Jan Kiszka
2019-04-26 14:44 ` Andy Shevchenko
2019-05-08 10:33 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).