LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY.
@ 2019-05-08 10:35 Wen He
  2019-05-08 10:35 ` [v1 2/4] arm64: dts: ls1028a: Add properties for HDP Controller Wen He
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Wen He @ 2019-05-08 10:35 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, devicetree, shawnguo, robh+dt
  Cc: Leo Li, Wen He

Add DT bindings documentmation for the HDP-TX PHY controller. The describes
which could be found on NXP Layerscape ls1028a platform.

Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 .../devicetree/bindings/display/fsl,hdp.txt   | 56 +++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/fsl,hdp.txt

diff --git a/Documentation/devicetree/bindings/display/fsl,hdp.txt b/Documentation/devicetree/bindings/display/fsl,hdp.txt
new file mode 100644
index 000000000000..36b5687a1261
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/fsl,hdp.txt
@@ -0,0 +1,56 @@
+NXP Layerscpae ls1028a HDP-TX PHY Controller
+============================================
+
+The following bindings describe the Cadence HDP TX PHY on ls1028a that
+offer multi-protocol support of standars such as eDP and Displayport,
+supports for 25-600MHz pixel clock and up to 4k2k at 60MHz resolution.
+The HDP transmitter is a Cadence HDP TX controller IP with a companion
+PHY IP.
+
+Required properties:
+  - compatible:   Should be "fsl,ls1028a-dp" for ls1028a.
+  - reg:          Physical base address and size of the block of registers used
+  by the processor.
+  - interrupts:   HDP hotplug in/out detect interrupt number
+  - clocks:       A list of phandle + clock-specifier pairs, one for each entry
+  in 'clock-names'
+  - clock-names:  A list of clock names. It should contain:
+      - "clk_ipg": inter-Integrated circuit clock
+      - "clk_core": for the Main Display TX controller clock
+      - "clk_pxl": for the pixel clock feeding the output PLL of the processor
+      - "clk_pxl_mux": for the high PerfPLL bypass clock
+      - "clk_pxl_link": for the link rate pixel clock
+      - "clk_apb": for the APB interface clock
+      - "clk_vif": for the Video pixel clock
+
+Required sub-nodes:
+  - port: The HDP connection to an encoder output port. The connection
+    is modelled using the OF graph bindings specified in
+    Documentation/devicetree/bindings/graph.txt
+
+
+Example:
+
+/ {
+        ...
+
+	hdp: display@f200000 {
+                compatible = "fsl,ls1028a-dp";
+		reg = <0x0 0xf1f0000 0x0 0xffff>,
+		    <0x0 0xf200000 0x0 0xfffff>;
+                interrupts = <0 221 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&sysclk>, <&hdpclk>, <&dpclk>,
+                         <&dpclk>, <&dpclk>, <&pclk>, <&dpclk>;
+		clock-names = "clk_ipg", "clk_core", "clk_pxl",
+                              "clk_pxl_mux", "clk_pxl_link", "clk_apb",
+                              "clk_vif";
+
+		port {
+			dp1_output: endpoint {
+				remote-endpoint = <&dp0_input>;
+			};
+		};
+        };
+
+        ...
+};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [v1 2/4] arm64: dts: ls1028a: Add properties for HDP Controller.
  2019-05-08 10:35 [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Wen He
@ 2019-05-08 10:35 ` Wen He
  2019-05-08 10:35 ` [v1 3/4] arm64: ls1028aqds: Add support DP nodes for LS1028AQDS Wen He
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Wen He @ 2019-05-08 10:35 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, devicetree, shawnguo, robh+dt
  Cc: Leo Li, Wen He

This patch enables the HDP controller driver on the LS1028A.

Signed-off-by: Alison Wang <aslion.wang@nxp.com>
Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index c0a13f9e5b95..158fdf26a117 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -91,6 +91,13 @@
 		clock-output-names= "pclk";
 	};
 
+	hdpclk: clock-hdpcore {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <162500000>;
+		clock-output-names= "hdpclk";
+	};
+
 	reboot {
 		compatible ="syscon-reboot";
 		regmap = <&dcfg>;
@@ -467,7 +474,25 @@
 
 		port {
 			dp0_out: endpoint {
+				remote-endpoint = <&dp1_out>;
+			};
+		};
+	};
 
+	hdp: display@f200000 {
+		compatible = "fsl,ls1028a-dp";
+		reg = <0x0 0xf1f0000 0x0 0xffff>,
+		    <0x0 0xf200000 0x0 0xfffff>;
+		interrupts = <0 221 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&sysclk>, <&hdpclk>, <&dpclk>,
+			 <&dpclk>, <&dpclk>, <&pclk>, <&dpclk>;
+		clock-names = "clk_ipg", "clk_core", "clk_pxl",
+			      "clk_pxl_mux", "clk_pxl_link", "clk_apb",
+			      "clk_vif";
+
+		port {
+			dp1_out: endpoint {
+				remote-endpoint = <&dp0_out>;
 			};
 		};
 	};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [v1 3/4] arm64: ls1028aqds: Add support DP nodes for LS1028AQDS
  2019-05-08 10:35 [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Wen He
  2019-05-08 10:35 ` [v1 2/4] arm64: dts: ls1028a: Add properties for HDP Controller Wen He
@ 2019-05-08 10:35 ` Wen He
  2019-05-08 10:35 ` [v1 4/4] arm64: ls1028ardb: Add support DP nodes for LS1028ARDB Wen He
  2019-06-13 20:08 ` [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Rob Herring
  3 siblings, 0 replies; 8+ messages in thread
From: Wen He @ 2019-05-08 10:35 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, devicetree, shawnguo, robh+dt
  Cc: Leo Li, Wen He

This patch add HDP PHY Controller related nodes on the LS1028AQDS.
Now LS1028AQDS on DP has following features:
- Supports 4 dp lane channel and lane mapping is 1-0-3-2.
- By default, the pixel link rate value's 27Mhz.
- By default, support the resoluions are 4k@60,1080p@60,720p@60,
480p@60. also user can specify any combination of monitor supported
resoluions by written in the node 'resoluion'.
- By default, the edid function is not in use.

Signed-off-by: Alison Wang <alison.wang@nxp.com>
Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index b359068d9605..c8a92d4c4964 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -153,3 +153,15 @@
 &sai1 {
 	status = "okay";
 };
+
+&hdp {
+	fsl,no_edid;
+	resolution = "3840x2160@60",
+		   "1920x1080@60",
+		   "1280x720@60",
+		   "720x480@60";
+	lane_mapping = <0x4e>;
+	edp_link_rate = <0x6>;
+	edp_num_lanes = <0x4>;
+	status = "okay";
+};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [v1 4/4] arm64: ls1028ardb: Add support DP nodes for LS1028ARDB
  2019-05-08 10:35 [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Wen He
  2019-05-08 10:35 ` [v1 2/4] arm64: dts: ls1028a: Add properties for HDP Controller Wen He
  2019-05-08 10:35 ` [v1 3/4] arm64: ls1028aqds: Add support DP nodes for LS1028AQDS Wen He
@ 2019-05-08 10:35 ` Wen He
  2019-06-13 20:08 ` [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Rob Herring
  3 siblings, 0 replies; 8+ messages in thread
From: Wen He @ 2019-05-08 10:35 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, devicetree, shawnguo, robh+dt
  Cc: Leo Li, Wen He

This patch add HDP PHY Controller related nodes on the LS1028ARDB.
Now LS1028ARDB on DP has following features:
- Supports 4 dp lane channel and lane mapping is 1-0-3-2.
- By default, the pixel link rate value's 27Mhz.
- By default, support the resoluions are 4k@60,1080p@60,720p@60,
480p@60. also user can specify any combination of monitor supported
resoluions by written in the node 'resoluion'.
- By default, the edid function is not in use.

Signed-off-by: Alison Wang <alison.wang@nxp.com>
Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index f9c272fb0738..513b0e37ea13 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -151,3 +151,15 @@
 &sai4 {
 	status = "okay";
 };
+
+&hdp {
+	fsl,no_edid;
+	resolution = "3840x2160@60",
+		   "1920x1080@60",
+		   "1280x720@60",
+		   "720x480@60";
+	lane_mapping = <0x4e>;
+	edp_link_rate = <0x6>;
+	edp_num_lanes = <0x4>;
+	status = "okay";
+};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY.
  2019-05-08 10:35 [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Wen He
                   ` (2 preceding siblings ...)
  2019-05-08 10:35 ` [v1 4/4] arm64: ls1028ardb: Add support DP nodes for LS1028ARDB Wen He
@ 2019-06-13 20:08 ` Rob Herring
  2019-06-17  1:45   ` [EXT] " Wen He
  3 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2019-06-13 20:08 UTC (permalink / raw)
  To: Wen He; +Cc: linux-kernel, linux-arm-kernel, devicetree, shawnguo, Leo Li

On Wed, May 08, 2019 at 10:35:25AM +0000, Wen He wrote:
> Add DT bindings documentmation for the HDP-TX PHY controller. The describes
> which could be found on NXP Layerscape ls1028a platform.

Drop the hard stop (.) from the subject.

> 
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
>  .../devicetree/bindings/display/fsl,hdp.txt   | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/fsl,hdp.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/fsl,hdp.txt b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> new file mode 100644
> index 000000000000..36b5687a1261
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> @@ -0,0 +1,56 @@
> +NXP Layerscpae ls1028a HDP-TX PHY Controller
> +============================================
> +
> +The following bindings describe the Cadence HDP TX PHY on ls1028a that
> +offer multi-protocol support of standars such as eDP and Displayport,
> +supports for 25-600MHz pixel clock and up to 4k2k at 60MHz resolution.
> +The HDP transmitter is a Cadence HDP TX controller IP with a companion
> +PHY IP.

I'm confused. This binding covers both blocks or is just one of them?

> +
> +Required properties:
> +  - compatible:   Should be "fsl,ls1028a-dp" for ls1028a.
> +  - reg:          Physical base address and size of the block of registers used
> +  by the processor.
> +  - interrupts:   HDP hotplug in/out detect interrupt number
> +  - clocks:       A list of phandle + clock-specifier pairs, one for each entry
> +  in 'clock-names'
> +  - clock-names:  A list of clock names. It should contain:
> +      - "clk_ipg": inter-Integrated circuit clock
> +      - "clk_core": for the Main Display TX controller clock
> +      - "clk_pxl": for the pixel clock feeding the output PLL of the processor
> +      - "clk_pxl_mux": for the high PerfPLL bypass clock
> +      - "clk_pxl_link": for the link rate pixel clock
> +      - "clk_apb": for the APB interface clock
> +      - "clk_vif": for the Video pixel clock

The 'clk_' part is redundant.

> +
> +Required sub-nodes:
> +  - port: The HDP connection to an encoder output port. The connection
> +    is modelled using the OF graph bindings specified in
> +    Documentation/devicetree/bindings/graph.txt
> +
> +
> +Example:
> +
> +/ {
> +        ...
> +
> +	hdp: display@f200000 {
> +                compatible = "fsl,ls1028a-dp";
> +		reg = <0x0 0xf1f0000 0x0 0xffff>,
> +		    <0x0 0xf200000 0x0 0xfffff>;
> +                interrupts = <0 221 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&sysclk>, <&hdpclk>, <&dpclk>,
> +                         <&dpclk>, <&dpclk>, <&pclk>, <&dpclk>;
> +		clock-names = "clk_ipg", "clk_core", "clk_pxl",
> +                              "clk_pxl_mux", "clk_pxl_link", "clk_apb",
> +                              "clk_vif";
> +
> +		port {
> +			dp1_output: endpoint {
> +				remote-endpoint = <&dp0_input>;
> +			};
> +		};
> +        };
> +
> +        ...
> +};
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [EXT] Re: [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY.
  2019-06-13 20:08 ` [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Rob Herring
@ 2019-06-17  1:45   ` Wen He
  2019-06-19 14:07     ` Rob Herring
  0 siblings, 1 reply; 8+ messages in thread
From: Wen He @ 2019-06-17  1:45 UTC (permalink / raw)
  To: Rob Herring; +Cc: linux-kernel, linux-arm-kernel, devicetree, shawnguo, Leo Li



> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2019年6月14日 4:08
> To: Wen He <wen.he_1@nxp.com>
> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; shawnguo@kernel.org; Leo Li
> <leoyang.li@nxp.com>
> Subject: [EXT] Re: [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A
> HDP-TX PHY.
> 
> Caution: EXT Email
> 
> On Wed, May 08, 2019 at 10:35:25AM +0000, Wen He wrote:
> > Add DT bindings documentmation for the HDP-TX PHY controller. The
> > describes which could be found on NXP Layerscape ls1028a platform.
> 
> Drop the hard stop (.) from the subject.
> 
> >
> > Signed-off-by: Wen He <wen.he_1@nxp.com>
> > ---
> >  .../devicetree/bindings/display/fsl,hdp.txt   | 56 +++++++++++++++++++
> >  1 file changed, 56 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/fsl,hdp.txt
> >
> > diff --git a/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > new file mode 100644
> > index 000000000000..36b5687a1261
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > @@ -0,0 +1,56 @@
> > +NXP Layerscpae ls1028a HDP-TX PHY Controller
> > +============================================
> > +
> > +The following bindings describe the Cadence HDP TX PHY on ls1028a
> > +that offer multi-protocol support of standars such as eDP and
> > +Displayport, supports for 25-600MHz pixel clock and up to 4k2k at 60MHz
> resolution.
> > +The HDP transmitter is a Cadence HDP TX controller IP with a
> > +companion PHY IP.
> 
> I'm confused. This binding covers both blocks or is just one of them?
> 

Hi Rob,

This binding covers both blocks(HDP TX PHY and HDP TX Controller), 
Because they are belong to the one IP.

> > +
> > +Required properties:
> > +  - compatible:   Should be "fsl,ls1028a-dp" for ls1028a.
> > +  - reg:          Physical base address and size of the block of registers
> used
> > +  by the processor.
> > +  - interrupts:   HDP hotplug in/out detect interrupt number
> > +  - clocks:       A list of phandle + clock-specifier pairs, one for each
> entry
> > +  in 'clock-names'
> > +  - clock-names:  A list of clock names. It should contain:
> > +      - "clk_ipg": inter-Integrated circuit clock
> > +      - "clk_core": for the Main Display TX controller clock
> > +      - "clk_pxl": for the pixel clock feeding the output PLL of the processor
> > +      - "clk_pxl_mux": for the high PerfPLL bypass clock
> > +      - "clk_pxl_link": for the link rate pixel clock
> > +      - "clk_apb": for the APB interface clock
> > +      - "clk_vif": for the Video pixel clock
> 
> The 'clk_' part is redundant.
> 

You mean should I remove these 'clk_' part?

Thanks for the review.

Best Regards,
Wen

> > +
> > +Required sub-nodes:
> > +  - port: The HDP connection to an encoder output port. The connection
> > +    is modelled using the OF graph bindings specified in
> > +    Documentation/devicetree/bindings/graph.txt
> > +
> > +
> > +Example:
> > +
> > +/ {
> > +        ...
> > +
> > +     hdp: display@f200000 {
> > +                compatible = "fsl,ls1028a-dp";
> > +             reg = <0x0 0xf1f0000 0x0 0xffff>,
> > +                 <0x0 0xf200000 0x0 0xfffff>;
> > +                interrupts = <0 221 IRQ_TYPE_LEVEL_HIGH>;
> > +             clocks = <&sysclk>, <&hdpclk>, <&dpclk>,
> > +                         <&dpclk>, <&dpclk>, <&pclk>, <&dpclk>;
> > +             clock-names = "clk_ipg", "clk_core", "clk_pxl",
> > +                              "clk_pxl_mux", "clk_pxl_link", "clk_apb",
> > +                              "clk_vif";
> > +
> > +             port {
> > +                     dp1_output: endpoint {
> > +                             remote-endpoint = <&dp0_input>;
> > +                     };
> > +             };
> > +        };
> > +
> > +        ...
> > +};
> > --
> > 2.17.1
> >

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [EXT] Re: [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY.
  2019-06-17  1:45   ` [EXT] " Wen He
@ 2019-06-19 14:07     ` Rob Herring
  2019-06-20  3:35       ` Wen He
  0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2019-06-19 14:07 UTC (permalink / raw)
  To: Wen He; +Cc: linux-kernel, linux-arm-kernel, devicetree, shawnguo, Leo Li

On Sun, Jun 16, 2019 at 7:45 PM Wen He <wen.he_1@nxp.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: 2019年6月14日 4:08
> > To: Wen He <wen.he_1@nxp.com>
> > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; shawnguo@kernel.org; Leo Li
> > <leoyang.li@nxp.com>
> > Subject: [EXT] Re: [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A
> > HDP-TX PHY.
> >
> > Caution: EXT Email
> >
> > On Wed, May 08, 2019 at 10:35:25AM +0000, Wen He wrote:
> > > Add DT bindings documentmation for the HDP-TX PHY controller. The
> > > describes which could be found on NXP Layerscape ls1028a platform.
> >
> > Drop the hard stop (.) from the subject.
> >
> > >
> > > Signed-off-by: Wen He <wen.he_1@nxp.com>
> > > ---
> > >  .../devicetree/bindings/display/fsl,hdp.txt   | 56 +++++++++++++++++++
> > >  1 file changed, 56 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/display/fsl,hdp.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > > b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > > new file mode 100644
> > > index 000000000000..36b5687a1261
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > > @@ -0,0 +1,56 @@
> > > +NXP Layerscpae ls1028a HDP-TX PHY Controller
> > > +============================================
> > > +
> > > +The following bindings describe the Cadence HDP TX PHY on ls1028a
> > > +that offer multi-protocol support of standars such as eDP and
> > > +Displayport, supports for 25-600MHz pixel clock and up to 4k2k at 60MHz
> > resolution.
> > > +The HDP transmitter is a Cadence HDP TX controller IP with a
> > > +companion PHY IP.
> >
> > I'm confused. This binding covers both blocks or is just one of them?
> >
>
> Hi Rob,
>
> This binding covers both blocks(HDP TX PHY and HDP TX Controller),
> Because they are belong to the one IP.

In that case, you should also have an output port to a DP connector
node (or DP panel).

Rob

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [EXT] Re: [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY.
  2019-06-19 14:07     ` Rob Herring
@ 2019-06-20  3:35       ` Wen He
  0 siblings, 0 replies; 8+ messages in thread
From: Wen He @ 2019-06-20  3:35 UTC (permalink / raw)
  To: Rob Herring; +Cc: linux-kernel, linux-arm-kernel, devicetree, shawnguo, Leo Li



> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2019年6月19日 22:07
> To: Wen He <wen.he_1@nxp.com>
> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; shawnguo@kernel.org; Leo Li
> <leoyang.li@nxp.com>
> Subject: Re: [EXT] Re: [v1 1/4] dt-bindings: display: Add DT bindings for
> LS1028A HDP-TX PHY.
> 
> Caution: EXT Email
> 
> On Sun, Jun 16, 2019 at 7:45 PM Wen He <wen.he_1@nxp.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@kernel.org>
> > > Sent: 2019年6月14日 4:08
> > > To: Wen He <wen.he_1@nxp.com>
> > > Cc: linux-kernel@vger.kernel.org;
> > > linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org; shawnguo@kernel.org; Leo Li
> > > <leoyang.li@nxp.com>
> > > Subject: [EXT] Re: [v1 1/4] dt-bindings: display: Add DT bindings
> > > for LS1028A HDP-TX PHY.
> > >
> > > Caution: EXT Email
> > >
> > > On Wed, May 08, 2019 at 10:35:25AM +0000, Wen He wrote:
> > > > Add DT bindings documentmation for the HDP-TX PHY controller. The
> > > > describes which could be found on NXP Layerscape ls1028a platform.
> > >
> > > Drop the hard stop (.) from the subject.
> > >
> > > >
> > > > Signed-off-by: Wen He <wen.he_1@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/display/fsl,hdp.txt   | 56
> +++++++++++++++++++
> > > >  1 file changed, 56 insertions(+)
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/display/fsl,hdp.txt
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > > > b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > > > new file mode 100644
> > > > index 000000000000..36b5687a1261
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/display/fsl,hdp.txt
> > > > @@ -0,0 +1,56 @@
> > > > +NXP Layerscpae ls1028a HDP-TX PHY Controller
> > > > +============================================
> > > > +
> > > > +The following bindings describe the Cadence HDP TX PHY on ls1028a
> > > > +that offer multi-protocol support of standars such as eDP and
> > > > +Displayport, supports for 25-600MHz pixel clock and up to 4k2k at
> > > > +60MHz
> > > resolution.
> > > > +The HDP transmitter is a Cadence HDP TX controller IP with a
> > > > +companion PHY IP.
> > >
> > > I'm confused. This binding covers both blocks or is just one of them?
> > >
> >
> > Hi Rob,
> >
> > This binding covers both blocks(HDP TX PHY and HDP TX Controller),
> > Because they are belong to the one IP.
> 
> In that case, you should also have an output port to a DP connector node (or
> DP panel).

Hi Rob,

I remember there are included the DP connector node description as see below.

---
Required sub-nodes:
- port

It there should be right?

Best Regards,
Wen

> 
> Rob

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-06-20  3:35 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08 10:35 [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Wen He
2019-05-08 10:35 ` [v1 2/4] arm64: dts: ls1028a: Add properties for HDP Controller Wen He
2019-05-08 10:35 ` [v1 3/4] arm64: ls1028aqds: Add support DP nodes for LS1028AQDS Wen He
2019-05-08 10:35 ` [v1 4/4] arm64: ls1028ardb: Add support DP nodes for LS1028ARDB Wen He
2019-06-13 20:08 ` [v1 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY Rob Herring
2019-06-17  1:45   ` [EXT] " Wen He
2019-06-19 14:07     ` Rob Herring
2019-06-20  3:35       ` Wen He

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).