From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78654C04AB1 for ; Thu, 9 May 2019 20:19:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 497032177B for ; Thu, 9 May 2019 20:19:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="IO+KoQF0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbfEIUT2 (ORCPT ); Thu, 9 May 2019 16:19:28 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39791 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726806AbfEIUT1 (ORCPT ); Thu, 9 May 2019 16:19:27 -0400 Received: by mail-wm1-f68.google.com with SMTP id n25so4674513wmk.4 for ; Thu, 09 May 2019 13:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GJZ5Q6jA4O7aJU9I1R7Mdcv4Tb9to2ZldjQmNYgzvPA=; b=IO+KoQF0XExQgYMUQurYWk908PrOrvDWgPkKvUFydb54+mGRvonFr1iT+FubWy3OBA QpyEdwU8/OJ4+G9+lxN1J9UzAAXIDbt6s41pTK12AlT2em+Ibb/YaLYfaKzygpMPJPJC P3ICeH3z4JYLoMXM7xdSW1PhUn+yUn4epbKK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GJZ5Q6jA4O7aJU9I1R7Mdcv4Tb9to2ZldjQmNYgzvPA=; b=bxW7l/JkVMFkxiouRy3Hf8MBUK/8Nf84y9LVyAJecCjo+6qoUZ/zQGajovgShyX2yq I5oUvEh5mlUpoFKBQEt/J1epAbJ/S4Kb6AllN54c9ga88kMxPJPN1KSJt98I4r+XjXFg BhDBaRpXSk1MUYH2h1HykgXQ0V1N+XPmaptgomhgEtUcHn68V3GMKibi+cT1q1cIS8u4 bdWi8RhaJ8oyZ9g55LGRkbhgfdeeJ844dmR105pUV0koQOBhTaG4Y35EZYPffosgnXJg 3neKVIbnGQUnVQWCCqdLgf+a2egd/XdVZ3o932yjQSMPAihB+nL4ZX/8nntnE9CQ7KeS FRzw== X-Gm-Message-State: APjAAAVhLdu12W1vRHR2VDEHJsL6lbLcG+EdZZx+Re+5cvryoXNqXPJz RdYVKZh0SFKEyeHFHuboqazwhYVzi56YmA== X-Google-Smtp-Source: APXvYqzxxHBFuaNUV6bBo6nlGo/Tnntlk9agUnyauDkHld2lgHrK9FItg2MrJoRjimGw6vVaZIhwAg== X-Received: by 2002:a1c:cb48:: with SMTP id b69mr4393573wmg.109.1557433165640; Thu, 09 May 2019 13:19:25 -0700 (PDT) Received: from andrea ([91.252.228.170]) by smtp.gmail.com with ESMTPSA id z74sm9649240wmc.2.2019.05.09.13.19.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 13:19:24 -0700 (PDT) Date: Thu, 9 May 2019 22:19:15 +0200 From: Andrea Parri To: linux-kernel@vger.kernel.org Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, "Paul E. McKenney" , Peter Zijlstra Subject: Re: [PATCH 1/5] drm/msm: Fix improper uses of smp_mb__{before,after}_atomic() Message-ID: <20190509201915.GA2931@andrea> References: <1556568902-12464-1-git-send-email-andrea.parri@amarulasolutions.com> <1556568902-12464-2-git-send-email-andrea.parri@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556568902-12464-2-git-send-email-andrea.parri@amarulasolutions.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 29, 2019 at 10:14:57PM +0200, Andrea Parri wrote: > These barriers only apply to the read-modify-write operations; in > particular, they do not apply to the atomic_set() primitive. > > Replace the barriers with smp_mb()s. > > Fixes: b1fc2839d2f92 ("drm/msm: Implement preemption for A5XX targets") > Cc: stable@vger.kernel.org > Reported-by: "Paul E. McKenney" > Reported-by: Peter Zijlstra > Signed-off-by: Andrea Parri > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jordan Crouse > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org Rob, Sean, Jordan: any suggestions to move this patch forward? Thanx, Andrea > --- > drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_preempt.c b/drivers/gpu/drm/msm/adreno/a5xx_preempt.c > index 3d62310a535fb..ee0820ee0c664 100644 > --- a/drivers/gpu/drm/msm/adreno/a5xx_preempt.c > +++ b/drivers/gpu/drm/msm/adreno/a5xx_preempt.c > @@ -39,10 +39,10 @@ static inline void set_preempt_state(struct a5xx_gpu *gpu, > * preemption or in the interrupt handler so barriers are needed > * before... > */ > - smp_mb__before_atomic(); > + smp_mb(); > atomic_set(&gpu->preempt_state, new); > /* ... and after*/ > - smp_mb__after_atomic(); > + smp_mb(); > } > > /* Write the most recent wptr for the given ring into the hardware */ > -- > 2.7.4 >