LKML Archive on
help / color / mirror / Atom feed
From: Christian Brauner <>
	Christian Brauner <>
Subject: [GIT PULL] pidfd fixes for v5.2-rc1
Date: Fri, 10 May 2019 14:54:47 +0200	[thread overview]
Message-ID: <> (raw)

Hi Linus,

The following changes since commit 8ea5b2abd07e2280a332bd9c1a7f4dd15b9b6c13:

  Merge branch 'fixes' of git:// (2019-05-09 19:35:41 -0700)

are available in the Git repository at: tags/pidfd-fixes-v5.2-rc1

for you to fetch changes up to c3b7112df86b769927a60a6d7175988ca3d60f09:

  fork: do not release lock that wasn't taken (2019-05-10 14:26:12 +0200)

I originally intended to send out a pr middle of next week to fix the bug you
reported but syzkaller found another bug that we should fix rather quickly.
Since no rc1 is out for 5.2 and the pidfd patchset had conflicts with Andrew's
tree and the kbuild tree I have simply based the pull request on current

/* Summary */
This pull request fixes two bugs.
The first one reported by Linus whereby the pidfd-metadata binary was not
placed in a .gitignore file.
The second one is rather urgent and fixes a locking issue found by syzkaller.
What happened is that during process creation we need to check whether the
cgroup we are in allows us to fork. To perform this check the cgroup needs to
guard itself against threadgroup changes and takes a lock. Prior to CLONE_PIDFD
the cleanup target "bad_fork_free_pid" would also need to release said lock.
That's not true anymore since CLONE_PIDFD so this is fixed here. Syzkaller has
tested the patch and was not able to reproduce the issue.

Please consider pulling these changes from the signed pidfd-fixes-v5.2-rc1 tag.

pidfd fixes for v5.2-rc1

Christian Brauner (2):
      samples: add .gitignore for pidfd-metadata
      fork: do not release lock that wasn't taken

 kernel/fork.c            | 5 +++--
 samples/pidfd/.gitignore | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)
 create mode 100644 samples/pidfd/.gitignore

             reply	other threads:[~2019-05-10 12:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 12:54 Christian Brauner [this message]
2019-05-10 17:35 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [GIT PULL] pidfd fixes for v5.2-rc1' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).