LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
	<tiwai@suse.com>, <pierre-louis.bossart@linux.intel.com>,
	<rdunlap@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH V2] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m
Date: Fri, 10 May 2019 21:29:40 +0800	[thread overview]
Message-ID: <20190510132940.28184-1-yuehaibing@huawei.com> (raw)
In-Reply-To: <20190510023657.8960-1-yuehaibing@huawei.com>

Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m

sound/soc/sof/core.o: In function `snd_sof_device_probe':
core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup'

Change IS_ENABLED to IS_REACHABLE to fix this.

Reported-by: Hulk Robot <hulkci@huawei.com>
Suggested-by: Takashi Iwai <tiwai@suse.de>
Fixes: c16211d6226d ("ASoC: SOF: Add Sound Open Firmware driver core")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
V2: use IS_REACHABLE
---
 sound/soc/sof/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c
index 32105e0..38e22f4 100644
--- a/sound/soc/sof/core.c
+++ b/sound/soc/sof/core.c
@@ -259,7 +259,7 @@ int snd_sof_create_page_table(struct snd_sof_dev *sdev,
 static int sof_machine_check(struct snd_sof_dev *sdev)
 {
 	struct snd_sof_pdata *plat_data = sdev->pdata;
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC)
+#if IS_REACHABLE(CONFIG_SND_SOC_SOF_NOCODEC)
 	struct snd_soc_acpi_mach *machine;
 	int ret;
 #endif
@@ -267,7 +267,7 @@ static int sof_machine_check(struct snd_sof_dev *sdev)
 	if (plat_data->machine)
 		return 0;
 
-#if !IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC)
+#if !IS_REACHABLE(CONFIG_SND_SOC_SOF_NOCODEC)
 	dev_err(sdev->dev, "error: no matching ASoC machine driver found - aborting probe\n");
 	return -ENODEV;
 #else
-- 
2.7.4



  parent reply	other threads:[~2019-05-10 13:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10  2:36 [PATCH] " YueHaibing
2019-05-10  7:12 ` Takashi Iwai
2019-05-10 12:56   ` Pierre-Louis Bossart
2019-05-10 13:04     ` Takashi Iwai
2019-05-10 13:34       ` [alsa-devel] " Pierre-Louis Bossart
2019-05-10 13:41         ` Takashi Iwai
2019-05-10 13:56           ` Takashi Iwai
2019-05-10 15:29             ` Pierre-Louis Bossart
2019-05-10 16:57               ` Takashi Iwai
2019-05-10 17:56                 ` Pierre-Louis Bossart
2019-05-10 18:05                   ` Takashi Iwai
2019-05-10 13:09   ` YueHaibing
2019-05-10 13:29 ` YueHaibing [this message]
2019-05-10 13:36   ` [PATCH V2] " Pierre-Louis Bossart
2019-05-10 13:50     ` YueHaibing
2019-05-10 16:24       ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510132940.28184-1-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rdunlap@infradead.org \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH V2] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).