LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicholas Mc Guire <der.herr@hofr.at>
To: David Miller <davem@davemloft.net>
Cc: hofrat@osadl.org, aneela@codeaurora.org,
	gregkh@linuxfoundation.org, anshuman.khandual@arm.com,
	david@redhat.com, arnd@arndb.de, johannes.berg@intel.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: qrtr: use protocol endiannes variable
Date: Sat, 11 May 2019 02:17:39 +0200	[thread overview]
Message-ID: <20190511001739.GA6185@osadl.at> (raw)
In-Reply-To: <20190510.132800.1971158293891484440.davem@davemloft.net>

On Fri, May 10, 2019 at 01:28:00PM -0700, David Miller wrote:
> From: Nicholas Mc Guire <hofrat@osadl.org>
> Date: Fri, 10 May 2019 03:08:53 +0200
> 
> > diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> > index dd0e97f..c90edaa 100644
> > --- a/net/qrtr/qrtr.c
> > +++ b/net/qrtr/qrtr.c
> > @@ -733,7 +733,8 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
> >  	struct qrtr_node *node;
> >  	struct sk_buff *skb;
> >  	size_t plen;
> > -	u32 type = QRTR_TYPE_DATA;
> > +	u32 type = 0;
> > +	__le32 qrtr_type = cpu_to_le32(QRTR_TYPE_DATA);
> >  	int rc;
> 
> Please try to preserve as much of the reverse chrimstas tree here rather
> than making it worse.
>
sorry - did not really think about that at all  - will re-order the declarations and resend

thx!
hofrat 

      reply	other threads:[~2019-05-11  0:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10  1:08 Nicholas Mc Guire
2019-05-10 20:28 ` David Miller
2019-05-11  0:17   ` Nicholas Mc Guire [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190511001739.GA6185@osadl.at \
    --to=der.herr@hofr.at \
    --cc=aneela@codeaurora.org \
    --cc=anshuman.khandual@arm.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=david@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hofrat@osadl.org \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH] net: qrtr: use protocol endiannes variable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).