From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2CAC04A6B for ; Sat, 11 May 2019 00:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C05AD217D7 for ; Sat, 11 May 2019 00:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbfEKASg (ORCPT ); Fri, 10 May 2019 20:18:36 -0400 Received: from 178.115.242.59.static.drei.at ([178.115.242.59]:46646 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbfEKASg (ORCPT ); Fri, 10 May 2019 20:18:36 -0400 Received: by mail.osadl.at (Postfix, from userid 1001) id A17EE5C05AC; Sat, 11 May 2019 02:17:39 +0200 (CEST) Date: Sat, 11 May 2019 02:17:39 +0200 From: Nicholas Mc Guire To: David Miller Cc: hofrat@osadl.org, aneela@codeaurora.org, gregkh@linuxfoundation.org, anshuman.khandual@arm.com, david@redhat.com, arnd@arndb.de, johannes.berg@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: qrtr: use protocol endiannes variable Message-ID: <20190511001739.GA6185@osadl.at> References: <1557450533-9321-1-git-send-email-hofrat@osadl.org> <20190510.132800.1971158293891484440.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190510.132800.1971158293891484440.davem@davemloft.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 01:28:00PM -0700, David Miller wrote: > From: Nicholas Mc Guire > Date: Fri, 10 May 2019 03:08:53 +0200 > > > diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c > > index dd0e97f..c90edaa 100644 > > --- a/net/qrtr/qrtr.c > > +++ b/net/qrtr/qrtr.c > > @@ -733,7 +733,8 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) > > struct qrtr_node *node; > > struct sk_buff *skb; > > size_t plen; > > - u32 type = QRTR_TYPE_DATA; > > + u32 type = 0; > > + __le32 qrtr_type = cpu_to_le32(QRTR_TYPE_DATA); > > int rc; > > Please try to preserve as much of the reverse chrimstas tree here rather > than making it worse. > sorry - did not really think about that at all - will re-order the declarations and resend thx! hofrat