LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrea Parri <andrea.parri@amarulasolutions.com>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Joel Fernandes <joel@joelfernandes.org>,
	linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
	Josh Triplett <josh@joshtriplett.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] doc/rcu: Correct field_count field naming in examples
Date: Sun, 12 May 2019 03:09:41 +0200	[thread overview]
Message-ID: <20190512010941.GA8611@andrea> (raw)
In-Reply-To: <20190512004131.GE3923@linux.ibm.com>

On Sat, May 11, 2019 at 05:41:31PM -0700, Paul E. McKenney wrote:
> On Sun, May 12, 2019 at 12:11:26AM +0200, Andrea Parri wrote:
> > Hi Paul, Joel,
> > 
> > > > > On the other hand, would you have ideas for more modern replacement
> > > > > examples?
> > > > 
> > > > There are 3 cases I can see in listRCU.txt:
> > > >   (1) action taken outside of read_lock (can tolerate stale data), no in-place update.
> > > >                 this is the best possible usage of RCU.
> > > >   (2) action taken outside of read_lock, in-place updates
> > > >                 this is good as long as not too many in-place updates.
> > > >                 involves copying creating new list node and replacing the
> > > >                 node being updated with it.
> > > >   (3) cannot tolerate stale data: here a deleted or obsolete flag can be used
> > > >                                   protected by a per-entry lock. reader
> > > > 				  aborts if object is stale.
> > > > 
> > > > Any replacement example must make satisfy (3) too?
> > > 
> > > It would be OK to have a separate example for (3).  It would of course
> > > be nicer to have one example for all three, but not all -that- important.
> > > 
> > > > The only example for (3) that I know of is sysvipc sempahores which you also
> > > > mentioned in the paper. Looking through this code, it hasn't changed
> > > > conceptually and it could be a fit for an example (ipc_valid_object() checks
> > > > for whether the object is stale).
> > > 
> > > That is indeed the classic canonical example.  ;-)
> > > 
> > > > The other example could be dentry look up which uses seqlocks for the
> > > > RCU-walk case? But that could be too complex. This is also something I first
> > > > learnt from the paper and then the excellent path-lookup.rst document in
> > > > kernel sources.
> > > 
> > > This is a great example, but it would need serious simplification for
> > > use in the Documentation/RCU directory.  Note that dcache uses it to
> > > gain very limited and targeted consistency -- only a few types of updates
> > > acquire the write-side of that seqlock.
> > > 
> > > Might be quite worthwhile to have a simplified example, though!
> > > Perhaps a trivial hash table where write-side sequence lock is acquired
> > > only when moving an element from one chain to another?
> > 
> > Sorry to take you down here..., but what do you mean by "the paper"?  ;-/
> 
> One or both of these two:
> 
> http://www2.rdrop.com/~paulmck/techreports/survey.2012.09.17a.pdf
> http://www2.rdrop.com/~paulmck/techreports/RCUUsage.2013.02.24a.pdf

Oh, these are familiar.  ;-) Thank you!

  Andrea

  reply	other threads:[~2019-05-12  1:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05  2:03 [PATCH] doc/rcu: Correct field_count field naming in examples Joel Fernandes (Google)
2019-05-07  0:04 ` Paul E. McKenney
2019-05-08 16:26   ` Joel Fernandes
2019-05-08 18:16     ` Paul E. McKenney
2019-05-11 22:11       ` Andrea Parri
2019-05-12  0:41         ` Paul E. McKenney
2019-05-12  1:09           ` Andrea Parri [this message]
2019-05-13  3:43       ` Joel Fernandes
2019-05-14 22:13         ` Paul E. McKenney
2019-05-25 10:07       ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190512010941.GA8611@andrea \
    --to=andrea.parri@amarulasolutions.com \
    --cc=corbet@lwn.net \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.ibm.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).