LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] s390: move arch/s390/defconfig to arch/s390/configs/defconfig
@ 2019-05-13  2:11 Masahiro Yamada
  2019-05-13 17:20 ` Paul Walmsley
  2019-05-15  8:45 ` Martin Schwidefsky
  0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2019-05-13  2:11 UTC (permalink / raw)
  To: Martin Schwidefsky, Heiko Carstens, linux-s390
  Cc: Masahiro Yamada, Greentime Hu, linux-kernel, Guo Ren,
	Vincent Chen, Palmer Dabbelt, linux-riscv, Albert Ou

As of Linux 5.1, alpha and s390 are the last architectures that
have defconfig in arch/*/ instead of arch/*/configs/.

  $ find arch -name defconfig | sort
  arch/alpha/defconfig
  arch/arm64/configs/defconfig
  arch/csky/configs/defconfig
  arch/nds32/configs/defconfig
  arch/riscv/configs/defconfig
  arch/s390/defconfig

The arch/$(ARCH)/defconfig is the hard-coded default in Kconfig,
and I want to deprecate it after evacuating the remaining defconfig
into the standard location, arch/*/configs/.

Define KBUILD_DEFCONFIG like other architectures, and move defconfig
into the configs/ subdirectory.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/s390/Makefile                | 2 ++
 arch/s390/{ => configs}/defconfig | 0
 2 files changed, 2 insertions(+)
 rename arch/s390/{ => configs}/defconfig (100%)

diff --git a/arch/s390/Makefile b/arch/s390/Makefile
index df1d6a150f30..de8521fc9de5 100644
--- a/arch/s390/Makefile
+++ b/arch/s390/Makefile
@@ -10,6 +10,8 @@
 # Copyright (C) 1994 by Linus Torvalds
 #
 
+KBUILD_DEFCONFIG := defconfig
+
 LD_BFD		:= elf64-s390
 KBUILD_LDFLAGS	:= -m elf64_s390
 KBUILD_AFLAGS_MODULE += -fPIC
diff --git a/arch/s390/defconfig b/arch/s390/configs/defconfig
similarity index 100%
rename from arch/s390/defconfig
rename to arch/s390/configs/defconfig
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] s390: move arch/s390/defconfig to arch/s390/configs/defconfig
  2019-05-13  2:11 [PATCH] s390: move arch/s390/defconfig to arch/s390/configs/defconfig Masahiro Yamada
@ 2019-05-13 17:20 ` Paul Walmsley
  2019-05-15  8:45 ` Martin Schwidefsky
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2019-05-13 17:20 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Martin Schwidefsky, Heiko Carstens, linux-s390, Albert Ou,
	Palmer Dabbelt, linux-kernel, Guo Ren, Greentime Hu, linux-riscv,
	Vincent Chen

On Mon, 13 May 2019, Masahiro Yamada wrote:

> As of Linux 5.1, alpha and s390 are the last architectures that
> have defconfig in arch/*/ instead of arch/*/configs/.
> 
>   $ find arch -name defconfig | sort
>   arch/alpha/defconfig
>   arch/arm64/configs/defconfig
>   arch/csky/configs/defconfig
>   arch/nds32/configs/defconfig
>   arch/riscv/configs/defconfig
>   arch/s390/defconfig
> 
> The arch/$(ARCH)/defconfig is the hard-coded default in Kconfig,
> and I want to deprecate it after evacuating the remaining defconfig
> into the standard location, arch/*/configs/.
> 
> Define KBUILD_DEFCONFIG like other architectures, and move defconfig
> into the configs/ subdirectory.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Reviewed-by: Paul Walmsley <paul@pwsan.com>

- Paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] s390: move arch/s390/defconfig to arch/s390/configs/defconfig
  2019-05-13  2:11 [PATCH] s390: move arch/s390/defconfig to arch/s390/configs/defconfig Masahiro Yamada
  2019-05-13 17:20 ` Paul Walmsley
@ 2019-05-15  8:45 ` Martin Schwidefsky
  1 sibling, 0 replies; 3+ messages in thread
From: Martin Schwidefsky @ 2019-05-15  8:45 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Heiko Carstens, linux-s390, Greentime Hu, linux-kernel, Guo Ren,
	Vincent Chen, Palmer Dabbelt, linux-riscv, Albert Ou

On Mon, 13 May 2019 11:11:16 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> As of Linux 5.1, alpha and s390 are the last architectures that
> have defconfig in arch/*/ instead of arch/*/configs/.
> 
>   $ find arch -name defconfig | sort
>   arch/alpha/defconfig
>   arch/arm64/configs/defconfig
>   arch/csky/configs/defconfig
>   arch/nds32/configs/defconfig
>   arch/riscv/configs/defconfig
>   arch/s390/defconfig
> 
> The arch/$(ARCH)/defconfig is the hard-coded default in Kconfig,
> and I want to deprecate it after evacuating the remaining defconfig
> into the standard location, arch/*/configs/.
> 
> Define KBUILD_DEFCONFIG like other architectures, and move defconfig
> into the configs/ subdirectory.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

I have added this patch to my linux/s390 tree and will push it upstream
soon. Thanks!

> ---
> 
>  arch/s390/Makefile                | 2 ++
>  arch/s390/{ => configs}/defconfig | 0
>  2 files changed, 2 insertions(+)
>  rename arch/s390/{ => configs}/defconfig (100%)
> 
> diff --git a/arch/s390/Makefile b/arch/s390/Makefile
> index df1d6a150f30..de8521fc9de5 100644
> --- a/arch/s390/Makefile
> +++ b/arch/s390/Makefile
> @@ -10,6 +10,8 @@
>  # Copyright (C) 1994 by Linus Torvalds
>  #
> 
> +KBUILD_DEFCONFIG := defconfig
> +
>  LD_BFD		:= elf64-s390
>  KBUILD_LDFLAGS	:= -m elf64_s390
>  KBUILD_AFLAGS_MODULE += -fPIC
> diff --git a/arch/s390/defconfig b/arch/s390/configs/defconfig
> similarity index 100%
> rename from arch/s390/defconfig
> rename to arch/s390/configs/defconfig


-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-15  8:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13  2:11 [PATCH] s390: move arch/s390/defconfig to arch/s390/configs/defconfig Masahiro Yamada
2019-05-13 17:20 ` Paul Walmsley
2019-05-15  8:45 ` Martin Schwidefsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).