LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH RESEND] mfd: rk808: Fix RK818 ID template
@ 2019-05-13  8:29 Heiko Stuebner
  2019-06-03  8:00 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Heiko Stuebner @ 2019-05-13  8:29 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, Daniel Schultz, stable, Elaine Zhang, Joseph Chen,
	Heiko Stuebner

From: Daniel Schultz <d.schultz@phytec.de>

The Rockchip PMIC driver can automatically detect connected component
versions by reading the ID_MSB and ID_LSB registers. The probe function
will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
RK818 template ID is 0x8181.

This patch changes this value to 0x8180.

Fixes: 9d6105e19f61 ("mfd: rk808: Fix up the chip id get failed")
Cc: stable@vger.kernel.org
Cc: Elaine Zhang <zhangqing@rock-chips.com>
Cc: Joseph Chen <chenjh@rock-chips.com>
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
Acked-by: Lee Jones <lee.jones@linaro.org>
[added Fixes and cc-stable]
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
The original patch from Feburary 2018 got an Ack but never reached
the mfd-tree, so I ran into that problem this weekend as well.
So it would be really cool if this could be applied as fix :-) .

 include/linux/mfd/rk808.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
index d3156594674c..338e0f6e2226 100644
--- a/include/linux/mfd/rk808.h
+++ b/include/linux/mfd/rk808.h
@@ -443,7 +443,7 @@ enum {
 enum {
 	RK805_ID = 0x8050,
 	RK808_ID = 0x0000,
-	RK818_ID = 0x8181,
+	RK818_ID = 0x8180,
 };
 
 struct rk808 {
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] mfd: rk808: Fix RK818 ID template
  2019-05-13  8:29 [PATCH RESEND] mfd: rk808: Fix RK818 ID template Heiko Stuebner
@ 2019-06-03  8:00 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2019-06-03  8:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: linux-kernel, Daniel Schultz, stable, Elaine Zhang, Joseph Chen

On Mon, 13 May 2019, Heiko Stuebner wrote:

> From: Daniel Schultz <d.schultz@phytec.de>
> 
> The Rockchip PMIC driver can automatically detect connected component
> versions by reading the ID_MSB and ID_LSB registers. The probe function
> will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
> RK818 template ID is 0x8181.
> 
> This patch changes this value to 0x8180.
> 
> Fixes: 9d6105e19f61 ("mfd: rk808: Fix up the chip id get failed")
> Cc: stable@vger.kernel.org
> Cc: Elaine Zhang <zhangqing@rock-chips.com>
> Cc: Joseph Chen <chenjh@rock-chips.com>
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> [added Fixes and cc-stable]
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> The original patch from Feburary 2018 got an Ack but never reached
> the mfd-tree, so I ran into that problem this weekend as well.
> So it would be really cool if this could be applied as fix :-) .
> 
>  include/linux/mfd/rk808.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-03  8:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13  8:29 [PATCH RESEND] mfd: rk808: Fix RK818 ID template Heiko Stuebner
2019-06-03  8:00 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).