LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de> To: Akinobu Mita <akinobu.mita@gmail.com> Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Johannes Berg <johannes@sipsolutions.net>, Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>, Minwoo Im <minwoo.im.dev@gmail.com>, Kenneth Heitke <kenneth.heitke@intel.com> Subject: Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure Date: Mon, 13 May 2019 16:02:46 +0200 [thread overview] Message-ID: <20190513140246.GB24840@lst.de> (raw) In-Reply-To: <1557676457-4195-6-git-send-email-akinobu.mita@gmail.com> Usage of a scatterlist here is rather bogus as we never use it for dma mapping. Why can't you store the various pages in a large bio_vec and then just issue that to the device in one get log page command? (or at least a few if MDTS kicks in?)
next prev parent reply other threads:[~2019-05-13 14:03 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-12 15:54 [PATCH v3 0/7] nvme-pci: support device coredump Akinobu Mita 2019-05-12 15:54 ` [PATCH v3 1/7] devcoredump: use memory_read_from_buffer Akinobu Mita 2019-05-13 15:28 ` Chaitanya Kulkarni 2019-05-12 15:54 ` [PATCH v3 2/7] devcoredump: fix typo in comment Akinobu Mita 2019-05-13 15:24 ` Chaitanya Kulkarni 2019-05-12 15:54 ` [PATCH v3 3/7] devcoredump: allow to create several coredump files in one device Akinobu Mita 2019-05-12 15:54 ` [PATCH v3 4/7] nvme: add basic facility to get telemetry log page Akinobu Mita 2019-05-13 15:34 ` Chaitanya Kulkarni 2019-05-14 14:04 ` Akinobu Mita 2019-05-12 15:54 ` [PATCH v3 5/7] nvme-pci: add device coredump infrastructure Akinobu Mita 2019-05-13 13:50 ` Keith Busch 2019-05-13 15:01 ` Akinobu Mita 2019-05-13 14:02 ` Christoph Hellwig [this message] 2019-05-13 15:01 ` Akinobu Mita 2019-05-12 15:54 ` [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout Akinobu Mita 2019-05-13 13:52 ` Keith Busch 2019-05-12 15:54 ` [PATCH v3 7/7] nvme-pci: enable to trigger device coredump by hand Akinobu Mita [not found] ` <CGME20190512155533epcas4p110edff15ebf5b2efae32e43f0f10ab59@epcms2p5> 2019-05-13 7:41 ` [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout Minwoo Im 2019-05-13 14:59 ` Akinobu Mita [not found] ` <CGME20190512155540epcas4p14c15eb86b08dcd281e9a93a4fc190800@epcms2p1> 2019-05-13 7:46 ` [PATCH v3 5/7] nvme-pci: add device coredump infrastructure Minwoo Im 2019-05-13 15:23 ` Chaitanya Kulkarni 2019-05-14 14:06 ` Akinobu Mita
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190513140246.GB24840@lst.de \ --to=hch@lst.de \ --cc=akinobu.mita@gmail.com \ --cc=axboe@fb.com \ --cc=johannes@sipsolutions.net \ --cc=keith.busch@intel.com \ --cc=kenneth.heitke@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=minwoo.im.dev@gmail.com \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).