From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36621C04E84 for ; Wed, 15 May 2019 16:43:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F27CE20873 for ; Wed, 15 May 2019 16:43:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sRb5I1/0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727377AbfEOQnG (ORCPT ); Wed, 15 May 2019 12:43:06 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39542 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbfEOQnE (ORCPT ); Wed, 15 May 2019 12:43:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LFWmpV8Lm1fyxQJMm8Z7yO88zEmKawJucYqlb2bUzLQ=; b=sRb5I1/01FFguKFh/14b7u3pn XWfGsZjlNhtVArXeFiwSiq2EX+GX5EoldwhEdBYKRPL+7S4fEEq31Qrhvh8zdL6cUdRXY0bUEIgBj 6hmCt77YddaRvV+JDgkDHnYpmE/TfZOBHaMCFHmp/nv7ZWz1wQ3Vl+Nf2NiGCOqM99+zthij8fufg qBBezfWuPdOIAv2rrLRvouYZlMDArybxG/dl6skBG4oFQ0C7W6+B08qi2tKA/dZhMqJ4L6B0N+8BD UNtIDqs4MuFXbeuGCeriB7gOyPV75E2VQti5Q5xtX9ggq+dneyZpsnHdAUesEvKnmRkpB3B9WWqeF xrctqRKdQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQwzd-0007ik-Sr; Wed, 15 May 2019 16:43:02 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5FD0D2029906B; Wed, 15 May 2019 18:43:00 +0200 (CEST) Date: Wed, 15 May 2019 18:43:00 +0200 From: Peter Zijlstra To: Parth Shah Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, mingo@redhat.com, dietmar.eggemann@arm.com, dsmythies@telus.net Subject: Re: [RFCv2 5/6] sched/fair: Tune task wake-up logic to pack jitter tasks Message-ID: <20190515164300.GX2589@hirez.programming.kicks-ass.net> References: <20190515135322.19393-1-parth@linux.ibm.com> <20190515135322.19393-6-parth@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515135322.19393-6-parth@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 07:23:21PM +0530, Parth Shah wrote: > @@ -6704,6 +6773,31 @@ static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu) > return -1; > } > > +#ifdef CONFIG_SCHED_SMT > +/* > + * Select all tasks of type 1(jitter) for task packing > + */ > +static int turbosched_select_idle_sibling(struct task_struct *p, int prev_cpu, > + int target) > +{ > + int new_cpu; > + > + if (unlikely(task_group(p)->turbo_sched_enabled)) { So if you build without cgroups, this is a NULL dereference. Also, this really should not be group based. > + new_cpu = select_non_idle_core(p, prev_cpu); > + if (new_cpu >= 0) > + return new_cpu; > + } > + > + return select_idle_sibling(p, prev_cpu, target); > +} > +#else