LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org, Steven Price <steven.price@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will.deacon@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: Bad virt_to_phys since commit 54c7a8916a887f35
Date: Thu, 16 May 2019 16:23:27 +0200	[thread overview]
Message-ID: <20190516142327.GA23471@lst.de> (raw)
In-Reply-To: <20190516142119.GD43059@lakrids.cambridge.arm.com>

On Thu, May 16, 2019 at 03:21:19PM +0100, Mark Rutland wrote:
> >  void __weak free_initrd_mem(unsigned long start, unsigned long end)
> >  {
> > +       if (!start)
> > +               return;
> > +
> >         free_reserved_area((void *)start, (void *)end, POISON_FREE_INITMEM,
> >                         "initrd");
> >  }
> 
> I think this should work, given Steven's patch checks the same thing.
> 
> I don't have a preference as to which patch should be taken, so I'll
> leave that to Christoph.

We still have plenty of architectures not using the generic
free_initrd_mem, so checking it in the caller gives us better
coverage.

      reply	other threads:[~2019-05-16 14:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 13:38 Mark Rutland
2019-05-16 13:41 ` Mark Rutland
2019-05-16 14:05   ` Steven Price
2019-05-16 14:16     ` Mark Rutland
2019-05-16 14:20       ` Steven Price
2019-05-16 14:27         ` Mark Rutland
2019-05-23  9:31         ` Will Deacon
2019-05-23  9:54           ` Mike Rapoport
2019-05-23  9:58             ` Steven Price
2019-05-23 10:01               ` Will Deacon
2019-05-16 14:13   ` Mike Rapoport
2019-05-16 14:21     ` Mark Rutland
2019-05-16 14:23       ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516142327.GA23471@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rppt@linux.ibm.com \
    --cc=steven.price@arm.com \
    --cc=will.deacon@arm.com \
    --subject='Re: Bad virt_to_phys since commit 54c7a8916a887f35' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).