LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Parav Pandit <parav@mellanox.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
cohuck@redhat.com, kwankhede@nvidia.com,
alex.williamson@redhat.com
Cc: cjia@nvidia.com, parav@mellanox.com
Subject: [PATCHv3 0/3] vfio/mdev: Improve vfio/mdev core module
Date: Thu, 16 May 2019 18:30:31 -0500 [thread overview]
Message-ID: <20190516233034.16407-1-parav@mellanox.com> (raw)
As we would like to use mdev subsystem for wider use case as
discussed in [1], [2] apart from an offline discussion.
This use case is also discussed with wider forum in [4] in track
'Lightweight NIC HW functions for container offload use cases'.
This series is prep-work and improves vfio/mdev module in following ways.
Patch-1 Improves the mdev create/remove sequence to match Linux
bus, device model
Patch-2 Avoid recreating remove file on stale device to eliminate
call trace
Patch-3 Fix race conditions of create/remove with parent removal.
This is improved version than using srcu as srcu can take seconds
to minutes.
This series is tested using
(a) mtty with VM using vfio_mdev driver for positive tests and device
removal while device in use by VM using vfio_mdev driver.
(b) mlx5 core driver using RFC patches [3] and internal patches.
Internal patches are large and cannot be combined with this prep-work
patches. It will posted once prep-work completes.
[1] https://www.spinics.net/lists/netdev/msg556978.html
[2] https://lkml.org/lkml/2019/3/7/696
[3] https://lkml.org/lkml/2019/3/8/819
[4] https://netdevconf.org/0x13/session.html?workshop-hardware-offload
---
Changelog:
---
v2->v3:
- Addressed comment from Cornelia
- Corrected several errors in commit log, updated commit log
- Dropped already merged 7 patches
v1->v2:
- Addressed comments from Alex
- Rebased
- Inserted the device checking loop in Patch-6 as original code
- Added patch 7 to 10
- Added fixes for race condition in create/remove with parent removal
Patch-10 uses simplified refcount and completion, instead of srcu
which might take seconds to minutes on busy system.
- Added fix for device create/remove sequence to match
Linux device, bus model
v0->v1:
- Dropped device placement on bus sequence patch for this series
- Addressed below comments from Alex, Kirti, Maxim.
- Added Review-by tag for already reviewed patches.
- Dropped incorrect patch of put_device().
- Corrected Fixes commit tag for sysfs remove sequence fix
- Split last 8th patch to smaller refactor and fixes patch
- Following coding style commenting format
- Fixed accidental delete of mutex_lock in mdev_unregister_device
- Renamed remove helped to mdev_device_remove_common().
- Rebased for uuid/guid change
Parav Pandit (3):
vfio/mdev: Improve the create/remove sequence
vfio/mdev: Avoid creating sysfs remove file on stale device removal
vfio/mdev: Synchronize device create/remove with parent removal
drivers/vfio/mdev/mdev_core.c | 150 ++++++++++++++-----------------
drivers/vfio/mdev/mdev_private.h | 8 +-
drivers/vfio/mdev/mdev_sysfs.c | 6 +-
3 files changed, 73 insertions(+), 91 deletions(-)
--
2.19.2
next reply other threads:[~2019-05-16 23:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 23:30 Parav Pandit [this message]
2019-05-16 23:30 ` [PATCHv3 1/3] vfio/mdev: Improve the create/remove sequence Parav Pandit
2019-05-20 19:54 ` Parav Pandit
2019-05-22 9:57 ` Cornelia Huck
2019-05-22 9:54 ` Cornelia Huck
2019-05-24 18:45 ` Parav Pandit
2019-05-16 23:30 ` [PATCHv3 2/3] vfio/mdev: Avoid creating sysfs remove file on stale device removal Parav Pandit
2019-05-22 9:55 ` Cornelia Huck
2019-05-16 23:30 ` [PATCHv3 3/3] vfio/mdev: Synchronize device create/remove with parent removal Parav Pandit
2019-05-17 11:22 ` Cornelia Huck
2019-05-17 14:18 ` Parav Pandit
2019-05-20 11:29 ` Cornelia Huck
2019-05-20 19:15 ` Parav Pandit
2019-05-20 22:12 ` Alex Williamson
2019-05-24 9:11 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516233034.16407-1-parav@mellanox.com \
--to=parav@mellanox.com \
--cc=alex.williamson@redhat.com \
--cc=cjia@nvidia.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCHv3 0/3] vfio/mdev: Improve vfio/mdev core module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).