LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] arm64: dts: ls1028a: fix watchdog device node
@ 2019-05-09 7:06 Chuanhua Han
2019-05-17 2:37 ` Shawn Guo
0 siblings, 1 reply; 11+ messages in thread
From: Chuanhua Han @ 2019-05-09 7:06 UTC (permalink / raw)
To: shawnguo, leoyang.li, mark.rutland
Cc: linux-arm-kernel, devicetree, linux-kernel, Chuanhua Han,
Zhang Ying-22455
ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as
timer clock, this patch fix device tree node.
Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
.../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index b04581249f0b..1510b1858246 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -285,13 +285,18 @@
#interrupt-cells = <2>;
};
- wdog0: watchdog@23c0000 {
- compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
- reg = <0x0 0x23c0000 0x0 0x10000>;
- interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clockgen 4 1>;
- big-endian;
- status = "disabled";
+ cluster1_core0_watchdog: wdt@c000000 {
+ compatible = "arm,sp805", "arm,primecell";
+ reg = <0x0 0xc000000 0x0 0x1000>;
+ clocks = <&clockgen 4 15>, <&clockgen 4 15>;
+ clock-names = "apb_pclk", "wdog_clk";
+ };
+
+ cluster1_core1_watchdog: wdt@c010000 {
+ compatible = "arm,sp805", "arm,primecell";
+ reg = <0x0 0xc010000 0x0 0x1000>;
+ clocks = <&clockgen 4 15>, <&clockgen 4 15>;
+ clock-names = "apb_pclk", "wdog_clk";
};
sata: sata@3200000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-09 7:06 [PATCH] arm64: dts: ls1028a: fix watchdog device node Chuanhua Han
@ 2019-05-17 2:37 ` Shawn Guo
2019-05-17 6:10 ` [EXT] " Chuanhua Han
0 siblings, 1 reply; 11+ messages in thread
From: Shawn Guo @ 2019-05-17 2:37 UTC (permalink / raw)
To: Chuanhua Han
Cc: leoyang.li, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Zhang Ying-22455
On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as
> timer clock, this patch fix device tree node.
>
> Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index b04581249f0b..1510b1858246 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -285,13 +285,18 @@
> #interrupt-cells = <2>;
> };
>
> - wdog0: watchdog@23c0000 {
> - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
> - reg = <0x0 0x23c0000 0x0 0x10000>;
> - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clockgen 4 1>;
> - big-endian;
> - status = "disabled";
> + cluster1_core0_watchdog: wdt@c000000 {
Keep 'watchdog' as the node name, and keep nodes sort in unit-address.
Shawn
> + compatible = "arm,sp805", "arm,primecell";
> + reg = <0x0 0xc000000 0x0 0x1000>;
> + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> + clock-names = "apb_pclk", "wdog_clk";
> + };
> +
> + cluster1_core1_watchdog: wdt@c010000 {
> + compatible = "arm,sp805", "arm,primecell";
> + reg = <0x0 0xc010000 0x0 0x1000>;
> + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> + clock-names = "apb_pclk", "wdog_clk";
> };
>
> sata: sata@3200000 {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-17 2:37 ` Shawn Guo
@ 2019-05-17 6:10 ` Chuanhua Han
2019-05-17 22:01 ` Leo Li
0 siblings, 1 reply; 11+ messages in thread
From: Chuanhua Han @ 2019-05-17 6:10 UTC (permalink / raw)
To: Shawn Guo
Cc: Leo Li, mark.rutland, linux-arm-kernel, devicetree, linux-kernel,
Ying Zhang
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2019年5月17日 10:38
> To: Chuanhua Han <chuanhua.han@nxp.com>
> Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
> Caution: EXT Email
>
> On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as
> > timer clock, this patch fix device tree node.
> >
> > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > ++++++++++++-------
> > 1 file changed, 12 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index b04581249f0b..1510b1858246 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -285,13 +285,18 @@
> > #interrupt-cells = <2>;
> > };
> >
> > - wdog0: watchdog@23c0000 {
> > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
> > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&clockgen 4 1>;
> > - big-endian;
> > - status = "disabled";
> > + cluster1_core0_watchdog: wdt@c000000 {
>
> Keep 'watchdog' as the node name,
Thanks for your replay
Do you mean replace the ‘wdt’ with ‘watchdog’?
and keep nodes sort in unit-address.
What does this mean?
>
> Shawn
>
> > + compatible = "arm,sp805", "arm,primecell";
> > + reg = <0x0 0xc000000 0x0 0x1000>;
> > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > + clock-names = "apb_pclk", "wdog_clk";
> > + };
> > +
> > + cluster1_core1_watchdog: wdt@c010000 {
> > + compatible = "arm,sp805", "arm,primecell";
> > + reg = <0x0 0xc010000 0x0 0x1000>;
> > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > + clock-names = "apb_pclk", "wdog_clk";
> > };
> >
> > sata: sata@3200000 {
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-17 6:10 ` [EXT] " Chuanhua Han
@ 2019-05-17 22:01 ` Leo Li
2019-05-21 13:00 ` Chuanhua Han
0 siblings, 1 reply; 11+ messages in thread
From: Leo Li @ 2019-05-17 22:01 UTC (permalink / raw)
To: Chuanhua Han, Shawn Guo
Cc: mark.rutland, linux-arm-kernel, devicetree, linux-kernel, Ying Zhang
> -----Original Message-----
> From: Chuanhua Han
> Sent: Friday, May 17, 2019 1:11 AM
> To: Shawn Guo <shawnguo@kernel.org>
> Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
>
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: 2019年5月17日 10:38
> > To: Chuanhua Han <chuanhua.han@nxp.com>
> > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device
> > node
> >
> > Caution: EXT Email
> >
> > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as
> > > timer clock, this patch fix device tree node.
> > >
> > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > ---
> > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > ++++++++++++-------
> > > 1 file changed, 12 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index b04581249f0b..1510b1858246 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -285,13 +285,18 @@
> > > #interrupt-cells = <2>;
> > > };
> > >
> > > - wdog0: watchdog@23c0000 {
> > > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
> > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> > > - clocks = <&clockgen 4 1>;
> > > - big-endian;
> > > - status = "disabled";
> > > + cluster1_core0_watchdog: wdt@c000000 {
> >
> > Keep 'watchdog' as the node name,
> Thanks for your replay
> Do you mean replace the ‘wdt’ with ‘watchdog’?
> and keep nodes sort in unit-address.
> What does this mean?
That means order the nodes by the addresses (e.g. c000000, c010000)
> >
> > Shawn
> >
> > > + compatible = "arm,sp805", "arm,primecell";
> > > + reg = <0x0 0xc000000 0x0 0x1000>;
> > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > + clock-names = "apb_pclk", "wdog_clk";
> > > + };
> > > +
> > > + cluster1_core1_watchdog: wdt@c010000 {
> > > + compatible = "arm,sp805", "arm,primecell";
> > > + reg = <0x0 0xc010000 0x0 0x1000>;
> > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > + clock-names = "apb_pclk", "wdog_clk";
> > > };
> > >
> > > sata: sata@3200000 {
> > > --
> > > 2.17.1
> > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-17 22:01 ` Leo Li
@ 2019-05-21 13:00 ` Chuanhua Han
2019-05-21 20:14 ` Leo Li
0 siblings, 1 reply; 11+ messages in thread
From: Chuanhua Han @ 2019-05-21 13:00 UTC (permalink / raw)
To: Leo Li, Shawn Guo
Cc: mark.rutland, linux-arm-kernel, devicetree, linux-kernel, Ying Zhang
> -----Original Message-----
> From: Leo Li
> Sent: 2019年5月18日 6:01
> To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> <shawnguo@kernel.org>
> Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
>
>
> > -----Original Message-----
> > From: Chuanhua Han
> > Sent: Friday, May 17, 2019 1:11 AM
> > To: Shawn Guo <shawnguo@kernel.org>
> > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm-
> > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > device node
> >
> >
> >
> > > -----Original Message-----
> > > From: Shawn Guo <shawnguo@kernel.org>
> > > Sent: 2019年5月17日 10:38
> > > To: Chuanhua Han <chuanhua.han@nxp.com>
> > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device
> > > node
> > >
> > > Caution: EXT Email
> > >
> > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock
> > > > as timer clock, this patch fix device tree node.
> > > >
> > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > > ---
> > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > > ++++++++++++-------
> > > > 1 file changed, 12 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > index b04581249f0b..1510b1858246 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > @@ -285,13 +285,18 @@
> > > > #interrupt-cells = <2>;
> > > > };
> > > >
> > > > - wdog0: watchdog@23c0000 {
> > > > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
> > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > - interrupts = <GIC_SPI 59
> IRQ_TYPE_LEVEL_HIGH>;
> > > > - clocks = <&clockgen 4 1>;
> > > > - big-endian;
> > > > - status = "disabled";
> > > > + cluster1_core0_watchdog: wdt@c000000 {
> > >
> > > Keep 'watchdog' as the node name,
> > Thanks for your replay
> > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > and keep nodes sort in unit-address.
> > What does this mean?
>
> That means order the nodes by the addresses (e.g. c000000, c010000)
The current order is correct（The first is c000000, then c000000）.
>
> > >
> > > Shawn
> > >
> > > > + compatible = "arm,sp805", "arm,primecell";
> > > > + reg = <0x0 0xc000000 0x0 0x1000>;
> > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > + };
> > > > +
> > > > + cluster1_core1_watchdog: wdt@c010000 {
> > > > + compatible = "arm,sp805", "arm,primecell";
> > > > + reg = <0x0 0xc010000 0x0 0x1000>;
> > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > };
> > > >
> > > > sata: sata@3200000 {
> > > > --
> > > > 2.17.1
> > > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-21 13:00 ` Chuanhua Han
@ 2019-05-21 20:14 ` Leo Li
2019-05-22 6:26 ` Chuanhua Han
0 siblings, 1 reply; 11+ messages in thread
From: Leo Li @ 2019-05-21 20:14 UTC (permalink / raw)
To: Chuanhua Han, Shawn Guo
Cc: mark.rutland, linux-arm-kernel, devicetree, linux-kernel, Ying Zhang
> -----Original Message-----
> From: Chuanhua Han
> Sent: Tuesday, May 21, 2019 8:00 AM
> To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
>
>
> > -----Original Message-----
> > From: Leo Li
> > Sent: 2019年5月18日 6:01
> > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > <shawnguo@kernel.org>
> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > <ying.zhang22455@nxp.com>
> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > device node
> >
> >
> >
> > > -----Original Message-----
> > > From: Chuanhua Han
> > > Sent: Friday, May 17, 2019 1:11 AM
> > > To: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm-
> > > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > device node
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Shawn Guo <shawnguo@kernel.org>
> > > > Sent: 2019年5月17日 10:38
> > > > To: Chuanhua Han <chuanhua.han@nxp.com>
> > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > device node
> > > >
> > > > Caution: EXT Email
> > > >
> > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform
> > > > > clock as timer clock, this patch fix device tree node.
> > > > >
> > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > ---
> > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > > > ++++++++++++-------
> > > > > 1 file changed, 12 insertions(+), 7 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > index b04581249f0b..1510b1858246 100644
> > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > @@ -285,13 +285,18 @@
> > > > > #interrupt-cells = <2>;
> > > > > };
> > > > >
> > > > > - wdog0: watchdog@23c0000 {
> > > > > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
> > > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > - interrupts = <GIC_SPI 59
> > IRQ_TYPE_LEVEL_HIGH>;
> > > > > - clocks = <&clockgen 4 1>;
> > > > > - big-endian;
> > > > > - status = "disabled";
> > > > > + cluster1_core0_watchdog: wdt@c000000 {
> > > >
> > > > Keep 'watchdog' as the node name,
> > > Thanks for your replay
> > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > and keep nodes sort in unit-address.
> > > What does this mean?
> >
> > That means order the nodes by the addresses (e.g. c000000, c010000)
> The current order is correct（The first is c000000, then c000000）.
But they are added after gpio@2320000 and before sata@3200000.
> >
> > > >
> > > > Shawn
> > > >
> > > > > + compatible = "arm,sp805", "arm,primecell";
> > > > > + reg = <0x0 0xc000000 0x0 0x1000>;
> > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > > + };
> > > > > +
> > > > > + cluster1_core1_watchdog: wdt@c010000 {
> > > > > + compatible = "arm,sp805", "arm,primecell";
> > > > > + reg = <0x0 0xc010000 0x0 0x1000>;
> > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > > };
> > > > >
> > > > > sata: sata@3200000 {
> > > > > --
> > > > > 2.17.1
> > > > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-21 20:14 ` Leo Li
@ 2019-05-22 6:26 ` Chuanhua Han
2019-05-22 6:50 ` Leo Li
0 siblings, 1 reply; 11+ messages in thread
From: Chuanhua Han @ 2019-05-22 6:26 UTC (permalink / raw)
To: Leo Li, Shawn Guo
Cc: mark.rutland, linux-arm-kernel, devicetree, linux-kernel, Ying Zhang
> -----Original Message-----
> From: Leo Li
> Sent: 2019年5月22日 4:15
> To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> <shawnguo@kernel.org>
> Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
>
>
> > -----Original Message-----
> > From: Chuanhua Han
> > Sent: Tuesday, May 21, 2019 8:00 AM
> > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > <ying.zhang22455@nxp.com>
> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > device node
> >
> >
> >
> > > -----Original Message-----
> > > From: Leo Li
> > > Sent: 2019年5月18日 6:01
> > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > > <shawnguo@kernel.org>
> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > > <ying.zhang22455@nxp.com>
> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > device node
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Chuanhua Han
> > > > Sent: Friday, May 17, 2019 1:11 AM
> > > > To: Shawn Guo <shawnguo@kernel.org>
> > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm-
> > > > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> > > > kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > device node
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Shawn Guo <shawnguo@kernel.org>
> > > > > Sent: 2019年5月17日 10:38
> > > > > To: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > > linux-arm-kernel@lists.infradead.org;
> > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying
> > > > > Zhang <ying.zhang22455@nxp.com>
> > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > > device node
> > > > >
> > > > > Caution: EXT Email
> > > > >
> > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform
> > > > > > clock as timer clock, this patch fix device tree node.
> > > > > >
> > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > > ---
> > > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > > > > ++++++++++++-------
> > > > > > 1 file changed, 12 insertions(+), 7 deletions(-)
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > index b04581249f0b..1510b1858246 100644
> > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > @@ -285,13 +285,18 @@
> > > > > > #interrupt-cells = <2>;
> > > > > > };
> > > > > >
> > > > > > - wdog0: watchdog@23c0000 {
> > > > > > - compatible = "fsl,ls1028a-wdt",
> "fsl,imx21-wdt";
> > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > > - interrupts = <GIC_SPI 59
> > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > - clocks = <&clockgen 4 1>;
> > > > > > - big-endian;
> > > > > > - status = "disabled";
> > > > > > + cluster1_core0_watchdog: wdt@c000000 {
> > > > >
> > > > > Keep 'watchdog' as the node name,
> > > > Thanks for your replay
> > > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > > and keep nodes sort in unit-address.
> > > > What does this mean?
> > >
> > > That means order the nodes by the addresses (e.g. c000000, c010000)
> > The current order is correct（The first is c000000, then c000000）.
>
> But they are added after gpio@2320000 and before sata@3200000.
I changed and made the second version of the patch, but I found the following error
when I executed ./scripts/checkpatch.pl xxx.patch to check the patch:
WARNING: DT compatible string vendor "arm" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt
#43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
+ compatible = "arm,sp805", "arm,primecell";
However, there is no vendor-prefixes.txt file in the ./Documentation/devicetree/bindings/ directory, only vendor-prefixes.yaml.
Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.
Request help，thanks
>
> > >
> > > > >
> > > > > Shawn
> > > > >
> > > > > > + compatible = "arm,sp805", "arm,primecell";
> > > > > > + reg = <0x0 0xc000000 0x0 0x1000>;
> > > > > > + clocks = <&clockgen 4 15>, <&clockgen 4
> 15>;
> > > > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > > > + };
> > > > > > +
> > > > > > + cluster1_core1_watchdog: wdt@c010000 {
> > > > > > + compatible = "arm,sp805", "arm,primecell";
> > > > > > + reg = <0x0 0xc010000 0x0 0x1000>;
> > > > > > + clocks = <&clockgen 4 15>, <&clockgen 4
> 15>;
> > > > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > > > };
> > > > > >
> > > > > > sata: sata@3200000 {
> > > > > > --
> > > > > > 2.17.1
> > > > > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-22 6:26 ` Chuanhua Han
@ 2019-05-22 6:50 ` Leo Li
2019-05-24 9:48 ` Chuanhua Han
0 siblings, 1 reply; 11+ messages in thread
From: Leo Li @ 2019-05-22 6:50 UTC (permalink / raw)
To: Chuanhua Han, Shawn Guo, Rob Herring
Cc: mark.rutland, linux-arm-kernel, devicetree, linux-kernel, Ying Zhang
> -----Original Message-----
> From: Chuanhua Han
> Sent: Wednesday, May 22, 2019 1:26 AM
> To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
>
>
> > -----Original Message-----
> > From: Leo Li
> > Sent: 2019年5月22日 4:15
> > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > <shawnguo@kernel.org>
> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > <ying.zhang22455@nxp.com>
> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > device node
> >
> >
> >
> > > -----Original Message-----
> > > From: Chuanhua Han
> > > Sent: Tuesday, May 21, 2019 8:00 AM
> > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > > <ying.zhang22455@nxp.com>
> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > device node
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Leo Li
> > > > Sent: 2019年5月18日 6:01
> > > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > > > <shawnguo@kernel.org>
> > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying
> > > > Zhang <ying.zhang22455@nxp.com>
> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > device node
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Chuanhua Han
> > > > > Sent: Friday, May 17, 2019 1:11 AM
> > > > > To: Shawn Guo <shawnguo@kernel.org>
> > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > > linux-arm- kernel@lists.infradead.org;
> > > > > devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; Ying
> > > > > Zhang <ying.zhang22455@nxp.com>
> > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > > device node
> > > > >
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Shawn Guo <shawnguo@kernel.org>
> > > > > > Sent: 2019年5月17日 10:38
> > > > > > To: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > > > linux-arm-kernel@lists.infradead.org;
> > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying
> > > > > > Zhang <ying.zhang22455@nxp.com>
> > > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > > > device node
> > > > > >
> > > > > > Caution: EXT Email
> > > > > >
> > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > > > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform
> > > > > > > clock as timer clock, this patch fix device tree node.
> > > > > > >
> > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > > > ---
> > > > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > > > > > ++++++++++++-------
> > > > > > > 1 file changed, 12 insertions(+), 7 deletions(-)
> > > > > > >
> > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > index b04581249f0b..1510b1858246 100644
> > > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > @@ -285,13 +285,18 @@
> > > > > > > #interrupt-cells = <2>;
> > > > > > > };
> > > > > > >
> > > > > > > - wdog0: watchdog@23c0000 {
> > > > > > > - compatible = "fsl,ls1028a-wdt",
> > "fsl,imx21-wdt";
> > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > > > - interrupts = <GIC_SPI 59
> > > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > - clocks = <&clockgen 4 1>;
> > > > > > > - big-endian;
> > > > > > > - status = "disabled";
> > > > > > > + cluster1_core0_watchdog: wdt@c000000 {
> > > > > >
> > > > > > Keep 'watchdog' as the node name,
> > > > > Thanks for your replay
> > > > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > > > and keep nodes sort in unit-address.
> > > > > What does this mean?
> > > >
> > > > That means order the nodes by the addresses (e.g. c000000,
> > > > c010000)
> > > The current order is correct（The first is c000000, then c000000）.
> >
> > But they are added after gpio@2320000 and before sata@3200000.
> I changed and made the second version of the patch, but I found the
> following error when I executed ./scripts/checkpatch.pl xxx.patch to check
> the patch:
>
> WARNING: DT compatible string vendor "arm" appears un-documented --
> check ./Documentation/devicetree/bindings/vendor-prefixes.txt
> #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
> + compatible = "arm,sp805", "arm,primecell";
>
> However, there is no vendor-prefixes.txt file in
> the ./Documentation/devicetree/bindings/ directory, only vendor-
> prefixes.yaml.
> Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.
Added Rob Herring to the thread.
> Request help，thanks
> >
> > > >
> > > > > >
> > > > > > Shawn
> > > > > >
> > > > > > > + compatible = "arm,sp805", "arm,primecell";
> > > > > > > + reg = <0x0 0xc000000 0x0 0x1000>;
> > > > > > > + clocks = <&clockgen 4 15>, <&clockgen
> > > > > > > + 4
> > 15>;
> > > > > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > > > > + };
> > > > > > > +
> > > > > > > + cluster1_core1_watchdog: wdt@c010000 {
> > > > > > > + compatible = "arm,sp805", "arm,primecell";
> > > > > > > + reg = <0x0 0xc010000 0x0 0x1000>;
> > > > > > > + clocks = <&clockgen 4 15>, <&clockgen
> > > > > > > + 4
> > 15>;
> > > > > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > > > > };
> > > > > > >
> > > > > > > sata: sata@3200000 {
> > > > > > > --
> > > > > > > 2.17.1
> > > > > > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-22 6:50 ` Leo Li
@ 2019-05-24 9:48 ` Chuanhua Han
2019-05-24 12:29 ` Rob Herring
0 siblings, 1 reply; 11+ messages in thread
From: Chuanhua Han @ 2019-05-24 9:48 UTC (permalink / raw)
To: Leo Li, Shawn Guo, Rob Herring
Cc: mark.rutland, linux-arm-kernel, devicetree, linux-kernel, Ying Zhang
Hi, Rob Herring
> -----Original Message-----
> From: Leo Li
> Sent: 2019年5月22日 14:50
> To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> <shawnguo@kernel.org>; Rob Herring <robh@kernel.org>
> Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
>
>
> > -----Original Message-----
> > From: Chuanhua Han
> > Sent: Wednesday, May 22, 2019 1:26 AM
> > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > <ying.zhang22455@nxp.com>
> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > device node
> >
> >
> >
> > > -----Original Message-----
> > > From: Leo Li
> > > Sent: 2019年5月22日 4:15
> > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > > <shawnguo@kernel.org>
> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > > <ying.zhang22455@nxp.com>
> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > device node
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Chuanhua Han
> > > > Sent: Tuesday, May 21, 2019 8:00 AM
> > > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying
> > > > Zhang <ying.zhang22455@nxp.com>
> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > device node
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Leo Li
> > > > > Sent: 2019年5月18日 6:01
> > > > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > > > > <shawnguo@kernel.org>
> > > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying
> > > > > Zhang <ying.zhang22455@nxp.com>
> > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > > device node
> > > > >
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Chuanhua Han
> > > > > > Sent: Friday, May 17, 2019 1:11 AM
> > > > > > To: Shawn Guo <shawnguo@kernel.org>
> > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > > > linux-arm- kernel@lists.infradead.org;
> > > > > > devicetree@vger.kernel.org; linux- kernel@vger.kernel.org;
> > > > > > Ying Zhang <ying.zhang22455@nxp.com>
> > > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix
> > > > > > watchdog device node
> > > > > >
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Shawn Guo <shawnguo@kernel.org>
> > > > > > > Sent: 2019年5月17日 10:38
> > > > > > > To: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > > > > linux-arm-kernel@lists.infradead.org;
> > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > > > > > Ying Zhang <ying.zhang22455@nxp.com>
> > > > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > > > > device node
> > > > > > >
> > > > > > > Caution: EXT Email
> > > > > > >
> > > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > > > > > > ls1028a platform uses sp805 watchdog, and use 1/16
> > > > > > > > platform clock as timer clock, this patch fix device tree node.
> > > > > > > >
> > > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > > > > ---
> > > > > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > > > > > > ++++++++++++-------
> > > > > > > > 1 file changed, 12 insertions(+), 7 deletions(-)
> > > > > > > >
> > > > > > > > diff --git
> > > > > > > > a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > index b04581249f0b..1510b1858246 100644
> > > > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > @@ -285,13 +285,18 @@
> > > > > > > > #interrupt-cells = <2>;
> > > > > > > > };
> > > > > > > >
> > > > > > > > - wdog0: watchdog@23c0000 {
> > > > > > > > - compatible = "fsl,ls1028a-wdt",
> > > "fsl,imx21-wdt";
> > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > > > > - interrupts = <GIC_SPI 59
> > > > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > > - clocks = <&clockgen 4 1>;
> > > > > > > > - big-endian;
> > > > > > > > - status = "disabled";
> > > > > > > > + cluster1_core0_watchdog: wdt@c000000 {
> > > > > > >
> > > > > > > Keep 'watchdog' as the node name,
> > > > > > Thanks for your replay
> > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > > > > and keep nodes sort in unit-address.
> > > > > > What does this mean?
> > > > >
> > > > > That means order the nodes by the addresses (e.g. c000000,
> > > > > c010000)
> > > > The current order is correct（The first is c000000, then c000000）.
> > >
> > > But they are added after gpio@2320000 and before sata@3200000.
> > I changed and made the second version of the patch, but I found the
> > following error when I executed ./scripts/checkpatch.pl xxx.patch to
> > check the patch:
> >
> > WARNING: DT compatible string vendor "arm" appears un-documented --
> > check ./Documentation/devicetree/bindings/vendor-prefixes.txt
> > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
> > + compatible = "arm,sp805", "arm,primecell";
> >
> > However, there is no vendor-prefixes.txt file in the
> > ./Documentation/devicetree/bindings/ directory, only vendor-
> > prefixes.yaml.
> > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.
>
> Added Rob Herring to the thread.
>
> > Request help，thanks
How can I solve this patch check error? Ask for help, thank you!
> > >
> > > > >
> > > > > > >
> > > > > > > Shawn
> > > > > > >
> > > > > > > > + compatible = "arm,sp805",
> "arm,primecell";
> > > > > > > > + reg = <0x0 0xc000000 0x0 0x1000>;
> > > > > > > > + clocks = <&clockgen 4 15>,
> > > > > > > > + <&clockgen
> > > > > > > > + 4
> > > 15>;
> > > > > > > > + clock-names = "apb_pclk", "wdog_clk";
> > > > > > > > + };
> > > > > > > > +
> > > > > > > > + cluster1_core1_watchdog: wdt@c010000 {
> > > > > > > > + compatible = "arm,sp805",
> "arm,primecell";
> > > > > > > > + reg = <0x0 0xc010000 0x0 0x1000>;
> > > > > > > > + clocks = <&clockgen 4 15>,
> > > > > > > > + <&clockgen
> > > > > > > > + 4
> > > 15>;
> > > > > > > > + clock-names = "apb_pclk",
> > > > > > > > + "wdog_clk";
> > > > > > > > };
> > > > > > > >
> > > > > > > > sata: sata@3200000 {
> > > > > > > > --
> > > > > > > > 2.17.1
> > > > > > > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-24 9:48 ` Chuanhua Han
@ 2019-05-24 12:29 ` Rob Herring
2019-05-30 3:09 ` Chuanhua Han
0 siblings, 1 reply; 11+ messages in thread
From: Rob Herring @ 2019-05-24 12:29 UTC (permalink / raw)
To: Chuanhua Han
Cc: Leo Li, Shawn Guo, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Ying Zhang
On Fri, May 24, 2019 at 4:48 AM Chuanhua Han <chuanhua.han@nxp.com> wrote:
>
> Hi, Rob Herring
>
> > -----Original Message-----
> > From: Leo Li
> > Sent: 2019年5月22日 14:50
> > > > > > > > > - wdog0: watchdog@23c0000 {
> > > > > > > > > - compatible = "fsl,ls1028a-wdt",
> > > > "fsl,imx21-wdt";
> > > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > > > > > - interrupts = <GIC_SPI 59
> > > > > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > > > - clocks = <&clockgen 4 1>;
> > > > > > > > > - big-endian;
> > > > > > > > > - status = "disabled";
> > > > > > > > > + cluster1_core0_watchdog: wdt@c000000 {
> > > > > > > >
> > > > > > > > Keep 'watchdog' as the node name,
> > > > > > > Thanks for your replay
> > > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > > > > > and keep nodes sort in unit-address.
> > > > > > > What does this mean?
> > > > > >
> > > > > > That means order the nodes by the addresses (e.g. c000000,
> > > > > > c010000)
> > > > > The current order is correct（The first is c000000, then c000000）.
> > > >
> > > > But they are added after gpio@2320000 and before sata@3200000.
> > > I changed and made the second version of the patch, but I found the
> > > following error when I executed ./scripts/checkpatch.pl xxx.patch to
> > > check the patch:
> > >
> > > WARNING: DT compatible string vendor "arm" appears un-documented --
> > > check ./Documentation/devicetree/bindings/vendor-prefixes.txt
> > > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
> > > + compatible = "arm,sp805", "arm,primecell";
> > >
> > > However, there is no vendor-prefixes.txt file in the
> > > ./Documentation/devicetree/bindings/ directory, only vendor-
> > > prefixes.yaml.
> > > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.
> >
> > Added Rob Herring to the thread.
> >
> > > Request help，thanks
> How can I solve this patch check error? Ask for help, thank you!
Ignore it. A fix to checkpatch.pl is pending.
Rob
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
2019-05-24 12:29 ` Rob Herring
@ 2019-05-30 3:09 ` Chuanhua Han
0 siblings, 0 replies; 11+ messages in thread
From: Chuanhua Han @ 2019-05-30 3:09 UTC (permalink / raw)
To: Rob Herring
Cc: Leo Li, Shawn Guo, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Ying Zhang
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2019年5月24日 20:29
> To: Chuanhua Han <chuanhua.han@nxp.com>
> Cc: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>;
> mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> <ying.zhang22455@nxp.com>
> Subject: Re: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
>
> Caution: EXT Email
>
> On Fri, May 24, 2019 at 4:48 AM Chuanhua Han <chuanhua.han@nxp.com>
> wrote:
> >
> > Hi, Rob Herring
> >
> > > -----Original Message-----
> > > From: Leo Li
> > > Sent: 2019年5月22日 14:50
>
>
> > > > > > > > > > - wdog0: watchdog@23c0000 {
> > > > > > > > > > - compatible = "fsl,ls1028a-wdt",
> > > > > "fsl,imx21-wdt";
> > > > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > > > > > > - interrupts = <GIC_SPI 59
> > > > > > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > > > > - clocks = <&clockgen 4 1>;
> > > > > > > > > > - big-endian;
> > > > > > > > > > - status = "disabled";
> > > > > > > > > > + cluster1_core0_watchdog: wdt@c000000 {
> > > > > > > > >
> > > > > > > > > Keep 'watchdog' as the node name,
> > > > > > > > Thanks for your replay
> > > > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > > > > > > and keep nodes sort in unit-address.
> > > > > > > > What does this mean?
> > > > > > >
> > > > > > > That means order the nodes by the addresses (e.g. c000000,
> > > > > > > c010000)
> > > > > > The current order is correct（The first is c000000, then c000000）.
> > > > >
> > > > > But they are added after gpio@2320000 and before sata@3200000.
> > > > I changed and made the second version of the patch, but I found
> > > > the following error when I executed ./scripts/checkpatch.pl
> > > > xxx.patch to check the patch:
> > > >
> > > > WARNING: DT compatible string vendor "arm" appears un-documented
> > > > -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt
> > > > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
> > > > + compatible = "arm,sp805", "arm,primecell";
> > > >
> > > > However, there is no vendor-prefixes.txt file in the
> > > > ./Documentation/devicetree/bindings/ directory, only vendor-
> > > > prefixes.yaml.
> > > > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.
> > >
> > > Added Rob Herring to the thread.
> > >
> > > > Request help，thanks
> > How can I solve this patch check error? Ask for help, thank you!
>
> Ignore it. A fix to checkpatch.pl is pending.
OK, the second version has been sent. Checking with checkpatch.pl is no problem.
>
> Rob
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-05-30 5:00 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-09 7:06 [PATCH] arm64: dts: ls1028a: fix watchdog device node Chuanhua Han
2019-05-17 2:37 ` Shawn Guo
2019-05-17 6:10 ` [EXT] " Chuanhua Han
2019-05-17 22:01 ` Leo Li
2019-05-21 13:00 ` Chuanhua Han
2019-05-21 20:14 ` Leo Li
2019-05-22 6:26 ` Chuanhua Han
2019-05-22 6:50 ` Leo Li
2019-05-24 9:48 ` Chuanhua Han
2019-05-24 12:29 ` Rob Herring
2019-05-30 3:09 ` Chuanhua Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).