LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>,
	j-nomura@ce.jp.nec.com, kasong@redhat.com,
	fanc.fnst@cn.fujitsu.com, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	hpa@zytor.com, tglx@linutronix.de
Subject: [PATCH] x86/boot: Call get_rsdp_addr() after console_init()
Date: Fri, 17 May 2019 15:50:30 +0200	[thread overview]
Message-ID: <20190517135030.GB13482@zn.tnic> (raw)
In-Reply-To: <20190517134159.GA13482@zn.tnic>

And now as a proper patch:

---
From: Borislav Petkov <bp@suse.de>

... so that early debugging output from the RSDP parsing code can be
visible and collected.

Suggested-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Baoquan He <bhe@redhat.com>
Cc: Chao Fan <fanc.fnst@cn.fujitsu.com>
Cc: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Kairui Song <kasong@redhat.com>
Cc: kexec@lists.infradead.org
Cc: x86@kernel.org
---
 arch/x86/boot/compressed/misc.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
index c0d6c560df69..24e65a0f756d 100644
--- a/arch/x86/boot/compressed/misc.c
+++ b/arch/x86/boot/compressed/misc.c
@@ -351,9 +351,6 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
 	/* Clear flags intended for solely in-kernel use. */
 	boot_params->hdr.loadflags &= ~KASLR_FLAG;
 
-	/* Save RSDP address for later use. */
-	boot_params->acpi_rsdp_addr = get_rsdp_addr();
-
 	sanitize_boot_params(boot_params);
 
 	if (boot_params->screen_info.orig_video_mode == 7) {
@@ -368,6 +365,14 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
 	cols = boot_params->screen_info.orig_video_cols;
 
 	console_init();
+
+	/*
+	 * Save RSDP address for later use. Have this after console_init()
+	 * so that early debugging output from the RSDP parsing code can be
+	 * collected.
+	 */
+	boot_params->acpi_rsdp_addr = get_rsdp_addr();
+
 	debug_putstr("early console in extract_kernel\n");
 
 	free_mem_ptr     = heap;	/* Heap */
-- 
2.21.0


-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2019-05-17 13:50 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  9:29 [PATCH v5 0/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Baoquan He
2019-04-24  9:29 ` [PATCH v5 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables Baoquan He
2019-04-27 16:11   ` Borislav Petkov
2019-04-28  5:41     ` Baoquan He
2019-04-29 12:50       ` Borislav Petkov
2019-04-29  0:23   ` [PATCH v6 " Baoquan He
2019-04-29 13:55     ` Borislav Petkov
2019-04-29 14:16       ` Baoquan He
2019-05-13  1:43       ` Baoquan He
2019-05-13  7:07         ` Borislav Petkov
2019-05-13  7:32           ` Baoquan He
2019-05-13  7:50             ` Borislav Petkov
2019-05-13  8:02               ` Baoquan He
2019-05-15  5:17                 ` Junichi Nomura
2019-05-15  6:58                   ` Borislav Petkov
2019-05-15  7:09                     ` Junichi Nomura
2019-05-21  9:02                       ` Kairui Song
2019-05-21 10:43                         ` Junichi Nomura
2019-05-21 18:09                         ` Borislav Petkov
2019-05-28  2:49                           ` Kairui Song
2019-06-06 19:20                             ` Borislav Petkov
2019-05-13  8:06               ` Baoquan He
2019-05-14  3:22                 ` Dave Young
2019-05-14  3:33                   ` Baoquan He
2019-05-21 21:53                     ` Dirk van der Merwe
2019-05-21 23:04                       ` Borislav Petkov
2019-05-14  8:48                   ` Dave Young
2019-05-14 11:18                     ` Kairui Song
2019-05-14 11:38                     ` Peter Zijlstra
2019-05-14 12:58                       ` Dave Young
2019-05-14 13:54                         ` Peter Zijlstra
2019-05-14 14:09                         ` Ingo Molnar
2019-05-15  1:08                           ` Dave Young
2019-05-15  6:43                             ` Junichi Nomura
2019-05-17 13:41                   ` Borislav Petkov
2019-05-17 13:50                     ` Borislav Petkov [this message]
2019-05-21  9:28                       ` [PATCH] x86/boot: Call get_rsdp_addr() after console_init() Baoquan He
2019-06-06 19:22     ` [tip:x86/boot] x86/kexec: Add the EFI system tables and ACPI tables to the ident map tip-bot for Kairui Song
2019-04-24  9:29 ` [PATCH v5 2/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels Baoquan He
2019-04-24  9:33   ` Baoquan He
2019-04-24  9:38 ` [PATCH v5 0/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Borislav Petkov
2019-04-24 10:00   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517135030.GB13482@zn.tnic \
    --to=bp@alien8.de \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=fanc.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=kasong@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH] x86/boot: Call get_rsdp_addr() after console_init()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).