From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08046C04AAC for ; Mon, 20 May 2019 18:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAABA21743 for ; Mon, 20 May 2019 18:25:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fomichev-me.20150623.gappssmtp.com header.i=@fomichev-me.20150623.gappssmtp.com header.b="2A564VW7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726220AbfETSZ5 (ORCPT ); Mon, 20 May 2019 14:25:57 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39574 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbfETSZ4 (ORCPT ); Mon, 20 May 2019 14:25:56 -0400 Received: by mail-pf1-f196.google.com with SMTP id z26so7625591pfg.6 for ; Mon, 20 May 2019 11:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomichev-me.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=b+R02j4/uF0EBO8erZc6QpLT1KkcKmjQEE/WVjBwbqw=; b=2A564VW7Oyzj0BgET4LsDx48f+Hw3pSS6w3xynY5mMy5xtcRM1B8MZPQUUcEjQ2xWA 1F6qNxmN5PaUvBFi1/HV2xFjYgY/FSVMlGTa6qQzYhPR3+EeXG57ojk/bhl6XngO2oHD zWQMRkkstcr1EDQWm2qs5v9mSYaa6OT7qGFgaV1RHqtExsH6+OWqpNHPFJ1jeJCxuhBJ Q24+7G1XEHIIw7sVUiSgNv2ng1ZvfumTfRKOJva5z6erCwNZXiYakka7zi+ykhykCfQz vZMQbxQI7RMghlwJTTBQZIgf0T1rG0MC4wPF6bNxlrDkIuvOa0lc6dNP+CpS5gc0Fwmd Zflw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=b+R02j4/uF0EBO8erZc6QpLT1KkcKmjQEE/WVjBwbqw=; b=lmuNQ6Dorkd8GeMU79Y+LMI6r+ahTjLPVkBdZ88mJ7XPdZPULvt+uh+L2acjOaSE/D 4n5EV81hmF4ssrQthbMWBsTrToAaHbqc/0wsR0FmiU6xLE4t7qOKrueJV5SicQ5hGhoh IgqmnPR1874FWE0C8/8WC7G7GgRZqOZeX7U6QBNuK5by2vuL605fSDiyxSKGH9qbX7On deRAJS746EEutC2P0mcMVtHfeqAoqNxHF2vrTz/M60j9QhfQLWJcn2BVX2uwNMWW5FPs nTD7yPoQt8ZeALtQUv0TGuHROeknC/rwkTE9JyaCHiKIBBpK1h0WlReAsNEvzhueJeZL qSEw== X-Gm-Message-State: APjAAAXsfAuqnu55ALAUQGq6b3a2g0J/ivbuoj/akYM+velstdt9gIW3 PvyPJ8yXQw7cS/qNKmFISdkZrw== X-Google-Smtp-Source: APXvYqy+h7aOKSTpc9FbuMEelpZCzxxfLULlbA1XwBW1GmxOy5JwFWue60yJ1JXHzJ7VZze8Rc4osg== X-Received: by 2002:a62:7fcd:: with SMTP id a196mr32974973pfd.195.1558376755698; Mon, 20 May 2019 11:25:55 -0700 (PDT) Received: from localhost ([2601:646:8f00:18d9:d0fa:7a4b:764f:de48]) by smtp.gmail.com with ESMTPSA id z7sm23516073pfr.23.2019.05.20.11.25.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 11:25:55 -0700 (PDT) Date: Mon, 20 May 2019 11:25:54 -0700 From: Stanislav Fomichev To: Matteo Croce Cc: xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, LKML , netdev , Alexei Starovoitov , Daniel Borkmann Subject: Re: [PATCH 2/5] libbpf: add missing typedef Message-ID: <20190520182554.GI10244@mini-arch> References: <20190518004639.20648-1-mcroce@redhat.com> <20190518004639.20648-2-mcroce@redhat.com> <20190520165322.GH10244@mini-arch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/20, Matteo Croce wrote: > On Mon, May 20, 2019 at 6:53 PM Stanislav Fomichev wrote: > > > > On 05/18, Matteo Croce wrote: > > > Sync tools/include/linux/types.h with the UAPI one to fix this build error: > > > > > > make -C samples/bpf/../../tools/lib/bpf/ RM='rm -rf' LDFLAGS= srctree=samples/bpf/../../ O= > > > HOSTCC samples/bpf/sock_example > > > In file included from samples/bpf/sock_example.c:27: > > > /usr/include/linux/ip.h:102:2: error: unknown type name ‘__sum16’ > > > 102 | __sum16 check; > > > | ^~~~~~~ > > > make[2]: *** [scripts/Makefile.host:92: samples/bpf/sock_example] Error 1 > > > make[1]: *** [Makefile:1763: samples/bpf/] Error 2 > > > > > > Signed-off-by: Matteo Croce > > > --- > > > tools/include/linux/types.h | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/tools/include/linux/types.h b/tools/include/linux/types.h > > > index 154eb4e3ca7c..5266dbfee945 100644 > > > --- a/tools/include/linux/types.h > > > +++ b/tools/include/linux/types.h > > > @@ -58,6 +58,9 @@ typedef __u32 __bitwise __be32; > > > typedef __u64 __bitwise __le64; > > > typedef __u64 __bitwise __be64; > > > > > > +typedef __u16 __bitwise __sum16; > > > +typedef __u32 __bitwise __wsum; > > If you do that, you should probably remove 'typedef __u16 __sum16;' > > from test_progs.h: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/tree/tools/testing/selftests/bpf/test_progs.h#n13 > > > > > + > > > typedef struct { > > > int counter; > > > } atomic_t; > > > -- > > > 2.21.0 > > > > > Hi, > > I see test_progs.h only included in tools/testing/selftests/bpf/prog_tests/*, > so maybe it's unreladed to my change in samples/bpf/. > Maybe in a different patchset. Yes, I'm just saying that now that you have __sum16 defined in tools/include/linux/types.h you can have another patch to remove that custom __sum16 typedef from tests_progs.h