LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robin van der Gracht <robin@protonic.nl>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: miguel.ojeda.sandonis@gmail.com, linux-kernel@vger.kernel.org,
	willy@infradead.org
Subject: Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()
Date: Tue, 21 May 2019 08:55:47 +0200	[thread overview]
Message-ID: <20190521085547.58e1650c@erd987> (raw)
In-Reply-To: <1558366258-3808-1-git-send-email-jrdr.linux@gmail.com>

On Mon, 20 May 2019 21:00:58 +0530
Souptick Joarder <jrdr.linux@gmail.com> wrote:

> While using mmap, the incorrect value of length and vm_pgoff are
> ignored and this driver go ahead with mapping fbdev.buffer
> to user vma.
> 
> Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
> "fix" these drivers to behave according to the normal vm_pgoff
> offsetting simply by removing the _zero suffix on the function name
> and if that causes regressions, it gives us an easy way to revert.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  drivers/auxdisplay/ht16k33.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
> index 21393ec..9c0bb77 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -223,9 +223,9 @@ static int ht16k33_bl_check_fb(struct backlight_device *bl, struct fb_info *fi)
>  static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma)
>  {
>  	struct ht16k33_priv *priv = info->par;
> +	struct page *pages = virt_to_page(priv->fbdev.buffer);
>  
> -	return vm_insert_page(vma, vma->vm_start,
> -			      virt_to_page(priv->fbdev.buffer));
> +	return vm_map_pages_zero(vma, &pages, 1);
>  }
>  
>  static struct fb_ops ht16k33_fb_ops = {

Acked-by: Robin van der Gracht <robin@protonic.nl>

  reply	other threads:[~2019-05-21  7:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 15:30 Souptick Joarder
2019-05-21  6:55 ` Robin van der Gracht [this message]
2019-05-23  8:18   ` Souptick Joarder
2019-05-23 12:58     ` Miguel Ojeda
2019-05-24  4:22       ` Miguel Ojeda
2019-05-24  6:07         ` Souptick Joarder
2019-05-28 19:03           ` Miguel Ojeda
2019-05-23 13:23 ` Miguel Ojeda
2019-05-24  6:10   ` Souptick Joarder
2019-05-26 16:11 Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521085547.58e1650c@erd987 \
    --to=robin@protonic.nl \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).