From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FEEC46460 for ; Tue, 21 May 2019 12:57:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5880021773 for ; Tue, 21 May 2019 12:57:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728229AbfEUM5I (ORCPT ); Tue, 21 May 2019 08:57:08 -0400 Received: from mga05.intel.com ([192.55.52.43]:51720 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbfEUM5I (ORCPT ); Tue, 21 May 2019 08:57:08 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 05:57:07 -0700 X-ExtLoop1: 1 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga004.fm.intel.com with ESMTP; 21 May 2019 05:57:05 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hT4KG-00088Q-Hh; Tue, 21 May 2019 15:57:04 +0300 Date: Tue, 21 May 2019 15:57:04 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: Charles Keepax , wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com, Jarkko Nikula Subject: Re: [PATCH 3/5] i2c: core: Move ACPI IRQ handling to probe time Message-ID: <20190521125704.GF9224@smile.fi.intel.com> References: <20190520084936.10590-1-ckeepax@opensource.cirrus.com> <20190520084936.10590-4-ckeepax@opensource.cirrus.com> <20190521112728.GX2781@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521112728.GX2781@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 02:27:28PM +0300, Mika Westerberg wrote: > On Mon, May 20, 2019 at 09:49:34AM +0100, Charles Keepax wrote: > > Bring the ACPI path in sync with the device tree path and handle all the > > IRQ fetching at probe time. This leaves the only IRQ handling at device > > registration time being that which is passed directly through the board > > info as either a resource or an actual IRQ number. > > I don't see issues with this approach. Cc'd Jarkko and Andy just in case > I missed something. I failed to see the i2c_acpi_get_irq() in the current code. What kernel version do you use? Can we see the changes against vanilla / i2c-next? -- With Best Regards, Andy Shevchenko