LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/spelling.txt: drop "sepc" from the misspelling list
Date: Tue, 21 May 2019 17:14:22 -0700 [thread overview]
Message-ID: <20190521171422.c7ef965e39b27f6142788412@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1905191108180.10723@viisi.sifive.com>
On Sun, 19 May 2019 11:24:22 -0700 (PDT) Paul Walmsley <paul.walmsley@sifive.com> wrote:
> On Sat, 18 May 2019, Joe Perches wrote:
>
> > On Sat, 2019-05-18 at 14:00 -0700, Paul Walmsley wrote:
> > > The RISC-V architecture has a register named the "Supervisor Exception
> > > Program Counter", or "sepc". This abbreviation triggers
> > > checkpatch.pl's misspelling detector, resulting in noise in the
> > > checkpatch output. The risk that this noise could cause more useful
> > > warnings to be missed seems to outweigh the harm of an occasional
> > > misspelling of "spec". Thus drop the "sepc" entry from the
> > > misspelling list.
> >
> > I would agree if you first fixed the existing sepc/spec
> > and sepcific/specific typos.
> >
> > arch/powerpc/kvm/book3s_xics.c: * a pending interrupt, this is a SW error and PAPR sepcifies
> > arch/unicore32/include/mach/regs-gpio.h: * Sepcial Voltage Detect Reg GPIO_GPIR.
> > drivers/scsi/lpfc/lpfc_init.c: /* Stop any OneConnect device sepcific driver timers */
> > drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:* OverView: Read "sepcific bits" from BB register
> > drivers/net/wireless/realtek/rtlwifi/wifi.h:/* Ref: 802.11i sepc D10.0 7.3.2.25.1
>
> Your agreement shouldn't be needed for the patch I sent.
I always find Joe's input to be very useful.
Here:
From: Andrew Morton <akpm@linux-foundation.org>
Subject: scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix
fix existing "sepc" instances, per Joe
Cc: Joe Perches <joe@perches.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/powerpc/kvm/book3s_xics.c | 2 +-
arch/unicore32/include/mach/regs-gpio.h | 2 +-
drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 +-
drivers/scsi/lpfc/lpfc_init.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
--- a/arch/powerpc/kvm/book3s_xics.c~scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix
+++ a/arch/powerpc/kvm/book3s_xics.c
@@ -830,7 +830,7 @@ static noinline int kvmppc_h_eoi(struct
*
* Note: If EOI is incorrectly used by SW to lower the CPPR
* value (ie more favored), we do not check for rejection of
- * a pending interrupt, this is a SW error and PAPR sepcifies
+ * a pending interrupt, this is a SW error and PAPR specifies
* that we don't have to deal with it.
*
* The sending of an EOI to the ICS is handled after the
--- a/arch/unicore32/include/mach/regs-gpio.h~scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix
+++ a/arch/unicore32/include/mach/regs-gpio.h
@@ -32,7 +32,7 @@
*/
#define GPIO_GEDR (PKUNITY_GPIO_BASE + 0x0018)
/*
- * Sepcial Voltage Detect Reg GPIO_GPIR.
+ * Special Voltage Detect Reg GPIO_GPIR.
*/
#define GPIO_GPIR (PKUNITY_GPIO_BASE + 0x0020)
--- a/drivers/net/wireless/realtek/rtlwifi/wifi.h~scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix
+++ a/drivers/net/wireless/realtek/rtlwifi/wifi.h
@@ -597,7 +597,7 @@ enum ht_channel_width {
HT_CHANNEL_WIDTH_MAX,
};
-/* Ref: 802.11i sepc D10.0 7.3.2.25.1
+/* Ref: 802.11i spec D10.0 7.3.2.25.1
* Cipher Suites Encryption Algorithms
*/
enum rt_enc_alg {
--- a/drivers/scsi/lpfc/lpfc_init.c~scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix
+++ a/drivers/scsi/lpfc/lpfc_init.c
@@ -2963,7 +2963,7 @@ lpfc_stop_hba_timers(struct lpfc_hba *ph
del_timer_sync(&phba->fcp_poll_timer);
break;
case LPFC_PCI_DEV_OC:
- /* Stop any OneConnect device sepcific driver timers */
+ /* Stop any OneConnect device specific driver timers */
lpfc_sli4_stop_fcf_redisc_wait_timer(phba);
break;
default:
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c~scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix
+++ a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
@@ -45,7 +45,7 @@ static u32 phy_CalculateBitShift(u32 Bit
/**
* Function: PHY_QueryBBReg
*
-* OverView: Read "sepcific bits" from BB register
+* OverView: Read "specific bits" from BB register
*
* Input:
* struct adapter * Adapter,
_
next prev parent reply other threads:[~2019-05-22 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 21:00 Paul Walmsley
2019-05-19 5:07 ` Joe Perches
2019-05-19 18:24 ` Paul Walmsley
2019-05-22 0:14 ` Andrew Morton [this message]
2019-05-22 4:47 ` Paul Walmsley
2019-05-22 5:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521171422.c7ef965e39b27f6142788412@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.walmsley@sifive.com \
--subject='Re: [PATCH] scripts/spelling.txt: drop "sepc" from the misspelling list' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).