LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the drm-intel tree
@ 2019-05-20 12:15 Stephen Rothwell
  2019-05-21 13:02 ` Joonas Lahtinen
  2019-05-21 13:04 ` Comments in Fixes: line (Was: Re: linux-next: Fixes tag needs some work in the drm-intel tree) Joonas Lahtinen
  0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2019-05-20 12:15 UTC (permalink / raw)
  To: Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Intel Graphics, DRI
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chris Wilson

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

In commit

  0d90ccb70211 ("drm/i915: Delay semaphore submission until the start of the signaler")

Fixes tag

  Fixes: e88619646971 ("drm/i915: Use HW semaphores for inter-engine synchroni

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please don't split Fixes tags across more than one line.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Fixes tag needs some work in the drm-intel tree
  2019-05-20 12:15 linux-next: Fixes tag needs some work in the drm-intel tree Stephen Rothwell
@ 2019-05-21 13:02 ` Joonas Lahtinen
  2019-05-21 13:04 ` Comments in Fixes: line (Was: Re: linux-next: Fixes tag needs some work in the drm-intel tree) Joonas Lahtinen
  1 sibling, 0 replies; 4+ messages in thread
From: Joonas Lahtinen @ 2019-05-21 13:02 UTC (permalink / raw)
  To: DRI, Daniel Vetter, Intel Graphics, Jani Nikula, Rodrigo Vivi,
	Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chris Wilson

Quoting Stephen Rothwell (2019-05-20 15:15:38)
> Hi all,
> 
> In commit
> 
>   0d90ccb70211 ("drm/i915: Delay semaphore submission until the start of the signaler")
> 
> Fixes tag
> 
>   Fixes: e88619646971 ("drm/i915: Use HW semaphores for inter-engine synchroni
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please don't split Fixes tags across more than one line.

Thanks for the report.

This was a copy'n paste mishap, detected by our tooling (and fixed by
me) at the time of creating a PR. Unfortunately the check was not being
enforced by tooling at commit time. We'll fix that.

Regards, Joonas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Comments in Fixes: line (Was: Re: linux-next: Fixes tag needs some work in the drm-intel tree)
  2019-05-20 12:15 linux-next: Fixes tag needs some work in the drm-intel tree Stephen Rothwell
  2019-05-21 13:02 ` Joonas Lahtinen
@ 2019-05-21 13:04 ` Joonas Lahtinen
  2019-05-21 21:43   ` Stephen Rothwell
  1 sibling, 1 reply; 4+ messages in thread
From: Joonas Lahtinen @ 2019-05-21 13:04 UTC (permalink / raw)
  To: DRI, Daniel Vetter, Intel Graphics, Jani Nikula, Rodrigo Vivi,
	Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chris Wilson

We also have an incoming patch where the Fixes: line has a comment in
it. Does your tooling account for this when checking the Fixes: line?

Regards, Joonas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Comments in Fixes: line (Was: Re: linux-next: Fixes tag needs some work in the drm-intel tree)
  2019-05-21 13:04 ` Comments in Fixes: line (Was: Re: linux-next: Fixes tag needs some work in the drm-intel tree) Joonas Lahtinen
@ 2019-05-21 21:43   ` Stephen Rothwell
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2019-05-21 21:43 UTC (permalink / raw)
  To: Joonas Lahtinen
  Cc: DRI, Daniel Vetter, Intel Graphics, Jani Nikula, Rodrigo Vivi,
	Linux Next Mailing List, Linux Kernel Mailing List, Chris Wilson

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi Joonas,

On Tue, 21 May 2019 16:04:16 +0300 Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
>
> We also have an incoming patch where the Fixes: line has a comment in
> it. Does your tooling account for this when checking the Fixes: line?

I will make sure mine does.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-21 21:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 12:15 linux-next: Fixes tag needs some work in the drm-intel tree Stephen Rothwell
2019-05-21 13:02 ` Joonas Lahtinen
2019-05-21 13:04 ` Comments in Fixes: line (Was: Re: linux-next: Fixes tag needs some work in the drm-intel tree) Joonas Lahtinen
2019-05-21 21:43   ` Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).