LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Andrew Jones <firstname.lastname@example.org> To: Paolo Bonzini <email@example.com> Cc: "Thomas Huth" <firstname.lastname@example.org>, "Christian Borntraeger" <email@example.com>, "Janosch Frank" <firstname.lastname@example.org>, email@example.com, "Radim Krčmář" <firstname.lastname@example.org>, "Shuah Khan" <email@example.com>, "David Hildenbrand" <firstname.lastname@example.org>, "Cornelia Huck" <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [RFC PATCH 0/4] KVM selftests for s390x Date: Wed, 22 May 2019 10:44:09 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, May 20, 2019 at 01:43:06PM +0200, Paolo Bonzini wrote: > On 20/05/19 13:30, Thomas Huth wrote: > >> No objections at all, though it would be like to have ucall plumbed in > >> from the beginning. > > I'm still looking at the ucall interface ... what I don't quite get yet > > is the question why the ucall_type there is selectable during runtime? > > > > Are there plans to have test that could either use UCALL_PIO or > > UCALL_MMIO? If not, what about moving ucall_init() and ucall() to > > architecture specific code in tools/testing/selftests/kvm/lib/aarch64/ > > and tools/testing/selftests/kvm/lib/x86_64 instead, and to remove the > > ucall_type stuff again (so that x86 is hard-wired to PIO and aarch64 > > is hard-wired to MMIO)? ... then I could add a DIAG-based ucall > > on s390x more easily, I think. > > Yes, that would work. I think Andrew wanted the flexibility to use MMIO > on x86, but it's not really necessary to have it. If the flexibility isn't necessary, then I agree that it'll be nicer to put the ucall_init() in arch setup code, avoiding the need to remember it in each unit test. Thanks, drew
prev parent reply other threads:[~2019-05-22 8:44 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-16 11:12 [RFC PATCH 0/4] KVM selftests for s390x Thomas Huth 2019-05-16 11:12 ` [RFC PATCH 1/4] KVM: selftests: Guard struct kvm_vcpu_events with __KVM_HAVE_VCPU_EVENTS Thomas Huth 2019-05-16 11:22 ` David Hildenbrand 2019-05-20 7:12 ` Christian Borntraeger 2019-05-20 8:08 ` Thomas Huth 2019-05-20 8:13 ` Christian Borntraeger 2019-05-16 11:12 ` [RFC PATCH 2/4] KVM: selftests: Align memory region addresses to 1M on s390x Thomas Huth 2019-05-16 11:30 ` David Hildenbrand 2019-05-16 11:59 ` Thomas Huth 2019-05-16 12:08 ` David Hildenbrand 2019-05-16 11:12 ` [RFC PATCH 3/4] KVM: selftests: Add processor code for s390x Thomas Huth 2019-05-16 11:12 ` [RFC PATCH 4/4] KVM: selftests: Add the sync_regs test " Thomas Huth 2019-05-20 11:19 ` Paolo Bonzini 2019-05-23 10:56 ` Andrew Jones 2019-05-23 11:19 ` Thomas Huth 2019-05-20 11:20 ` [RFC PATCH 0/4] KVM selftests " Paolo Bonzini 2019-05-20 11:30 ` Thomas Huth 2019-05-20 11:43 ` Paolo Bonzini 2019-05-22 8:44 ` Andrew Jones [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).