LKML Archive on
help / color / mirror / Atom feed
From: Frederic Weisbecker <>
To: Peter Xu <>
	Frederic Weisbecker <>,
	Thomas Gleixner <>,
	Ingo Molnar <>
Subject: Re: [PATCH] tick/sched: Drop duplicated tick_sched.inidle
Date: Wed, 22 May 2019 14:18:41 +0200	[thread overview]
Message-ID: <20190522121837.GA11692@lerouge> (raw)
In-Reply-To: <>

On Wed, May 22, 2019 at 11:29:06AM +0800, Peter Xu wrote:
> It is set before entering idle and cleared when quitting idle, though
> it seems to be a complete duplicate of tick_sched.idle_active.  We
> should probably be able to use any one of them to replace the other.

Not exactly.

@inidle is set on idle entry and cleared on idle exit.
@idle_active is the same but it's cleared during idle interrupts
so that idle_sleeptime only account real idle time.

And note below:

> @@ -1017,7 +1015,7 @@ void tick_nohz_irq_exit(void)
>  {
>  	struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched);
> -	if (ts->inidle)
> +	if (ts->idle_active)
>  		tick_nohz_start_idle(ts);

idle_active will always be cleared here from tick_nohz_irq_enter().
We actually want to conditionally set it again depending on the inidle value.


  reply	other threads:[~2019-05-22 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  3:29 Peter Xu
2019-05-22 12:18 ` Frederic Weisbecker [this message]
2019-05-23  5:32   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522121837.GA11692@lerouge \ \ \ \ \ \ \
    --subject='Re: [PATCH] tick/sched: Drop duplicated tick_sched.inidle' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).