LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geordan Neukum <gneukum1@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies
Date: Wed, 22 May 2019 14:27:14 +0200	[thread overview]
Message-ID: <20190522122714.GA2270@kroah.com> (raw)
In-Reply-To: <932843299b814f3a22dd176771b46be14ceefeea.1558526487.git.gneukum1@gmail.com>

On Wed, May 22, 2019 at 12:13:57PM +0000, Geordan Neukum wrote:
> The kpc2000 core makes calls against functions which are conditionally
> exported upon the kconfig symbols 'MFD_CORE' and 'UIO' being selected
> Therefore, in order to guarantee correct compilation, the 'KPC2000'
> kconfig symbol (which brings in that code) must explicitly select its
> hard dependencies.
> 
> Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
> ---
>  drivers/staging/kpc2000/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
> index fb5922928f47..8992dc67ff37 100644
> --- a/drivers/staging/kpc2000/Kconfig
> +++ b/drivers/staging/kpc2000/Kconfig
> @@ -3,6 +3,8 @@
>  config KPC2000
>  	bool "Daktronics KPC Device support"
>  	depends on PCI
> +	select MFD_CORE
> +	select UIO

depends on is better than select.  There's a change to depend on UIO for
this code already in my -linus branch which will show up in Linus's tree
in a week or so.

Are you sure we need MFD_CORE as well for this code?  Why hasn't that
been seen on any build errors?

thanks,

greg k-h

  reply	other threads:[~2019-05-22 12:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 12:13 [PATCH 0/6] Minor updates to kpc_i2c driver and kpc2000 core Geordan Neukum
2019-05-22 12:13 ` [PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies Geordan Neukum
2019-05-22 12:27   ` Greg Kroah-Hartman [this message]
2019-05-23  1:35     ` Geordan Neukum
2019-05-23  5:36       ` Greg Kroah-Hartman
2019-05-24  2:36         ` [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000' Geordan Neukum
2019-05-24  3:02           ` Geordan Neukum
2019-05-24  6:50             ` Greg Kroah-Hartman
2019-05-22 12:13 ` [PATCH 2/6] staging: kpc2000: kpc_i2c: remove unused module param disable_features Geordan Neukum
2019-05-22 12:13 ` [PATCH 3/6] staging: kpc2000: kpc_i2c: newline fixups to meet linux style guide Geordan Neukum
2019-05-22 12:46   ` Greg Kroah-Hartman
2019-05-22 12:14 ` [PATCH 4/6] staging: kpc2000: kpc_i2c: use <linux/io.h> instead of <asm/io.h> Geordan Neukum
2019-05-22 12:14 ` [PATCH 5/6] staging: kpc2000: kpc_i2c: Remove unnecessary function tracing prints Geordan Neukum
2019-05-22 12:14 ` [PATCH 6/6] staging: kpc2000: kpc_i2c: add static qual to local symbols in kpc_i2c.c Geordan Neukum
2019-05-22 12:28 ` [PATCH 0/6] Minor updates to kpc_i2c driver and kpc2000 core Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522122714.GA2270@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gneukum1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/6] staging: kpc2000: make kconfig symbol '\''KPC2000'\'' select dependencies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).