From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA42C282CE for ; Wed, 22 May 2019 20:35:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B541521473 for ; Wed, 22 May 2019 20:35:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729899AbfEVUfI (ORCPT ); Wed, 22 May 2019 16:35:08 -0400 Received: from ms.lwn.net ([45.79.88.28]:49210 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728761AbfEVUfI (ORCPT ); Wed, 22 May 2019 16:35:08 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 58121AAB; Wed, 22 May 2019 20:35:07 +0000 (UTC) Date: Wed, 22 May 2019 14:35:06 -0600 From: Jonathan Corbet To: Mauro Carvalho Chehab Cc: Markus Heiser , Jani Nikula , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/sphinx-pre-install: make it handle Sphinx versions Message-ID: <20190522143506.34049678@lwn.net> In-Reply-To: References: Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 May 2019 13:28:34 -0400 Mauro Carvalho Chehab wrote: > As we want to switch to a newer Sphinx version in the future, > add some version detected logic, checking if the current > version meets the requirement and suggesting upgrade it the > version is supported but too old. > > Signed-off-by: Mauro Carvalho Chehab I've applied this in the branch with my other fixes (coming soon to a mailing list near you), thanks. I do think we eventually want to emit a warning during a normal docs build as well, and to raise the recommended version, but one step at a time... jon