LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Jan Luebbe <jlu@pengutronix.de> To: Alexey Dobriyan <adobriyan@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, John Ogness <john.ogness@linutronix.de>, Andy Lutomirski <luto@kernel.org> Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jan Luebbe <jlu@pengutronix.de> Subject: [PATCH] proc: report eip and esp for all threads when coredumping Date: Wed, 22 May 2019 18:16:14 +0200 [thread overview] Message-ID: <20190522161614.628-1-jlu@pengutronix.de> (raw) Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in /proc/PID/stat") stopped reporting eip/esp and commit fd7d56270b52 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") reintroduced the feature to fix a regression with userspace core dump handlers (such as minicoredumper). Because PF_DUMPCORE is only set for the primary thread, this didn't fix the original problem for secondary threads. This commit checks mm->core_state instead, as already done for /proc/<pid>/status in task_core_dumping(). As we have a mm_struct available here anyway, this seems to be a clean solution. Signed-off-by: Jan Luebbe <jlu@pengutronix.de> --- fs/proc/array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index 2edbb657f859..b76b1e29fc36 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -462,7 +462,7 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns, * a program is not able to use ptrace(2) in that case. It is * safe because the task has stopped executing permanently. */ - if (permitted && (task->flags & PF_DUMPCORE)) { + if (permitted && (!!mm->core_state)) { if (try_get_task_stack(task)) { eip = KSTK_EIP(task); esp = KSTK_ESP(task); -- 2.11.0
next reply other threads:[~2019-05-22 16:16 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-22 16:16 Jan Luebbe [this message] 2019-05-22 17:13 ` [PATCH] proc: report eip and esp for all threads when coredumping Alexey Dobriyan 2019-05-22 18:00 ` Andrew Morton 2019-05-23 8:15 ` Jan Lübbe 2019-05-24 23:50 ` John Ogness [not found] ` <20190525143220.e771b7915d17f22dad1438fa@linux-foundation.org> 2019-05-26 19:41 ` John Ogness 2019-05-29 8:55 ` [PATCHv2] fs/proc: allow reporting eip/esp for all coredumping threads John Ogness 2019-05-29 21:55 ` Andrew Morton 2019-05-30 0:58 ` [PATCHv3] " John Ogness 2019-05-30 1:14 ` Andrew Morton 2019-06-03 19:54 ` Jan Lübbe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190522161614.628-1-jlu@pengutronix.de \ --to=jlu@pengutronix.de \ --cc=adobriyan@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=john.ogness@linutronix.de \ --cc=kernel@pengutronix.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).