From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8C2C282CE for ; Wed, 22 May 2019 16:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B6D920862 for ; Wed, 22 May 2019 16:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ea9AGwuk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730093AbfEVQr6 (ORCPT ); Wed, 22 May 2019 12:47:58 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:35052 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729576AbfEVQr5 (ORCPT ); Wed, 22 May 2019 12:47:57 -0400 Received: by mail-pl1-f196.google.com with SMTP id p1so1360347plo.2 for ; Wed, 22 May 2019 09:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=RqdE9tcPj2Sig1IHHlxBhdByxPLCvB/FRuFMGYqZUAc=; b=Ea9AGwuk+eJ8vjFe9Z7cfFpGQZ20vo1Vp0h7KbvWi0oRxWqpSqNIAcKQNd9mG38u56 cZkMkfE//ny57dd6idgg4ERCea7YJsTIYKZ+q/5Ker4B2cqNbCa2mW9NRpIVaDbmZueg Rmg+Im9oPkNT719Vgp+kKnUsAP1qtx/EyXiz1Psz/HuJ476yz3zWkOnCuNXrwPiwm5aY xEo1FwZ8BCgReGpQB5pNx9VL6E6iRNqjefnI6+MM8Cp+/YiQE8Rtd9iluopb/lxGZBIc 693RQVy8FJbK40lWtK9xDRAwfTSnPoNI8JiKbCgia60ETrEtauDgZGCJfmeTsvq1ZtC4 b2ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=RqdE9tcPj2Sig1IHHlxBhdByxPLCvB/FRuFMGYqZUAc=; b=iz7c9MUR9PlBA0UD9yaf7rdNi1dn0EGVAblWwc7r6YPqfnP64LpDkGvEB1pAmwiH+x ahh8QhcpITsBgf0h+KSDOCMJ9h1zbbVp/oIdalZV/e5G64TnldMcNlYTtQTNqlABARvq xm5YxrnQteoOpeFY/Dh1PgM6S97P0/rJnddNBE4GHKbSTmmZ+wwIiZ3p+ilzYTAWNNVr 4jBVbodCXw7pADUfgHapgOpho7LL+Z2jYLZbuTmtd5Unc9IBT7B+XzHOGlfl3WegyccZ rPKxKT3lq8DkgrFlsk6xWTKofcfIQ5RP3Xn8AwqeL5fPbhB5viGp0CQCfQ3zDiTwKhhk 2BXQ== X-Gm-Message-State: APjAAAVkKgvXnsQI/MwcHYhjN82yaP1BcnbOvnk+b8pxzG51yHm4w8WC gojcesCwMfVyCP1KyGLmWsFnA/OW X-Google-Smtp-Source: APXvYqxWGOBljw9DezaxFKEKst5C3bpF2aTQ49t6P5OAaoiON7ebZi0PSD1nwB+8u6zrHseJUACqTQ== X-Received: by 2002:a17:902:a81:: with SMTP id 1mr45477799plp.287.1558543676859; Wed, 22 May 2019 09:47:56 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.92.73]) by smtp.gmail.com with ESMTPSA id d15sm31714915pfr.179.2019.05.22.09.47.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 09:47:55 -0700 (PDT) Date: Wed, 22 May 2019 22:17:48 +0530 From: Hariprasad Kelam To: Anirudh Rayabharam , Kimberly Brown , Nishka Dasgupta , Murray McAllister , Mamta Shukla , Hardik Singh Rathore , Larry Finger , Arnd Bergmann , Quytelda Kahja , Omer Efrat , Michael Straube , Emanuel Bennici , Andy Shevchenko , Jia-Ju Bai , Payal Kshirsagar , Wen Yang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [Patch v3] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0 Message-ID: <20190522164748.GA2870@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam ------ Changes v2 - change return type of rtw_sta_flush ------ Changes v3 - fix indentaion issue --- drivers/staging/rtl8723bs/core/rtw_ap.c | 7 ++----- drivers/staging/rtl8723bs/include/rtw_ap.h | 2 +- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 ++-- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 7 +++---- 4 files changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index bc02306..19418ea 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -2189,10 +2189,9 @@ u8 ap_free_sta( return beacon_updated; } -int rtw_sta_flush(struct adapter *padapter) +void rtw_sta_flush(struct adapter *padapter) { struct list_head *phead, *plist; - int ret = 0; struct sta_info *psta = NULL; struct sta_priv *pstapriv = &padapter->stapriv; struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; @@ -2202,7 +2201,7 @@ int rtw_sta_flush(struct adapter *padapter) DBG_871X(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); if ((pmlmeinfo->state&0x03) != WIFI_FW_AP_STATE) - return ret; + return; spin_lock_bh(&pstapriv->asoc_list_lock); phead = &pstapriv->asoc_list; @@ -2226,8 +2225,6 @@ int rtw_sta_flush(struct adapter *padapter) issue_deauth(padapter, bc_addr, WLAN_REASON_DEAUTH_LEAVING); associated_clients_update(padapter, true); - - return ret; } /* called > TSR LEVEL for USB or SDIO Interface*/ diff --git a/drivers/staging/rtl8723bs/include/rtw_ap.h b/drivers/staging/rtl8723bs/include/rtw_ap.h index fd56c9db..d6f3a3a 100644 --- a/drivers/staging/rtl8723bs/include/rtw_ap.h +++ b/drivers/staging/rtl8723bs/include/rtw_ap.h @@ -31,7 +31,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta); void sta_info_update(struct adapter *padapter, struct sta_info *psta); void ap_sta_info_defer_update(struct adapter *padapter, struct sta_info *psta); u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta, bool active, u16 reason); -int rtw_sta_flush(struct adapter *padapter); +void rtw_sta_flush(struct adapter *padapter); void start_ap_mode(struct adapter *padapter); void stop_ap_mode(struct adapter *padapter); diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index db553f2..ce57e0e 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -2896,9 +2896,9 @@ static int cfg80211_rtw_del_station(struct wiphy *wiphy, struct net_device *ndev flush_all_cam_entry(padapter); /* clear CAM */ - ret = rtw_sta_flush(padapter); + rtw_sta_flush(padapter); - return ret; + return 0; } diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index e3d3569..a4d05f2 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -3754,7 +3754,7 @@ static int rtw_set_beacon(struct net_device *dev, struct ieee_param *param, int } -static int rtw_hostapd_sta_flush(struct net_device *dev) +static void rtw_hostapd_sta_flush(struct net_device *dev) { /* _irqL irqL; */ /* struct list_head *phead, *plist; */ @@ -3766,8 +3766,7 @@ static int rtw_hostapd_sta_flush(struct net_device *dev) flush_all_cam_entry(padapter); /* clear CAM */ - return rtw_sta_flush(padapter); - + rtw_sta_flush(padapter); } static int rtw_add_sta(struct net_device *dev, struct ieee_param *param) @@ -4254,7 +4253,7 @@ static int rtw_hostapd_ioctl(struct net_device *dev, struct iw_point *p) switch (param->cmd) { case RTL871X_HOSTAPD_FLUSH: - ret = rtw_hostapd_sta_flush(dev); + rtw_hostapd_sta_flush(dev); break; -- 2.7.4