From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0464C282CE for ; Wed, 22 May 2019 19:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EAFB2081C for ; Wed, 22 May 2019 19:43:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ua7JRmVg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732679AbfEVTnX (ORCPT ); Wed, 22 May 2019 15:43:23 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:38302 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731580AbfEVT2X (ORCPT ); Wed, 22 May 2019 15:28:23 -0400 Received: by mail-qt1-f195.google.com with SMTP id l3so3837837qtj.5 for ; Wed, 22 May 2019 12:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3ZfKtMBwc5tkohkSpbvb3b5f3Ko8Dw0ybXpSQh5gt/E=; b=Ua7JRmVg/PPLyjYi4zwoj4WunekYxL3tW795MlxsVvKdjcveG8GFMEG8wA/t/Opq58 7xNTL6iMvk6B3aKn6J6SvcJkKT11Q0a/HG+sGy6SZsikPtB/+ZylHjb/ddJodsrkPzf+ OWA3bjYid2hKY949LckGkjXCuCv5Nn4+ilz3f2KCJbwzgSBhj1eUUb+lXoskoJWlUtZW d6uu4kVuXHiWGfya2X3zvyy9B5spYamL9cqhiKjzr/yuiduBoDjoJ/7QIvFRX2U6DSJp 5nQf7bimXoUDj6zDHNVPZE/BBaZhteVMTgwqoZ9fUWw+M8BPtUVMqAy45tBDyMQzSetZ Oj7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3ZfKtMBwc5tkohkSpbvb3b5f3Ko8Dw0ybXpSQh5gt/E=; b=ksKgU01TMCxFi/XMYqA3ut65P6cayMNg0KwV1Qlzv8k3A0DSmnTYtMiPj2uzMOSWjG C4xh6WA5ZnygViI+1xf4/IgMYqkEG/LyLV21xKhu7rLyG9C9JwuZer7gXF3LEt00LbF5 kcx5FWHySo+YrxG+ke2hucyyUZ5VSlt64peQe3bhAQpO6lcD42gcM5Uf6Vgao4WOFFhL EzZSYv/fXLE8KTBw8fiy/6e0vnhqKwuRqdFL5OOpWloQdIwmCiLx1Oy+N8nx+WN82eW6 d1Z0H/VE+dG7r9+gkVICZLSG5EKFgEFhHsPEXnLRhfIRKymIq0TYrgK8JWc49nM4sVXS Sy6g== X-Gm-Message-State: APjAAAUO2Ck7OeirIwMjB/lneKTA3rxSNv9/E50Ub8kMEzCfZ5Kry/pa YMJ/ucN2pjGrlH6/yMYcO/xUmg== X-Google-Smtp-Source: APXvYqzc1EkjVofK2ryq+qApOiRQDBnphGTKYrTx1+vwOy/VyDTwLBbYuBZjYqsGlyXiaiM/UHb2cw== X-Received: by 2002:aed:3a87:: with SMTP id o7mr23450420qte.310.1558553302565; Wed, 22 May 2019 12:28:22 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id l47sm13161288qtk.22.2019.05.22.12.28.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 May 2019 12:28:22 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hTWuT-0005oy-IJ; Wed, 22 May 2019 16:28:21 -0300 Date: Wed, 22 May 2019 16:28:21 -0300 From: Jason Gunthorpe To: Steven Rostedt Cc: LKML , Leon Romanovsky , Doug Ledford , linux-rdma@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH] RDMA/mlx5: Use DIV_ROUND_UP_ULL macro to allow 32 bit to build Message-ID: <20190522192821.GG6054@ziepe.ca> References: <20190522145450.25ff483d@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190522145450.25ff483d@gandalf.local.home> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 02:54:50PM -0400, Steven Rostedt wrote: > > From: Steven Rostedt (VMware) > > When testing 32 bit x86, my build failed with: > > ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined! > > It appears that a few non-ULL roundup() calls were made, which uses a > normal division against a 64 bit number. This is fine for x86_64, but > on 32 bit x86, it causes the compiler to look for a helper function > __udivdi3, which we do not have in the kernel, and thus fails to build. > > Signed-off-by: Steven Rostedt (VMware) > --- Do you like this version better? https://patchwork.kernel.org/patch/10950913/ Jason