From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76046C282CE for ; Wed, 22 May 2019 19:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48DBD2081C for ; Wed, 22 May 2019 19:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553860; bh=QxLbg+iBDQ7p8auMAtANB0+lL3E39nPvC/YZnTI6xQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WtRGhjL9aHguNzj7eNrGpcZbfZfgx9A72jdqARrgU6hXrPYegrn8eelUavTy02BXA S4o/fuB2bi7ahwrj9kYOOu6ptG/ECr4i8TlUCv/LvS7lKnE8QKvhxP5OK0X+cXmf+d lw36XrZDMT8Bun34N3WfnXG7AJ5xAlK+ns4IwqjA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731279AbfEVTaP (ORCPT ); Wed, 22 May 2019 15:30:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:53588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733173AbfEVTaL (ORCPT ); Wed, 22 May 2019 15:30:11 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 601E4217D7; Wed, 22 May 2019 19:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553411; bh=QxLbg+iBDQ7p8auMAtANB0+lL3E39nPvC/YZnTI6xQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R+1jc8IvcOjfKUl+SltfrYRUMc2iYFdmQRRilORguKMON70X17NVEnxRCh9NMYk14 hEcl01TyJ4Yx0/K8QrrSV+XXqVeI3gAzBf+sqh2WcwTfuTrsBz38CDpxViHKnbpWfm JLrZehEtWgyw8CYE6QJi7tkJ3U7mKdByTApQEm7o= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Philipp Zabel , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 059/167] media: coda: clear error return value before picture run Date: Wed, 22 May 2019 15:26:54 -0400 Message-Id: <20190522192842.25858-59-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190522192842.25858-1-sashal@kernel.org> References: <20190522192842.25858-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philipp Zabel [ Upstream commit bbeefa7357a648afe70e7183914c87c3878d528d ] The error return value is not written by some firmware codecs, such as MPEG-2 decode on CodaHx4. Clear the error return value before starting the picture run to avoid misinterpreting unrelated values returned by sequence initialization as error return value. Signed-off-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-bit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index 3457a5f1c8a8e..6eee55430d46a 100644 --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -1948,6 +1948,9 @@ static int coda_prepare_decode(struct coda_ctx *ctx) /* Clear decode success flag */ coda_write(dev, 0, CODA_RET_DEC_PIC_SUCCESS); + /* Clear error return value */ + coda_write(dev, 0, CODA_RET_DEC_PIC_ERR_MB); + trace_coda_dec_pic_run(ctx, meta); coda_command_async(ctx, CODA_COMMAND_PIC_RUN); -- 2.20.1