From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DF2C282CE for ; Wed, 22 May 2019 21:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F8E720821 for ; Wed, 22 May 2019 21:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730273AbfEVVWK (ORCPT ); Wed, 22 May 2019 17:22:10 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36691 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729483AbfEVVWK (ORCPT ); Wed, 22 May 2019 17:22:10 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 31D918027F; Wed, 22 May 2019 23:21:58 +0200 (CEST) Date: Wed, 22 May 2019 23:22:07 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, broonie@kernel.org, lgirdwood@gmail.com, lee.jones@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v4 1/6] regulator: lm363x: Make the gpio register enable flexible Message-ID: <20190522212207.GA28132@amd> References: <20190522192733.13422-1-dmurphy@ti.com> <20190522192733.13422-2-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <20190522192733.13422-2-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --opJtzjQTFsWo+cga Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-05-22 14:27:28, Dan Murphy wrote: > The use of and enablement of the GPIO can be used across devices. > Use the enable_reg in the regulator descriptor for the register to > write. >=20 > Signed-off-by: Dan Murphy Acked-by: Pavel Machek > --- > drivers/regulator/lm363x-regulator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm3= 63x-regulator.c > index c876e161052a..382b1cecdd93 100644 > --- a/drivers/regulator/lm363x-regulator.c > +++ b/drivers/regulator/lm363x-regulator.c > @@ -263,8 +263,8 @@ static int lm363x_regulator_probe(struct platform_dev= ice *pdev) > =20 > if (gpiod) { > cfg.ena_gpiod =3D gpiod; > - > - ret =3D regmap_update_bits(regmap, LM3632_REG_BIAS_CONFIG, > + ret =3D regmap_update_bits(regmap, > + lm363x_regulator_desc[id].enable_reg, > LM3632_EXT_EN_MASK, > LM3632_EXT_EN_MASK); > if (ret) { --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --opJtzjQTFsWo+cga Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzlvX8ACgkQMOfwapXb+vLXlgCglEDHe+NKnU6e+otIf6THvT7n tM8An3GAcS5ZJPz9BeGzD1l7Y/uPpw7W =cMZb -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--