LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geordan Neukum <gneukum1@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies
Date: Thu, 23 May 2019 07:36:43 +0200	[thread overview]
Message-ID: <20190523053643.GA14465@kroah.com> (raw)
In-Reply-To: <CA+T6rvEXCBukwmFS-Z4DFNoFBv9OToWwAYA2AXWBVa5mUG10zA@mail.gmail.com>

On Thu, May 23, 2019 at 01:35:02AM +0000, Geordan Neukum wrote:
> On Wed, May 22, 2019 at 12:27 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > depends on is better than select.  There's a change to depend on UIO for
> > this code already in my -linus branch which will show up in Linus's tree
> > in a week or so.
> 
> Noted on both accounts. Thanks for the feedback and sorry for the
> inconvenience on the latter.
> 
> > Are you sure we need MFD_CORE as well for this code?
> 
> I noticed the build issue when working locally. I was doing
> something along the lines of: 'make distclean && make x86_64_defconfig',
> selecting 'CONFIG_KPC2000' and 'CONFIG_UIO' via menuconfig, then
> running a good old 'make'. From make, I received an error along the
> lines of:
> 
> ERROR: "mfd_remove_devices"
> [drivers/staging/kpc2000/kpc2000/kpc2000.ko] undefined!
> ERROR: "mfd_add_devices" [drivers/staging/kpc2000/kpc2000/kpc2000.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1
> make: *** [Makefile:1290: modules] Error 2
> 
> which appears to indicate that those two symbols are undefined. When
> I looked, it appeared that those symbols were exported from the
> mfd-core which is why I also threw in a select for that Kconfig
> symbol. Assuming that I didn't do something silly above, I'd be happy
> to submit a new patch (with only a depends on for MFD_CORE) as I
> continue trying to fix up the i2c driver.

Yes, a depends for MFD_CORE would be good, can you base it against my
staging-linus branch so that fix can go to Linus for this release?

thanks,

greg k-h

  reply	other threads:[~2019-05-23  5:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 12:13 [PATCH 0/6] Minor updates to kpc_i2c driver and kpc2000 core Geordan Neukum
2019-05-22 12:13 ` [PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies Geordan Neukum
2019-05-22 12:27   ` Greg Kroah-Hartman
2019-05-23  1:35     ` Geordan Neukum
2019-05-23  5:36       ` Greg Kroah-Hartman [this message]
2019-05-24  2:36         ` [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000' Geordan Neukum
2019-05-24  3:02           ` Geordan Neukum
2019-05-24  6:50             ` Greg Kroah-Hartman
2019-05-22 12:13 ` [PATCH 2/6] staging: kpc2000: kpc_i2c: remove unused module param disable_features Geordan Neukum
2019-05-22 12:13 ` [PATCH 3/6] staging: kpc2000: kpc_i2c: newline fixups to meet linux style guide Geordan Neukum
2019-05-22 12:46   ` Greg Kroah-Hartman
2019-05-22 12:14 ` [PATCH 4/6] staging: kpc2000: kpc_i2c: use <linux/io.h> instead of <asm/io.h> Geordan Neukum
2019-05-22 12:14 ` [PATCH 5/6] staging: kpc2000: kpc_i2c: Remove unnecessary function tracing prints Geordan Neukum
2019-05-22 12:14 ` [PATCH 6/6] staging: kpc2000: kpc_i2c: add static qual to local symbols in kpc_i2c.c Geordan Neukum
2019-05-22 12:28 ` [PATCH 0/6] Minor updates to kpc_i2c driver and kpc2000 core Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523053643.GA14465@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gneukum1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/6] staging: kpc2000: make kconfig symbol '\''KPC2000'\'' select dependencies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).