LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] arm/sha512 - Make sha512_arm_final static
@ 2019-05-12  9:05 YueHaibing
  2019-05-23  6:51 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-05-12  9:05 UTC (permalink / raw)
  To: herbert
  Cc: linux-kernel, linux-crypto, linux-arm-kernel, davem, linux, YueHaibing

Fix sparse warning:

arch/arm/crypto/sha512-glue.c:40:5: warning:
 symbol 'sha512_arm_final' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/arm/crypto/sha512-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/crypto/sha512-glue.c b/arch/arm/crypto/sha512-glue.c
index 86540cd..23fc381 100644
--- a/arch/arm/crypto/sha512-glue.c
+++ b/arch/arm/crypto/sha512-glue.c
@@ -37,7 +37,7 @@ int sha512_arm_update(struct shash_desc *desc, const u8 *data,
 		(sha512_block_fn *)sha512_block_data_order);
 }
 
-int sha512_arm_final(struct shash_desc *desc, u8 *out)
+static int sha512_arm_final(struct shash_desc *desc, u8 *out)
 {
 	sha512_base_do_finalize(desc,
 		(sha512_block_fn *)sha512_block_data_order);
-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] arm/sha512 - Make sha512_arm_final static
  2019-05-12  9:05 [PATCH -next] arm/sha512 - Make sha512_arm_final static YueHaibing
@ 2019-05-23  6:51 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-05-23  6:51 UTC (permalink / raw)
  To: YueHaibing; +Cc: linux-kernel, linux-crypto, linux-arm-kernel, davem, linux

On Sun, May 12, 2019 at 05:05:40PM +0800, YueHaibing wrote:
> Fix sparse warning:
> 
> arch/arm/crypto/sha512-glue.c:40:5: warning:
>  symbol 'sha512_arm_final' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  arch/arm/crypto/sha512-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-23  6:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-12  9:05 [PATCH -next] arm/sha512 - Make sha512_arm_final static YueHaibing
2019-05-23  6:51 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).