Re: [PATCH 3/6] drm/bridge: extract some Analogix I2C DP common code

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Thu, May 23, 2019 at 03:40:25PM +0800, Chen-Yu Tsai wrote:
> On Thu, May 23, 2019 at 2:54 PM Torsten Duwe <duwe@lst.de> wrote:
> >
> > From: Icenowy Zheng <icenowy@aosc.io>
> >
> > Some code can be shared within different DP bridges by Analogix.
> >
> > Extract them to a new module.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > Signed-off-by: Torsten Duwe <duwe@suse.de>
> > ---
> >  drivers/gpu/drm/bridge/analogix/Kconfig            |   4 +
> >  drivers/gpu/drm/bridge/analogix/Makefile           |   2 +
> >  drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 146 +-----------------
> >  .../gpu/drm/bridge/analogix/analogix-i2c-dptx.c    | 169 +++++++++++++++++++++
> >  .../gpu/drm/bridge/analogix/analogix-i2c-dptx.h    |   2 +
> >  5 files changed, 178 insertions(+), 145 deletions(-)
> >  create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
> >
> 
> ...
> 
> >  static int anx78xx_set_hpd(struct anx78xx *anx78xx)
> > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c b/drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
> > new file mode 100644
> > index 000000000000..9cb30962032e
> > --- /dev/null
> > +++ b/drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
> > @@ -0,0 +1,169 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright(c) 2017 Icenowy Zheng <icenowy@aosc.io>
> > + *
> > + * Based on analogix-anx78xx.c, which is:
> > + *   Copyright(c) 2016, Analogix Semiconductor. All rights reserved.
> 
> If this was simple code movement, then the original copyright still applies.
> A different copyright notice should not be used. I suppose the same applies
> to the module author.

And likely to patch 2/6 too.

-- 
Regards,

Laurent Pinchart