LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCHv2] arm64: dts: ls1028a: add flexspi nodes
@ 2019-05-15 11:09 Xiaowei Bao
  2019-05-23  8:00 ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Xiaowei Bao @ 2019-05-15 11:09 UTC (permalink / raw)
  To: shawnguo, Leo Li, robh+dt, mark.rutland, linux-arm-kernel,
	devicetree, linux-kernel
  Cc: Xiaowei Bao

From: Xiaowei Bao <xiaowei.bao@nxp.com>

Add fspi node property for LS1028A SoC for FlexSPI driver.
Property added for the FlexSPI controller and for the connected
slave device for the LS1028ARDB and LS1028AQDS target.
This is having one SPI-NOR flash device, mt35xu02g connected at
CS0.

Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
---
v2:
 - modify the commit message and the dts format.

 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts |   15 +++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts |   15 +++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi    |   12 ++++++++++++
 3 files changed, 42 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index 5bcd491..6e12806 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -158,6 +158,21 @@
 	};
 };
 
+&fspi {
+	status = "okay";
+	mt35xu02g: flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <20000000>;
+		reg = <0>;
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
+		spi-tx-bus-width = <1>; /* 1 SPI Tx line */
+	};
+};
+
 &sai1 {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index 25d2370..5d39616 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -136,6 +136,21 @@
 	};
 };
 
+&fspi {
+	status = "okay";
+	mt35xu02g: flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <20000000>;
+		reg = <0>;
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
+		spi-tx-bus-width = <1>; /* 1 SPI Tx line */
+	};
+};
+
 &duart0 {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index ba71a33..a27cd60 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -109,6 +109,18 @@
 		};
 	};
 
+	fspi: spi@20c0000 {
+		compatible = "nxp,lx2160a-fspi", "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x0 0x20c0000 0x0 0x10000>,
+		    <0x0 0x20000000 0x0 0x10000000>;
+		reg-names = "FSPI", "FSPI-memory";
+		interrupts = <0 25 0x4>; /* Level high type */
+		clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+		clock-names = "fspi_en", "fspi";
+	};
+
 	soc: soc {
 		compatible = "simple-bus";
 		#address-cells = <2>;
-- 
1.7.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv2] arm64: dts: ls1028a: add flexspi nodes
  2019-05-15 11:09 [PATCHv2] arm64: dts: ls1028a: add flexspi nodes Xiaowei Bao
@ 2019-05-23  8:00 ` Shawn Guo
  2019-05-23  8:06   ` [EXT] " Xiaowei Bao
  0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2019-05-23  8:00 UTC (permalink / raw)
  To: Xiaowei Bao
  Cc: Leo Li, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
	linux-kernel

On Wed, May 15, 2019 at 11:09:25AM +0000, Xiaowei Bao wrote:
> From: Xiaowei Bao <xiaowei.bao@nxp.com>
> 
> Add fspi node property for LS1028A SoC for FlexSPI driver.
> Property added for the FlexSPI controller and for the connected
> slave device for the LS1028ARDB and LS1028AQDS target.
> This is having one SPI-NOR flash device, mt35xu02g connected at
> CS0.
> 
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> ---
> v2:
>  - modify the commit message and the dts format.
> 
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts |   15 +++++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts |   15 +++++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi    |   12 ++++++++++++
>  3 files changed, 42 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 5bcd491..6e12806 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -158,6 +158,21 @@
>  	};
>  };
>  
> +&fspi {

Keep the labeling node sort alphabetically.  That said, &fspi should be
added before &i2c0.

> +	status = "okay";

Please have newline between property and child node.

> +	mt35xu02g: flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "spansion,m25p80";

Please start properties with compatible.

> +		m25p,fast-read;
> +		spi-max-frequency = <20000000>;
> +		reg = <0>;
> +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> +		spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
> +		spi-tx-bus-width = <1>; /* 1 SPI Tx line */
> +	};
> +};
> +
>  &sai1 {
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 25d2370..5d39616 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -136,6 +136,21 @@
>  	};
>  };
>  
> +&fspi {
> +	status = "okay";
> +	mt35xu02g: flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "spansion,m25p80";
> +		m25p,fast-read;
> +		spi-max-frequency = <20000000>;
> +		reg = <0>;
> +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> +		spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
> +		spi-tx-bus-width = <1>; /* 1 SPI Tx line */
> +	};
> +};
> +
>  &duart0 {
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index ba71a33..a27cd60 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -109,6 +109,18 @@
>  		};
>  	};
>  
> +	fspi: spi@20c0000 {

Are you sure you want to add this device node outside of 'soc' node?

> +		compatible = "nxp,lx2160a-fspi", "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x0 0x20c0000 0x0 0x10000>,
> +		    <0x0 0x20000000 0x0 0x10000000>;

Fix the indentation to git it aligned with above '<'.

> +		reg-names = "FSPI", "FSPI-memory";
> +		interrupts = <0 25 0x4>; /* Level high type */

interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;

Shawn

> +		clocks = <&clockgen 4 3>, <&clockgen 4 3>;
> +		clock-names = "fspi_en", "fspi";
> +	};
> +
>  	soc: soc {
>  		compatible = "simple-bus";
>  		#address-cells = <2>;
> -- 
> 1.7.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [EXT] Re: [PATCHv2] arm64: dts: ls1028a: add flexspi nodes
  2019-05-23  8:00 ` Shawn Guo
@ 2019-05-23  8:06   ` Xiaowei Bao
  2019-05-23  8:15     ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Xiaowei Bao @ 2019-05-23  8:06 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Leo Li, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
	linux-kernel

Hi Shawn,

-----Original Message-----
From: Shawn Guo <shawnguo@kernel.org> 
Sent: 2019年5月23日 16:01
To: Xiaowei Bao <xiaowei.bao@nxp.com>
Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [EXT] Re: [PATCHv2] arm64: dts: ls1028a: add flexspi nodes

Caution: EXT Email

On Wed, May 15, 2019 at 11:09:25AM +0000, Xiaowei Bao wrote:
> From: Xiaowei Bao <xiaowei.bao@nxp.com>
>
> Add fspi node property for LS1028A SoC for FlexSPI driver.
> Property added for the FlexSPI controller and for the connected slave 
> device for the LS1028ARDB and LS1028AQDS target.
> This is having one SPI-NOR flash device, mt35xu02g connected at CS0.
>
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> ---
> v2:
>  - modify the commit message and the dts format.
>
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts |   15 +++++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts |   15 +++++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi    |   12 ++++++++++++
>  3 files changed, 42 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 5bcd491..6e12806 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -158,6 +158,21 @@
>       };
>  };
>
> +&fspi {

Keep the labeling node sort alphabetically.  That said, &fspi should be added before &i2c0.

> +     status = "okay";

Please have newline between property and child node.

> +     mt35xu02g: flash@0 {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             compatible = "spansion,m25p80";

Please start properties with compatible.
[Xiaowei Bao] I have submit the v3 patch to fix this issue.

> +             m25p,fast-read;
> +             spi-max-frequency = <20000000>;
> +             reg = <0>;
> +             /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> +             spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
> +             spi-tx-bus-width = <1>; /* 1 SPI Tx line */
> +     };
> +};
> +
>  &sai1 {
>       status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 25d2370..5d39616 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -136,6 +136,21 @@
>       };
>  };
>
> +&fspi {
> +     status = "okay";
> +     mt35xu02g: flash@0 {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             compatible = "spansion,m25p80";
> +             m25p,fast-read;
> +             spi-max-frequency = <20000000>;
> +             reg = <0>;
> +             /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> +             spi-rx-bus-width = <8>; /* 8 SPI Rx lines */
> +             spi-tx-bus-width = <1>; /* 1 SPI Tx line */
> +     };
> +};
> +
>  &duart0 {
>       status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index ba71a33..a27cd60 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -109,6 +109,18 @@
>               };
>       };
>
> +     fspi: spi@20c0000 {

Are you sure you want to add this device node outside of 'soc' node?

> +             compatible = "nxp,lx2160a-fspi", "simple-bus";
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +             reg = <0x0 0x20c0000 0x0 0x10000>,
> +                 <0x0 0x20000000 0x0 0x10000000>;

Fix the indentation to git it aligned with above '<'.
[Xiaowei Bao] this is aligned, I don't know why it is not aligned in email. Thanks.

> +             reg-names = "FSPI", "FSPI-memory";
> +             interrupts = <0 25 0x4>; /* Level high type */

interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;

Shawn

> +             clocks = <&clockgen 4 3>, <&clockgen 4 3>;
> +             clock-names = "fspi_en", "fspi";
> +     };
> +
>       soc: soc {
>               compatible = "simple-bus";
>               #address-cells = <2>;
> --
> 1.7.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [EXT] Re: [PATCHv2] arm64: dts: ls1028a: add flexspi nodes
  2019-05-23  8:06   ` [EXT] " Xiaowei Bao
@ 2019-05-23  8:15     ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-05-23  8:15 UTC (permalink / raw)
  To: Xiaowei Bao
  Cc: Leo Li, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
	linux-kernel

On Thu, May 23, 2019 at 08:06:42AM +0000, Xiaowei Bao wrote:
> > +             compatible = "nxp,lx2160a-fspi", "simple-bus";
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +             reg = <0x0 0x20c0000 0x0 0x10000>,
> > +                 <0x0 0x20000000 0x0 0x10000000>;
> 
> Fix the indentation to git it aligned with above '<'.
> [Xiaowei Bao] this is aligned, I don't know why it is not aligned in email. Thanks.

That's fine then.

Shawn

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-23  8:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 11:09 [PATCHv2] arm64: dts: ls1028a: add flexspi nodes Xiaowei Bao
2019-05-23  8:00 ` Shawn Guo
2019-05-23  8:06   ` [EXT] " Xiaowei Bao
2019-05-23  8:15     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).