LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH] staging: fieldbus: anybuss: Remove variable
       [not found] <20190523070531.13510-1-nishka.dasgupta@yahoo.com>
@ 2019-05-23  7:22 ` Greg KH
       [not found]   ` <4a3d571f-5987-6735-be56-7976457d0797@yahoo.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Greg KH @ 2019-05-23  7:22 UTC (permalink / raw)
  To: Nishka Dasgupta; +Cc: devel, linux-kernel

On Thu, May 23, 2019 at 12:35:26PM +0530, Nishka Dasgupta wrote:
> Variable client, assigned to priv->client, is used only once in a
> function argument; hence, it can be removed and the function argument
> replaced with priv->client directly.
> Issue found with Coccinelle.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/fieldbus/anybuss/hms-profinet.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fieldbus/anybuss/hms-profinet.c b/drivers/staging/fieldbus/anybuss/hms-profinet.c
> index 5446843e35f4..a7f85912fa92 100644
> --- a/drivers/staging/fieldbus/anybuss/hms-profinet.c
> +++ b/drivers/staging/fieldbus/anybuss/hms-profinet.c
> @@ -124,9 +124,7 @@ static int __profi_enable(struct profi_priv *priv)
>  
>  static int __profi_disable(struct profi_priv *priv)
>  {
> -	struct anybuss_client *client = priv->client;
> -
> -	anybuss_set_power(client, false);
> +	anybuss_set_power(priv->client, false);

Same comments are relevant here as the last patch you sent.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: fieldbus: anybuss: Remove variable
       [not found]   ` <4a3d571f-5987-6735-be56-7976457d0797@yahoo.com>
@ 2019-05-23  8:43     ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-05-23  8:43 UTC (permalink / raw)
  To: Nishka Dasgupta; +Cc: devel, linux-kernel

On Thu, May 23, 2019 at 01:52:29PM +0530, Nishka Dasgupta wrote:
> 
> 
> On 23/05/19 12:52 PM, Greg KH wrote:
> > On Thu, May 23, 2019 at 12:35:26PM +0530, Nishka Dasgupta wrote:
> > > Variable client, assigned to priv->client, is used only once in a
> > > function argument; hence, it can be removed and the function argument
> > > replaced with priv->client directly.
> > > Issue found with Coccinelle.
> > > 
> > > Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> > > ---
> > >   drivers/staging/fieldbus/anybuss/hms-profinet.c | 4 +---
> > >   1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/fieldbus/anybuss/hms-profinet.c b/drivers/staging/fieldbus/anybuss/hms-profinet.c
> > > index 5446843e35f4..a7f85912fa92 100644
> > > --- a/drivers/staging/fieldbus/anybuss/hms-profinet.c
> > > +++ b/drivers/staging/fieldbus/anybuss/hms-profinet.c
> > > @@ -124,9 +124,7 @@ static int __profi_enable(struct profi_priv *priv)
> > >   static int __profi_disable(struct profi_priv *priv)
> > >   {
> > > -	struct anybuss_client *client = priv->client;
> > > -
> > > -	anybuss_set_power(client, false);
> > > +	anybuss_set_power(priv->client, false);
> > 
> > Same comments are relevant here as the last patch you sent.
> 
> So just to clarify this patch isn't necessary and I should cc Sven?

For future patches to any drivers/staging/fieldbus/ changes, yes.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-23  8:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190523070531.13510-1-nishka.dasgupta@yahoo.com>
2019-05-23  7:22 ` [PATCH] staging: fieldbus: anybuss: Remove variable Greg KH
     [not found]   ` <4a3d571f-5987-6735-be56-7976457d0797@yahoo.com>
2019-05-23  8:43     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).