LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/3] tty: drop unused iflag macro
@ 2019-04-26  5:59 Johan Hovold
  2019-04-26  5:59 ` [PATCH 1/3] tty: simserial: " Johan Hovold
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Johan Hovold @ 2019-04-26  5:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Tony Luck, Fenghua Yu, Samuel Iglesias Gonsalvez, Jens Taprogge,
	Jiri Slaby, linux-kernel, Johan Hovold

I noticed that the RELEVANT_IFLAG() macro was unused in USB serial and
turns out there were a few more instances that could be dropped.

I have some pending changes that may conflict with the corresponding
change to USB serial so I'll take that one separately through my tree,
but perhaps the rest could go through Greg's tty tree.

Johan


Johan Hovold (3):
  tty: simserial: drop unused iflag macro
  tty: ipoctal: drop unused iflag macro
  tty: cpm_uart: drop unused iflag macro

 arch/ia64/hp/sim/simserial.c                | 2 --
 drivers/ipack/devices/ipoctal.h             | 1 -
 drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 --
 3 files changed, 5 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] tty: simserial: drop unused iflag macro
  2019-04-26  5:59 [PATCH 0/3] tty: drop unused iflag macro Johan Hovold
@ 2019-04-26  5:59 ` Johan Hovold
  2019-04-26 16:29   ` Luck, Tony
  2019-04-26  5:59 ` [PATCH 2/3] tty: ipoctal: " Johan Hovold
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Johan Hovold @ 2019-04-26  5:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Tony Luck, Fenghua Yu, Samuel Iglesias Gonsalvez, Jens Taprogge,
	Jiri Slaby, linux-kernel, Johan Hovold

Drop the RELEVANT_IFLAG() macro which hasn't been used for over a
decade.

Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 arch/ia64/hp/sim/simserial.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/ia64/hp/sim/simserial.c b/arch/ia64/hp/sim/simserial.c
index 7aeb48a18576..1a338e541334 100644
--- a/arch/ia64/hp/sim/simserial.c
+++ b/arch/ia64/hp/sim/simserial.c
@@ -324,8 +324,6 @@ static int rs_ioctl(struct tty_struct *tty, unsigned int cmd, unsigned long arg)
 	return -ENOIOCTLCMD;
 }
 
-#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
-
 /*
  * This routine will shutdown a serial port; interrupts are disabled, and
  * DTR is dropped if the hangup on close termio flag is on.
-- 
2.21.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/3] tty: ipoctal: drop unused iflag macro
  2019-04-26  5:59 [PATCH 0/3] tty: drop unused iflag macro Johan Hovold
  2019-04-26  5:59 ` [PATCH 1/3] tty: simserial: " Johan Hovold
@ 2019-04-26  5:59 ` Johan Hovold
  2019-04-26  5:59 ` [PATCH 3/3] tty: cpm_uart: " Johan Hovold
  2019-05-23  9:21 ` [PATCH 0/3] tty: " Johan Hovold
  3 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2019-04-26  5:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Tony Luck, Fenghua Yu, Samuel Iglesias Gonsalvez, Jens Taprogge,
	Jiri Slaby, linux-kernel, Johan Hovold

Drop the RELEVANT_IFLAG() macro which has never been used.

Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/ipack/devices/ipoctal.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h
index 7fede0eb6a0c..78e4fc81fb03 100644
--- a/drivers/ipack/devices/ipoctal.h
+++ b/drivers/ipack/devices/ipoctal.h
@@ -18,7 +18,6 @@
 #define NR_CHANNELS		8
 #define IPOCTAL_MAX_BOARDS	16
 #define MAX_DEVICES		(NR_CHANNELS * IPOCTAL_MAX_BOARDS)
-#define RELEVANT_IFLAG(iflag) ((iflag) & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
 
 /**
  * struct ipoctal_stats -- Stats since last reset
-- 
2.21.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 3/3] tty: cpm_uart: drop unused iflag macro
  2019-04-26  5:59 [PATCH 0/3] tty: drop unused iflag macro Johan Hovold
  2019-04-26  5:59 ` [PATCH 1/3] tty: simserial: " Johan Hovold
  2019-04-26  5:59 ` [PATCH 2/3] tty: ipoctal: " Johan Hovold
@ 2019-04-26  5:59 ` Johan Hovold
  2019-05-23  9:21 ` [PATCH 0/3] tty: " Johan Hovold
  3 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2019-04-26  5:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Tony Luck, Fenghua Yu, Samuel Iglesias Gonsalvez, Jens Taprogge,
	Jiri Slaby, linux-kernel, Johan Hovold

Drop the RELEVANT_IFLAG() macro which hasn't been used at least since
the dawn of git.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_core.c b/drivers/tty/serial/cpm_uart/cpm_uart_core.c
index b929c7ae3a27..505262b1c6c2 100644
--- a/drivers/tty/serial/cpm_uart/cpm_uart_core.c
+++ b/drivers/tty/serial/cpm_uart/cpm_uart_core.c
@@ -567,8 +567,6 @@ static void cpm_uart_set_termios(struct uart_port *port,
 	/*
 	 * Set up parity check flag
 	 */
-#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
-
 	port->read_status_mask = (BD_SC_EMPTY | BD_SC_OV);
 	if (termios->c_iflag & INPCK)
 		port->read_status_mask |= BD_SC_FR | BD_SC_PR;
-- 
2.21.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PATCH 1/3] tty: simserial: drop unused iflag macro
  2019-04-26  5:59 ` [PATCH 1/3] tty: simserial: " Johan Hovold
@ 2019-04-26 16:29   ` Luck, Tony
  0 siblings, 0 replies; 8+ messages in thread
From: Luck, Tony @ 2019-04-26 16:29 UTC (permalink / raw)
  To: Johan Hovold, Greg Kroah-Hartman
  Cc: Yu, Fenghua, Samuel Iglesias Gonsalvez, Jens Taprogge,
	Jiri Slaby, linux-kernel

> Drop the RELEVANT_IFLAG() macro which hasn't been used for over a
> decade.
>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  arch/ia64/hp/sim/simserial.c | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Tony Luck <tony.luck@intel.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] tty: drop unused iflag macro
  2019-04-26  5:59 [PATCH 0/3] tty: drop unused iflag macro Johan Hovold
                   ` (2 preceding siblings ...)
  2019-04-26  5:59 ` [PATCH 3/3] tty: cpm_uart: " Johan Hovold
@ 2019-05-23  9:21 ` Johan Hovold
  2019-05-23  9:31   ` Greg Kroah-Hartman
  3 siblings, 1 reply; 8+ messages in thread
From: Johan Hovold @ 2019-05-23  9:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Tony Luck, Fenghua Yu, Samuel Iglesias Gonsalvez, Jens Taprogge,
	Jiri Slaby, linux-kernel, Johan Hovold

On Fri, Apr 26, 2019 at 07:59:22AM +0200, Johan Hovold wrote:
> I noticed that the RELEVANT_IFLAG() macro was unused in USB serial and
> turns out there were a few more instances that could be dropped.
> 
> I have some pending changes that may conflict with the corresponding
> change to USB serial so I'll take that one separately through my tree,
> but perhaps the rest could go through Greg's tty tree.

> Johan Hovold (3):
>   tty: simserial: drop unused iflag macro
>   tty: ipoctal: drop unused iflag macro
>   tty: cpm_uart: drop unused iflag macro
> 
>  arch/ia64/hp/sim/simserial.c                | 2 --
>  drivers/ipack/devices/ipoctal.h             | 1 -
>  drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 --
>  3 files changed, 5 deletions(-)

Greg, do you still have these clean-ups in your queue? Want me to resend
with Tony's ack?

Johan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] tty: drop unused iflag macro
  2019-05-23  9:21 ` [PATCH 0/3] tty: " Johan Hovold
@ 2019-05-23  9:31   ` Greg Kroah-Hartman
  2019-05-23 10:39     ` Johan Hovold
  0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-23  9:31 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Tony Luck, Fenghua Yu, Samuel Iglesias Gonsalvez, Jens Taprogge,
	Jiri Slaby, linux-kernel

On Thu, May 23, 2019 at 11:21:27AM +0200, Johan Hovold wrote:
> On Fri, Apr 26, 2019 at 07:59:22AM +0200, Johan Hovold wrote:
> > I noticed that the RELEVANT_IFLAG() macro was unused in USB serial and
> > turns out there were a few more instances that could be dropped.
> > 
> > I have some pending changes that may conflict with the corresponding
> > change to USB serial so I'll take that one separately through my tree,
> > but perhaps the rest could go through Greg's tty tree.
> 
> > Johan Hovold (3):
> >   tty: simserial: drop unused iflag macro
> >   tty: ipoctal: drop unused iflag macro
> >   tty: cpm_uart: drop unused iflag macro
> > 
> >  arch/ia64/hp/sim/simserial.c                | 2 --
> >  drivers/ipack/devices/ipoctal.h             | 1 -
> >  drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 --
> >  3 files changed, 5 deletions(-)
> 
> Greg, do you still have these clean-ups in your queue? Want me to resend
> with Tony's ack?

They are still in my to-review queue.  Let me dig out from some more
stable patches before I tackle the tty/serial stuff later today or
tomorrow.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] tty: drop unused iflag macro
  2019-05-23  9:31   ` Greg Kroah-Hartman
@ 2019-05-23 10:39     ` Johan Hovold
  0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2019-05-23 10:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Johan Hovold, Tony Luck, Fenghua Yu, Samuel Iglesias Gonsalvez,
	Jens Taprogge, Jiri Slaby, linux-kernel

On Thu, May 23, 2019 at 11:31:09AM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 23, 2019 at 11:21:27AM +0200, Johan Hovold wrote:
> > On Fri, Apr 26, 2019 at 07:59:22AM +0200, Johan Hovold wrote:
> > > I noticed that the RELEVANT_IFLAG() macro was unused in USB serial and
> > > turns out there were a few more instances that could be dropped.
> > > 
> > > I have some pending changes that may conflict with the corresponding
> > > change to USB serial so I'll take that one separately through my tree,
> > > but perhaps the rest could go through Greg's tty tree.
> > 
> > > Johan Hovold (3):
> > >   tty: simserial: drop unused iflag macro
> > >   tty: ipoctal: drop unused iflag macro
> > >   tty: cpm_uart: drop unused iflag macro
> > > 
> > >  arch/ia64/hp/sim/simserial.c                | 2 --
> > >  drivers/ipack/devices/ipoctal.h             | 1 -
> > >  drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 --
> > >  3 files changed, 5 deletions(-)
> > 
> > Greg, do you still have these clean-ups in your queue? Want me to resend
> > with Tony's ack?
> 
> They are still in my to-review queue.  Let me dig out from some more
> stable patches before I tackle the tty/serial stuff later today or
> tomorrow.

No rush. Just saw you applying some tty patches the other day so figured
I'd ask. Thanks.

Johan

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-05-23 10:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26  5:59 [PATCH 0/3] tty: drop unused iflag macro Johan Hovold
2019-04-26  5:59 ` [PATCH 1/3] tty: simserial: " Johan Hovold
2019-04-26 16:29   ` Luck, Tony
2019-04-26  5:59 ` [PATCH 2/3] tty: ipoctal: " Johan Hovold
2019-04-26  5:59 ` [PATCH 3/3] tty: cpm_uart: " Johan Hovold
2019-05-23  9:21 ` [PATCH 0/3] tty: " Johan Hovold
2019-05-23  9:31   ` Greg Kroah-Hartman
2019-05-23 10:39     ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).