LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: simon@nikanor.nu, jeremy@azazel.net, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/8] staging: kpc2000: add blank line after declarations
Date: Thu, 23 May 2019 13:36:06 +0200 [thread overview]
Message-ID: <20190523113613.28342-2-simon@nikanor.nu> (raw)
In-Reply-To: <20190523113613.28342-1-simon@nikanor.nu>
Fixes checkpatch.pl warning "Missing a blank line after declarations".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
index e5cddf0eeed3..95bfbe4aae4d 100644
--- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
+++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
@@ -245,6 +245,7 @@ int kp2000_check_uio_irq(struct kp2000_device *pcard, u32 irq_num)
u64 interrupt_active = readq(pcard->sysinfo_regs_base + REG_INTERRUPT_ACTIVE);
u64 interrupt_mask_inv = ~readq(pcard->sysinfo_regs_base + REG_INTERRUPT_MASK);
u64 irq_check_mask = (1 << irq_num);
+
if (interrupt_active & irq_check_mask) { // if it's active (interrupt pending)
if (interrupt_mask_inv & irq_check_mask) { // and if it's not masked off
return 1;
@@ -257,6 +258,7 @@ static
irqreturn_t kuio_handler(int irq, struct uio_info *uioinfo)
{
struct kpc_uio_device *kudev = uioinfo->priv;
+
if (irq != kudev->pcard->pdev->irq)
return IRQ_NONE;
@@ -506,8 +508,10 @@ void kp2000_remove_cores(struct kp2000_device *pcard)
{
struct list_head *ptr;
struct list_head *next;
+
list_for_each_safe(ptr, next, &pcard->uio_devices_list) {
struct kpc_uio_device *kudev = list_entry(ptr, struct kpc_uio_device, list);
+
uio_unregister_device(&kudev->uioinfo);
device_unregister(kudev->dev);
list_del(&kudev->list);
--
2.20.1
next prev parent reply other threads:[~2019-05-23 11:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 11:36 [PATCH 0/8] Fix more coding style issues in staging/kpc2000 Simon Sandström
2019-05-23 11:36 ` Simon Sandström [this message]
2019-05-23 11:36 ` [PATCH 2/8] staging: kpc2000: use __func__ in debug messages Simon Sandström
2019-05-23 11:55 ` Greg KH
2019-05-23 12:09 ` Simon Sandström
2019-05-23 12:26 ` Greg KH
2019-05-23 11:36 ` [PATCH 3/8] staging: kpc2000: add missing asterisk in comment Simon Sandström
2019-05-23 11:36 ` [PATCH 4/8] staging: kpc2000: fix alignment issues in cell_probe.c Simon Sandström
2019-05-23 11:36 ` [PATCH 5/8] staging: kpc2000: remove extra blank lines " Simon Sandström
2019-05-23 11:36 ` [PATCH 6/8] staging: kpc2000: use kzalloc(sizeof(var)...) " Simon Sandström
2019-05-23 11:36 ` [PATCH 7/8] staging: kpc2000: remove unnecessary braces " Simon Sandström
2019-05-23 11:36 ` [PATCH 8/8] staging: kpc2000: remove unnecessary include " Simon Sandström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523113613.28342-2-simon@nikanor.nu \
--to=simon@nikanor.nu \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy@azazel.net \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH 1/8] staging: kpc2000: add blank line after declarations' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).