LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: simon@nikanor.nu, jeremy@azazel.net, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages
Date: Thu, 23 May 2019 13:36:07 +0200 [thread overview]
Message-ID: <20190523113613.28342-3-simon@nikanor.nu> (raw)
In-Reply-To: <20190523113613.28342-1-simon@nikanor.nu>
Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using
'<function name>', this function's name, in a string".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +++++++++++++-------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
index 95bfbe4aae4d..7b850f3e808b 100644
--- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
+++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
@@ -299,7 +299,8 @@ static int probe_core_uio(unsigned int core_num, struct kp2000_device *pcard,
kudev = kzalloc(sizeof(struct kpc_uio_device), GFP_KERNEL);
if (!kudev) {
- dev_err(&pcard->pdev->dev, "probe_core_uio: failed to kzalloc kpc_uio_device\n");
+ dev_err(&pcard->pdev->dev, "%s: failed to kzalloc kpc_uio_device\n",
+ __func__);
return -ENOMEM;
}
@@ -327,7 +328,8 @@ static int probe_core_uio(unsigned int core_num, struct kp2000_device *pcard,
kudev->dev = device_create(kpc_uio_class, &pcard->pdev->dev, MKDEV(0, 0), kudev, "%s.%d.%d.%d", kudev->uioinfo.name, pcard->card_num, cte.type, kudev->core_num);
if (IS_ERR(kudev->dev)) {
- dev_err(&pcard->pdev->dev, "probe_core_uio device_create failed!\n");
+ dev_err(&pcard->pdev->dev, "%s: device_create failed!\n",
+ __func__);
kfree(kudev);
return -ENODEV;
}
@@ -335,7 +337,8 @@ static int probe_core_uio(unsigned int core_num, struct kp2000_device *pcard,
rv = uio_register_device(kudev->dev, &kudev->uioinfo);
if (rv) {
- dev_err(&pcard->pdev->dev, "probe_core_uio failed uio_register_device: %d\n", rv);
+ dev_err(&pcard->pdev->dev, "%s: failed uio_register_device: %d\n",
+ __func__, rv);
put_device(kudev->dev);
kfree(kudev);
return rv;
@@ -410,7 +413,8 @@ static int kp2000_setup_dma_controller(struct kp2000_device *pcard)
return 0;
err_out:
- dev_err(&pcard->pdev->dev, "kp2000_setup_dma_controller: failed to add a DMA Engine: %d\n", err);
+ dev_err(&pcard->pdev->dev, "%s: failed to add a DMA Engine: %d\n",
+ __func__, err);
return err;
}
@@ -423,7 +427,8 @@ int kp2000_probe_cores(struct kp2000_device *pcard)
unsigned int highest_core_id = 0;
struct core_table_entry cte;
- dev_dbg(&pcard->pdev->dev, "kp2000_probe_cores(pcard = %p / %d)\n", pcard, pcard->card_num);
+ dev_dbg(&pcard->pdev->dev, "%s(pcard = %p / %d)\n", __func__, pcard,
+ pcard->card_num);
err = kp2000_setup_dma_controller(pcard);
if (err)
@@ -472,8 +477,8 @@ int kp2000_probe_cores(struct kp2000_device *pcard)
}
if (err) {
dev_err(&pcard->pdev->dev,
- "kp2000_probe_cores: failed to add core %d: %d\n",
- i, err);
+ "%s: failed to add core %d: %d\n",
+ __func__, i, err);
goto error;
}
core_num++;
@@ -492,7 +497,8 @@ int kp2000_probe_cores(struct kp2000_device *pcard)
cte.irq_base_num = 0;
err = probe_core_uio(0, pcard, "kpc_uio", cte);
if (err) {
- dev_err(&pcard->pdev->dev, "kp2000_probe_cores: failed to add board_info core: %d\n", err);
+ dev_err(&pcard->pdev->dev, "%s: failed to add board_info core: %d\n",
+ __func__, err);
goto error;
}
--
2.20.1
next prev parent reply other threads:[~2019-05-23 11:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 11:36 [PATCH 0/8] Fix more coding style issues in staging/kpc2000 Simon Sandström
2019-05-23 11:36 ` [PATCH 1/8] staging: kpc2000: add blank line after declarations Simon Sandström
2019-05-23 11:36 ` Simon Sandström [this message]
2019-05-23 11:55 ` [PATCH 2/8] staging: kpc2000: use __func__ in debug messages Greg KH
2019-05-23 12:09 ` Simon Sandström
2019-05-23 12:26 ` Greg KH
2019-05-23 11:36 ` [PATCH 3/8] staging: kpc2000: add missing asterisk in comment Simon Sandström
2019-05-23 11:36 ` [PATCH 4/8] staging: kpc2000: fix alignment issues in cell_probe.c Simon Sandström
2019-05-23 11:36 ` [PATCH 5/8] staging: kpc2000: remove extra blank lines " Simon Sandström
2019-05-23 11:36 ` [PATCH 6/8] staging: kpc2000: use kzalloc(sizeof(var)...) " Simon Sandström
2019-05-23 11:36 ` [PATCH 7/8] staging: kpc2000: remove unnecessary braces " Simon Sandström
2019-05-23 11:36 ` [PATCH 8/8] staging: kpc2000: remove unnecessary include " Simon Sandström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523113613.28342-3-simon@nikanor.nu \
--to=simon@nikanor.nu \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy@azazel.net \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).