LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: simon@nikanor.nu, jeremy@azazel.net, dan.carpenter@oracle.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/8] staging: kpc2000: use kzalloc(sizeof(var)...) in cell_probe.c
Date: Thu, 23 May 2019 13:36:11 +0200	[thread overview]
Message-ID: <20190523113613.28342-7-simon@nikanor.nu> (raw)
In-Reply-To: <20190523113613.28342-1-simon@nikanor.nu>

Fixes checkpatch.pl warning "Prefer kzalloc(sizeof(*kudev)...) over
kzalloc(sizeof(struct kpc_uio_device)...)"

Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
 drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
index 0da41ca17eb7..8d9254db9498 100644
--- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
+++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
@@ -292,7 +292,7 @@ static int probe_core_uio(unsigned int core_num, struct kp2000_device *pcard,
 
 	dev_dbg(&pcard->pdev->dev, "Found UIO core:   type = %02d  dma = %02x / %02x  offset = 0x%x  length = 0x%x (%d regs)\n", cte.type, KPC_OLD_S2C_DMA_CH_NUM(cte), KPC_OLD_C2S_DMA_CH_NUM(cte), cte.offset, cte.length, cte.length / 8);
 
-	kudev = kzalloc(sizeof(struct kpc_uio_device), GFP_KERNEL);
+	kudev = kzalloc(sizeof(*kudev), GFP_KERNEL);
 	if (!kudev) {
 		dev_err(&pcard->pdev->dev, "%s: failed to kzalloc kpc_uio_device\n",
 			__func__);
-- 
2.20.1


  parent reply	other threads:[~2019-05-23 11:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 11:36 [PATCH 0/8] Fix more coding style issues in staging/kpc2000 Simon Sandström
2019-05-23 11:36 ` [PATCH 1/8] staging: kpc2000: add blank line after declarations Simon Sandström
2019-05-23 11:36 ` [PATCH 2/8] staging: kpc2000: use __func__ in debug messages Simon Sandström
2019-05-23 11:55   ` Greg KH
2019-05-23 12:09     ` Simon Sandström
2019-05-23 12:26       ` Greg KH
2019-05-23 11:36 ` [PATCH 3/8] staging: kpc2000: add missing asterisk in comment Simon Sandström
2019-05-23 11:36 ` [PATCH 4/8] staging: kpc2000: fix alignment issues in cell_probe.c Simon Sandström
2019-05-23 11:36 ` [PATCH 5/8] staging: kpc2000: remove extra blank lines " Simon Sandström
2019-05-23 11:36 ` Simon Sandström [this message]
2019-05-23 11:36 ` [PATCH 7/8] staging: kpc2000: remove unnecessary braces " Simon Sandström
2019-05-23 11:36 ` [PATCH 8/8] staging: kpc2000: remove unnecessary include " Simon Sandström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523113613.28342-7-simon@nikanor.nu \
    --to=simon@nikanor.nu \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeremy@azazel.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 6/8] staging: kpc2000: use kzalloc(sizeof(var)...) in cell_probe.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).