LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] elf: fix "start_code" evaluation
Date: Thu, 23 May 2019 11:44:17 -0700 [thread overview]
Message-ID: <20190523114417.f99d781754ed22950115c64a@linux-foundation.org> (raw)
In-Reply-To: <20190523175736.GA6222@avx2>
On Thu, 23 May 2019 20:57:36 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Only executable ELF program headers should change ->start_code.
>
> ...
>
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -1026,7 +1026,7 @@ static int load_elf_binary(struct linux_binprm *bprm)
> }
> }
> k = elf_ppnt->p_vaddr;
> - if (k < start_code)
> + if ((elf_ppnt->p_flags & PF_X) && k < start_code)
> start_code = k;
> if (start_data < k)
> start_data = k;
What problem does this solve? How does it alter runtime behaviour?
How do we know it won't break anything?
next prev parent reply other threads:[~2019-05-23 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 17:57 Alexey Dobriyan
2019-05-23 18:44 ` Andrew Morton [this message]
2019-05-23 19:35 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523114417.f99d781754ed22950115c64a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] elf: fix "start_code" evaluation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).