LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Esben Haabendal <esben@geanix.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	YueHaibing <yuehaibing@huawei.com>,
	"Petr Štetiar" <ynezz@true.cz>, "Yang Wei" <yang.wei9@zte.com.cn>,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] net: ll_temac: Enable multicast support
Date: Thu, 23 May 2019 14:02:22 +0200	[thread overview]
Message-ID: <20190523120222.3807-5-esben@geanix.com> (raw)
In-Reply-To: <20190523120222.3807-1-esben@geanix.com>

Multicast support have been tested and is working now.

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
 drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 75da604..5d8894d 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -21,7 +21,6 @@
  *
  * TODO:
  * - Factor out locallink DMA code into separate driver
- * - Fix multicast assignment.
  * - Fix support for hardware checksumming.
  * - Testing.  Lots and lots of testing.
  *
@@ -1096,6 +1095,7 @@ static const struct net_device_ops temac_netdev_ops = {
 	.ndo_open = temac_open,
 	.ndo_stop = temac_stop,
 	.ndo_start_xmit = temac_start_xmit,
+	.ndo_set_rx_mode = temac_set_multicast_list,
 	.ndo_set_mac_address = temac_set_mac_address,
 	.ndo_validate_addr = eth_validate_addr,
 	.ndo_do_ioctl = temac_ioctl,
@@ -1161,7 +1161,6 @@ static int temac_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, ndev);
 	SET_NETDEV_DEV(ndev, &pdev->dev);
-	ndev->flags &= ~IFF_MULTICAST;  /* clear multicast */
 	ndev->features = NETIF_F_SG;
 	ndev->netdev_ops = &temac_netdev_ops;
 	ndev->ethtool_ops = &temac_ethtool_ops;
-- 
2.4.11


  parent reply	other threads:[~2019-05-23 12:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 12:02 [PATCH 0/4] net: ll_temac: Fix and enable " Esben Haabendal
2019-05-23 12:02 ` [PATCH 1/4] net: ll_temac: Do not make promiscuous mode sticky on multicast Esben Haabendal
2019-05-23 12:02 ` [PATCH 2/4] net: ll_temac: Prepare indirect register access for multicast support Esben Haabendal
2019-05-23 12:02 ` [PATCH 3/4] net: ll_temac: Cleanup multicast filter on change Esben Haabendal
2019-05-23 12:02 ` Esben Haabendal [this message]
2019-05-23 16:34 ` [PATCH 0/4] net: ll_temac: Fix and enable multicast support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523120222.3807-5-esben@geanix.com \
    --to=esben@geanix.com \
    --cc=andrew@lunn.ch \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=yang.wei9@zte.com.cn \
    --cc=ynezz@true.cz \
    --cc=yuehaibing@huawei.com \
    --subject='Re: [PATCH 4/4] net: ll_temac: Enable multicast support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).