From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21533C282DD for ; Thu, 23 May 2019 12:38:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC6AF21019 for ; Thu, 23 May 2019 12:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730493AbfEWMiS (ORCPT ); Thu, 23 May 2019 08:38:18 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50096 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729762AbfEWMiS (ORCPT ); Thu, 23 May 2019 08:38:18 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hTmzA-0002N7-Jk; Thu, 23 May 2019 20:38:16 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hTmz7-0007Dd-Ln; Thu, 23 May 2019 20:38:13 +0800 Date: Thu, 23 May 2019 20:38:13 +0800 From: Herbert Xu To: Horia Geanta Cc: Iuliana Prodan , Aymen Sghaier , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256) failure because of invalid input Message-ID: <20190523123813.xosynrnsdpqfieqv@gondor.apana.org.au> References: <1557919546-360-1-git-send-email-iuliana.prodan@nxp.com> <20190523061202.ic2vgimgzvvm6dzc@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 10:02:41AM +0000, Horia Geanta wrote: > > When crypto_register_akcipher fails, it merely prints a warning and falls > through (does not immediately return), thus there's no leak. How can this work? Wouldn't the exit path then unregister a bunch of unregistered algorithms and crash? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt