LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: simon@nikanor.nu, jeremy@azazel.net, dan.carpenter@oracle.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 7/9] staging: kpc2000: remove unnecessary braces in cell_probe.c
Date: Thu, 23 May 2019 14:51:41 +0200	[thread overview]
Message-ID: <20190523125143.32511-8-simon@nikanor.nu> (raw)
In-Reply-To: <20190523125143.32511-1-simon@nikanor.nu>

Fixes checkpatch.pl warnings "braces {} are not necessary for single
statement blocks".

Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
 drivers/staging/kpc2000/kpc2000/cell_probe.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
index caf48256aa2e..682d61da5369 100644
--- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
+++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
@@ -273,11 +273,10 @@ int kuio_irqcontrol(struct uio_info *uioinfo, s32 irq_on)
 
 	mutex_lock(&pcard->sem);
 	mask = readq(pcard->sysinfo_regs_base + REG_INTERRUPT_MASK);
-	if (irq_on) {
+	if (irq_on)
 		mask &= ~(1 << (kudev->cte.irq_base_num));
-	} else {
+	else
 		mask |= (1 << (kudev->cte.irq_base_num));
-	}
 	writeq(mask, pcard->sysinfo_regs_base + REG_INTERRUPT_MASK);
 	mutex_unlock(&pcard->sem);
 
@@ -432,12 +431,10 @@ int  kp2000_probe_cores(struct kp2000_device *pcard)
 		read_val = readq(pcard->sysinfo_regs_base + ((pcard->core_table_offset + i) * 8));
 		parse_core_table_entry(&cte, read_val, pcard->core_table_rev);
 		dbg_cte(pcard, &cte);
-		if (cte.type > highest_core_id) {
+		if (cte.type > highest_core_id)
 			highest_core_id = cte.type;
-		}
-		if (cte.type == KP_CORE_ID_INVALID) {
+		if (cte.type == KP_CORE_ID_INVALID)
 			dev_info(&pcard->pdev->dev, "Found Invalid core: %016llx\n", read_val);
-		}
 	}
 	// Then, iterate over the possible core types.
 	for (current_type_id = 1 ; current_type_id <= highest_core_id ; current_type_id++) {
-- 
2.20.1


  parent reply	other threads:[~2019-05-23 12:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 12:51 [PATCH v2 0/9] Fix more coding style issues in staging/kpc2000 Simon Sandström
2019-05-23 12:51 ` [PATCH v2 1/9] staging: kpc2000: add blank line after declarations Simon Sandström
2019-05-23 12:51 ` [PATCH v2 2/9] staging: kpc2000: use __func__ in debug messages Simon Sandström
2019-05-23 12:51 ` [PATCH v2 3/9] staging: kpc2000: add missing asterisk in comment Simon Sandström
2019-05-23 12:51 ` [PATCH v2 4/9] staging: kpc2000: fix alignment issues in cell_probe.c Simon Sandström
2019-05-23 12:51 ` [PATCH v2 5/9] staging: kpc2000: remove extra blank lines " Simon Sandström
2019-05-23 12:51 ` [PATCH v2 6/9] staging: kpc2000: use kzalloc(sizeof(var)...) " Simon Sandström
2019-05-23 12:51 ` Simon Sandström [this message]
2019-05-23 12:51 ` [PATCH v2 8/9] staging: kpc2000: remove unnecessary include " Simon Sandström
2019-05-23 12:51 ` [PATCH v2 9/9] staging: kpc2000: remove unnecessary oom message Simon Sandström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523125143.32511-8-simon@nikanor.nu \
    --to=simon@nikanor.nu \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeremy@azazel.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v2 7/9] staging: kpc2000: remove unnecessary braces in cell_probe.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).