From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B28C282DD for ; Thu, 23 May 2019 12:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D618120879 for ; Thu, 23 May 2019 12:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730595AbfEWM5V (ORCPT ); Thu, 23 May 2019 08:57:21 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:45715 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbfEWM5U (ORCPT ); Thu, 23 May 2019 08:57:20 -0400 X-Originating-IP: 90.88.22.185 Received: from localhost (aaubervilliers-681-1-80-185.w90-88.abo.wanadoo.fr [90.88.22.185]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id CD843C0010; Thu, 23 May 2019 12:57:16 +0000 (UTC) Date: Thu, 23 May 2019 14:57:16 +0200 From: Maxime Ripard To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Chen-Yu Tsai , linux-watchdog@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel Subject: Re: [PATCH v4 3/5] dt-bindings: watchdog: add Allwinner H6 r_watchdog Message-ID: <20190523125716.g4euwplfsvw4vqzl@flea> References: <20190521160330.28402-1-peron.clem@gmail.com> <20190521160330.28402-4-peron.clem@gmail.com> <20190522103243.mmrfato5p2mhtf4j@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wdtcxmlg6dhvhpqj" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wdtcxmlg6dhvhpqj Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 22, 2019 at 06:15:26PM +0200, Cl=E9ment P=E9ron wrote: > Hi Maxime, > > On Wed, 22 May 2019 at 12:32, Maxime Ripard w= rote: > > > > On Tue, May 21, 2019 at 06:03:28PM +0200, Cl=E9ment P=E9ron wrote: > > > Allwinner H6 has a second watchdog on the r-blocks which is > > > compatible with the A31. > > > > > > This commit add the H6 compatible for the r_watchdog. > > > > > > Signed-off-by: Cl=E9ment P=E9ron > > > > Unless you have some evidence that the two blocks are different, then > > you should just reuse the same one. > > I have no evidence it's different nor identical, it's not documented > in the user manual. > I thought it would better to have separate bindings in case there is a > difference. > Than don't have and find later that we have to introduce one. It's a tradeoff. Pushing your logic to the limit, we would have a compatible for each controller embedded in an SoC. This would be unmaintainable, and slightly useless since that case is very unlikely. However, having differences between SoCs is quite common, hence why we have different compatibles for each SoC. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --wdtcxmlg6dhvhpqj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOaYrAAKCRDj7w1vZxhR xUPnAPsGJnjqxtkcj8BFHo1UbY6rBrhE114RafzPUtXuJD8o4QEAmWfFGwayxZZ0 63T2ZEyt/CbXZE9fTnSFpRsi3BkzQA4= =Frvc -----END PGP SIGNATURE----- --wdtcxmlg6dhvhpqj--