LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] input: silead: Add MSSL0017 to acpi_device_id.
@ 2019-05-23 19:06 Daniel Smith
  2019-05-23 19:55 ` Dmitry Torokhov
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Smith @ 2019-05-23 19:06 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Daniel Smith, Dmitry Torokhov, linux-input, platform-driver-x86,
	linux-kernel

On Chuwi Hi10 Plus, the Silead device id is MSSL0017.

Signed-off-by: Daniel Smith <danct12@disroot.org>
---
 drivers/input/touchscreen/silead.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
index 09241d4cdebc..06f0eb04a8fd 100644
--- a/drivers/input/touchscreen/silead.c
+++ b/drivers/input/touchscreen/silead.c
@@ -617,6 +617,7 @@ static const struct acpi_device_id silead_ts_acpi_match[] = {
 	{ "MSSL1680", 0 },
 	{ "MSSL0001", 0 },
 	{ "MSSL0002", 0 },
+	{ "MSSL0017", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, silead_ts_acpi_match);
-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] input: silead: Add MSSL0017 to acpi_device_id.
  2019-05-23 19:06 [PATCH] input: silead: Add MSSL0017 to acpi_device_id Daniel Smith
@ 2019-05-23 19:55 ` Dmitry Torokhov
  0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2019-05-23 19:55 UTC (permalink / raw)
  To: Daniel Smith
  Cc: Hans de Goede, linux-input, platform-driver-x86, linux-kernel

On Fri, May 24, 2019 at 02:06:59AM +0700, Daniel Smith wrote:
> On Chuwi Hi10 Plus, the Silead device id is MSSL0017.
> 
> Signed-off-by: Daniel Smith <danct12@disroot.org>

Applied keeping Hans' reviewed-by from the previous version; thank you.

> ---
>  drivers/input/touchscreen/silead.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
> index 09241d4cdebc..06f0eb04a8fd 100644
> --- a/drivers/input/touchscreen/silead.c
> +++ b/drivers/input/touchscreen/silead.c
> @@ -617,6 +617,7 @@ static const struct acpi_device_id silead_ts_acpi_match[] = {
>  	{ "MSSL1680", 0 },
>  	{ "MSSL0001", 0 },
>  	{ "MSSL0002", 0 },
> +	{ "MSSL0017", 0 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, silead_ts_acpi_match);
> -- 
> 2.21.0
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] input: silead: Add MSSL0017 to acpi_device_id.
  2019-05-22 10:12 ` Hans de Goede
@ 2019-05-23  7:20   ` Dmitry Torokhov
  0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2019-05-23  7:20 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Danct12, linux-input, platform-driver-x86, linux-kernel

On Wed, May 22, 2019 at 12:12:47PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 22-05-19 06:54, Danct12 wrote:
> > On Chuwi Hi10 Plus, the Silead device id is MSSL0017.
> > 
> > Signed-off-by: Danct12 <danct12@disroot.org>
> 
> Patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

We however need to have a real name for the Signed-off-by.

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] input: silead: Add MSSL0017 to acpi_device_id.
  2019-05-22  4:54 Danct12
@ 2019-05-22 10:12 ` Hans de Goede
  2019-05-23  7:20   ` Dmitry Torokhov
  0 siblings, 1 reply; 5+ messages in thread
From: Hans de Goede @ 2019-05-22 10:12 UTC (permalink / raw)
  To: Danct12; +Cc: Dmitry Torokhov, linux-input, platform-driver-x86, linux-kernel

Hi,

On 22-05-19 06:54, Danct12 wrote:
> On Chuwi Hi10 Plus, the Silead device id is MSSL0017.
> 
> Signed-off-by: Danct12 <danct12@disroot.org>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/input/touchscreen/silead.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
> index 09241d4cdebc..06f0eb04a8fd 100644
> --- a/drivers/input/touchscreen/silead.c
> +++ b/drivers/input/touchscreen/silead.c
> @@ -617,6 +617,7 @@ static const struct acpi_device_id silead_ts_acpi_match[] = {
>   	{ "MSSL1680", 0 },
>   	{ "MSSL0001", 0 },
>   	{ "MSSL0002", 0 },
> +	{ "MSSL0017", 0 },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, silead_ts_acpi_match);
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] input: silead: Add MSSL0017 to acpi_device_id.
@ 2019-05-22  4:54 Danct12
  2019-05-22 10:12 ` Hans de Goede
  0 siblings, 1 reply; 5+ messages in thread
From: Danct12 @ 2019-05-22  4:54 UTC (permalink / raw)
  To: hdegoede
  Cc: Danct12, Dmitry Torokhov, linux-input, platform-driver-x86, linux-kernel

On Chuwi Hi10 Plus, the Silead device id is MSSL0017.

Signed-off-by: Danct12 <danct12@disroot.org>
---
 drivers/input/touchscreen/silead.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
index 09241d4cdebc..06f0eb04a8fd 100644
--- a/drivers/input/touchscreen/silead.c
+++ b/drivers/input/touchscreen/silead.c
@@ -617,6 +617,7 @@ static const struct acpi_device_id silead_ts_acpi_match[] = {
 	{ "MSSL1680", 0 },
 	{ "MSSL0001", 0 },
 	{ "MSSL0002", 0 },
+	{ "MSSL0017", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, silead_ts_acpi_match);
-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-23 19:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 19:06 [PATCH] input: silead: Add MSSL0017 to acpi_device_id Daniel Smith
2019-05-23 19:55 ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2019-05-22  4:54 Danct12
2019-05-22 10:12 ` Hans de Goede
2019-05-23  7:20   ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).