LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Gen Zhang <blackgod016574@gmail.com>
Cc: rppt@linux.ibm.com, david.engraf@sysgo.com, steven.price@arm.com,
	osandov@fb.com, luc.vanoostenryck@gmail.com, axboe@kernel.dk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()
Date: Thu, 23 May 2019 20:35:23 -0700	[thread overview]
Message-ID: <20190523203523.8f638f378b54df0ef7a18f9d@linux-foundation.org> (raw)
In-Reply-To: <20190524033045.GA6628@zhanggen-UX430UQ>

On Fri, 24 May 2019 11:30:45 +0800 Gen Zhang <blackgod016574@gmail.com> wrote:

> In dir_add() and do_name(), de->name and vcollected are allocated by
> kstrdup(). And de->name and vcollected are dereferenced in the following
> codes. However, memory allocation functions such as kstrdup() may fail. 
> Dereferencing this null pointer may cause the kernel go wrong. Thus we
> should check these two kstrdup() operations.
> Further, if kstrdup() returns NULL, we should free de in dir_add().

We generally assume that memory allocations within __init code cannot
fail.  If one does fail, something quite horrid has happened.  The
resulting oops will provide the same information as the proposed panic()
anyway.

  reply	other threads:[~2019-05-24  3:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  3:30 Gen Zhang
2019-05-24  3:35 ` Andrew Morton [this message]
2019-05-24  3:45   ` [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()teven.price@arm.com、 Gen Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523203523.8f638f378b54df0ef7a18f9d@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=blackgod016574@gmail.com \
    --cc=david.engraf@sysgo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=osandov@fb.com \
    --cc=rppt@linux.ibm.com \
    --cc=steven.price@arm.com \
    --subject='Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).