LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Qiang Zhao <qiang.zhao@nxp.com>
To: "shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Qiang Zhao <qiang.zhao@nxp.com>
Subject: [PATCH] i2c: layerscape: use PIO when fail to request dma channel
Date: Fri, 24 May 2019 03:03:36 +0000	[thread overview]
Message-ID: <20190524030514.14082-1-qiang.zhao@nxp.com> (raw)

When fail to request DMA TX/RX channel, use PIO instead for layerscape.

Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
 drivers/i2c/busses/i2c-imx.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 98b278613cf2..39a5ab4cf332 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -347,9 +347,13 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
 
 	dma->chan_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(dma->chan_tx)) {
+#ifdef CONFIG_ARCH_LAYERSCAPE
+		dev_dbg(dev, "can't request DMA tx channel\n");
+#else
 		ret = PTR_ERR(dma->chan_tx);
 		if (ret != -ENODEV && ret != -EPROBE_DEFER)
 			dev_err(dev, "can't request DMA tx channel (%d)\n", ret);
+#endif
 		goto fail_al;
 	}
 
@@ -366,9 +370,13 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
 
 	dma->chan_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(dma->chan_rx)) {
+#ifdef CONFIG_ARCH_LAYERSCAPE
+		dev_dbg(dev, "can't request DMA rx channel\n");
+#else
 		ret = PTR_ERR(dma->chan_rx);
 		if (ret != -ENODEV && ret != -EPROBE_DEFER)
 			dev_err(dev, "can't request DMA rx channel (%d)\n", ret);
+#endif
 		goto fail_tx;
 	}
 
@@ -396,6 +404,9 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
 	dma_release_channel(dma->chan_tx);
 fail_al:
 	devm_kfree(dev, dma);
+#ifdef CONFIG_ARCH_LAYERSCAPE
+	dev_info(dev, "can't use DMA, using PIO instead.\n");
+#endif
 	/* return successfully if there is no dma support */
 	return ret == -ENODEV ? 0 : ret;
 }
-- 
2.17.1


             reply	other threads:[~2019-05-24  3:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  3:03 Qiang Zhao [this message]
2019-05-24 20:01 ` Yang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524030514.14082-1-qiang.zhao@nxp.com \
    --to=qiang.zhao@nxp.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH] i2c: layerscape: use PIO when fail to request dma channel' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).