LKML Archive on
help / color / mirror / Atom feed
From: Gen Zhang <>
To: Andrew Morton <>
Subject: Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()、
Date: Fri, 24 May 2019 11:45:17 +0800	[thread overview]
Message-ID: <20190524034517.GA6821@zhanggen-UX430UQ> (raw)
In-Reply-To: <>

On Thu, May 23, 2019 at 08:35:23PM -0700, Andrew Morton wrote:
> On Fri, 24 May 2019 11:30:45 +0800 Gen Zhang <> wrote:
> > In dir_add() and do_name(), de->name and vcollected are allocated by
> > kstrdup(). And de->name and vcollected are dereferenced in the following
> > codes. However, memory allocation functions such as kstrdup() may fail. 
> > Dereferencing this null pointer may cause the kernel go wrong. Thus we
> > should check these two kstrdup() operations.
> > Further, if kstrdup() returns NULL, we should free de in dir_add().
> We generally assume that memory allocations within __init code cannot
> fail.  If one does fail, something quite horrid has happened.  The
> resulting oops will provide the same information as the proposed panic()
> anyway.
Thanks for your reply, Andrew.
You mean that it is not necessary to check memory allcoation in __init,

      reply	other threads:[~2019-05-24  3:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  3:30 [PATCH v2] initramfs: Fix a missing-chek bug in dir_add() Gen Zhang
2019-05-24  3:35 ` Andrew Morton
2019-05-24  3:45   ` Gen Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524034517.GA6821@zhanggen-UX430UQ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()、' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).