LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] clocksource: arc_timer: use BIT() instead of _BITUL()
@ 2019-05-24  5:40 Masahiro Yamada
  2019-05-31 14:25 ` Daniel Lezcano
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-05-24  5:40 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner, linux-kernel
  Cc: Vineet Gupta, linux-snps-arc, Masahiro Yamada

This is in-kernel C code, so there is no reason to use _BITUL().
Replace it with equivalent BIT().

I added #include <linux/bits.h> explicitly although it has been included
by other headers eventually.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/clocksource/arc_timer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/arc_timer.c b/drivers/clocksource/arc_timer.c
index b28970ca4a7a..b1f21bf3b83c 100644
--- a/drivers/clocksource/arc_timer.c
+++ b/drivers/clocksource/arc_timer.c
@@ -16,6 +16,7 @@
  */
 
 #include <linux/interrupt.h>
+#include <linux/bits.h>
 #include <linux/clk.h>
 #include <linux/clk-provider.h>
 #include <linux/clocksource.h>
@@ -142,7 +143,7 @@ static u64 arc_read_rtc(struct clocksource *cs)
 		l = read_aux_reg(AUX_RTC_LOW);
 		h = read_aux_reg(AUX_RTC_HIGH);
 		status = read_aux_reg(AUX_RTC_CTRL);
-	} while (!(status & _BITUL(31)));
+	} while (!(status & BIT(31)));
 
 	return (((u64)h) << 32) | l;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clocksource: arc_timer: use BIT() instead of _BITUL()
  2019-05-24  5:40 [PATCH] clocksource: arc_timer: use BIT() instead of _BITUL() Masahiro Yamada
@ 2019-05-31 14:25 ` Daniel Lezcano
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2019-05-31 14:25 UTC (permalink / raw)
  To: Masahiro Yamada, Thomas Gleixner, linux-kernel
  Cc: Vineet Gupta, linux-snps-arc

On 24/05/2019 07:40, Masahiro Yamada wrote:
> This is in-kernel C code, so there is no reason to use _BITUL().
> Replace it with equivalent BIT().
> 
> I added #include <linux/bits.h> explicitly although it has been included
> by other headers eventually.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Applied, thanks!


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-31 14:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24  5:40 [PATCH] clocksource: arc_timer: use BIT() instead of _BITUL() Masahiro Yamada
2019-05-31 14:25 ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).